* [PATCH] drm/msm: remove unneeded variable ret
@ 2021-04-07 13:06 Bernard Zhao
2021-04-07 17:55 ` [Freedreno] " abhinavk
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bernard Zhao @ 2021-04-07 13:06 UTC (permalink / raw)
To: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Kuogee Hsieh,
Stephen Boyd, Abhinav Kumar, Tanmay Shah, Chandan Uddaraju,
Bernard Zhao, linux-arm-msm, dri-devel, freedreno, linux-kernel
This patch fix coccicheck warning:
drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return "0" on line 880
Also remove unneeded function return value check.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/msm/dp/dp_link.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
index be986da78c4a..3395b08155a6 100644
--- a/drivers/gpu/drm/msm/dp/dp_link.c
+++ b/drivers/gpu/drm/msm/dp/dp_link.c
@@ -843,10 +843,8 @@ bool dp_link_send_edid_checksum(struct dp_link *dp_link, u8 checksum)
return ret == 1;
}
-static int dp_link_parse_vx_px(struct dp_link_private *link)
+static void dp_link_parse_vx_px(struct dp_link_private *link)
{
- int ret = 0;
-
DRM_DEBUG_DP("vx: 0=%d, 1=%d, 2=%d, 3=%d\n",
drm_dp_get_adjust_request_voltage(link->link_status, 0),
drm_dp_get_adjust_request_voltage(link->link_status, 1),
@@ -876,8 +874,6 @@ static int dp_link_parse_vx_px(struct dp_link_private *link)
DRM_DEBUG_DP("Requested: v_level = 0x%x, p_level = 0x%x\n",
link->dp_link.phy_params.v_level,
link->dp_link.phy_params.p_level);
-
- return ret;
}
/**
@@ -891,8 +887,6 @@ static int dp_link_parse_vx_px(struct dp_link_private *link)
static int dp_link_process_phy_test_pattern_request(
struct dp_link_private *link)
{
- int ret = 0;
-
if (!(link->request.test_requested & DP_TEST_LINK_PHY_TEST_PATTERN)) {
DRM_DEBUG_DP("no phy test\n");
return -EINVAL;
@@ -918,12 +912,9 @@ static int dp_link_process_phy_test_pattern_request(
link->dp_link.link_params.rate =
drm_dp_bw_code_to_link_rate(link->request.test_link_rate);
- ret = dp_link_parse_vx_px(link);
-
- if (ret)
- DRM_ERROR("parse_vx_px failed. ret=%d\n", ret);
+ dp_link_parse_vx_px(link);
- return ret;
+ return 0;
}
static u8 get_link_status(const u8 link_status[DP_LINK_STATUS_SIZE], int r)
--
2.31.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Freedreno] [PATCH] drm/msm: remove unneeded variable ret
2021-04-07 13:06 [PATCH] drm/msm: remove unneeded variable ret Bernard Zhao
@ 2021-04-07 17:55 ` abhinavk
2021-04-07 18:22 ` Stephen Boyd
2021-05-26 0:55 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: abhinavk @ 2021-04-07 17:55 UTC (permalink / raw)
To: Bernard Zhao
Cc: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Kuogee Hsieh,
Stephen Boyd, Tanmay Shah, Chandan Uddaraju, linux-arm-msm,
dri-devel, freedreno, linux-kernel
On 2021-04-07 06:06, Bernard Zhao wrote:
> This patch fix coccicheck warning:
> drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret".
> Return "0" on line 880
> Also remove unneeded function return value check.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/dp/dp_link.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_link.c
> b/drivers/gpu/drm/msm/dp/dp_link.c
> index be986da78c4a..3395b08155a6 100644
> --- a/drivers/gpu/drm/msm/dp/dp_link.c
> +++ b/drivers/gpu/drm/msm/dp/dp_link.c
> @@ -843,10 +843,8 @@ bool dp_link_send_edid_checksum(struct dp_link
> *dp_link, u8 checksum)
> return ret == 1;
> }
>
> -static int dp_link_parse_vx_px(struct dp_link_private *link)
> +static void dp_link_parse_vx_px(struct dp_link_private *link)
> {
> - int ret = 0;
> -
> DRM_DEBUG_DP("vx: 0=%d, 1=%d, 2=%d, 3=%d\n",
> drm_dp_get_adjust_request_voltage(link->link_status, 0),
> drm_dp_get_adjust_request_voltage(link->link_status, 1),
> @@ -876,8 +874,6 @@ static int dp_link_parse_vx_px(struct
> dp_link_private *link)
> DRM_DEBUG_DP("Requested: v_level = 0x%x, p_level = 0x%x\n",
> link->dp_link.phy_params.v_level,
> link->dp_link.phy_params.p_level);
> -
> - return ret;
> }
>
> /**
> @@ -891,8 +887,6 @@ static int dp_link_parse_vx_px(struct
> dp_link_private *link)
> static int dp_link_process_phy_test_pattern_request(
> struct dp_link_private *link)
> {
> - int ret = 0;
> -
> if (!(link->request.test_requested & DP_TEST_LINK_PHY_TEST_PATTERN))
> {
> DRM_DEBUG_DP("no phy test\n");
> return -EINVAL;
> @@ -918,12 +912,9 @@ static int
> dp_link_process_phy_test_pattern_request(
> link->dp_link.link_params.rate =
> drm_dp_bw_code_to_link_rate(link->request.test_link_rate);
>
> - ret = dp_link_parse_vx_px(link);
> -
> - if (ret)
> - DRM_ERROR("parse_vx_px failed. ret=%d\n", ret);
> + dp_link_parse_vx_px(link);
>
> - return ret;
> + return 0;
> }
>
> static u8 get_link_status(const u8 link_status[DP_LINK_STATUS_SIZE],
> int r)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm: remove unneeded variable ret
2021-04-07 13:06 [PATCH] drm/msm: remove unneeded variable ret Bernard Zhao
2021-04-07 17:55 ` [Freedreno] " abhinavk
@ 2021-04-07 18:22 ` Stephen Boyd
2021-05-26 0:55 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-04-07 18:22 UTC (permalink / raw)
To: Abhinav Kumar, Bernard Zhao, Chandan Uddaraju, Daniel Vetter,
David Airlie, Kuogee Hsieh, Rob Clark, Sean Paul, Tanmay Shah,
dri-devel, freedreno, linux-arm-msm, linux-kernel
Quoting Bernard Zhao (2021-04-07 06:06:21)
> This patch fix coccicheck warning:
> drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return "0" on line 880
> Also remove unneeded function return value check.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm: remove unneeded variable ret
2021-04-07 13:06 [PATCH] drm/msm: remove unneeded variable ret Bernard Zhao
2021-04-07 17:55 ` [Freedreno] " abhinavk
2021-04-07 18:22 ` Stephen Boyd
@ 2021-05-26 0:55 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2021-05-26 0:55 UTC (permalink / raw)
To: Bernard Zhao, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Kuogee Hsieh, Stephen Boyd, Abhinav Kumar, Tanmay Shah,
Chandan Uddaraju, linux-arm-msm, dri-devel, freedreno,
linux-kernel
On 07/04/2021 16:06, Bernard Zhao wrote:
> This patch fix coccicheck warning:
> drivers/gpu/drm/msm/dp/dp_link.c:848:5-8: Unneeded variable: "ret". Return "0" on line 880
> Also remove unneeded function return value check.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/dp/dp_link.c | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
> index be986da78c4a..3395b08155a6 100644
> --- a/drivers/gpu/drm/msm/dp/dp_link.c
> +++ b/drivers/gpu/drm/msm/dp/dp_link.c
> @@ -843,10 +843,8 @@ bool dp_link_send_edid_checksum(struct dp_link *dp_link, u8 checksum)
> return ret == 1;
> }
>
> -static int dp_link_parse_vx_px(struct dp_link_private *link)
> +static void dp_link_parse_vx_px(struct dp_link_private *link)
> {
> - int ret = 0;
> -
> DRM_DEBUG_DP("vx: 0=%d, 1=%d, 2=%d, 3=%d\n",
> drm_dp_get_adjust_request_voltage(link->link_status, 0),
> drm_dp_get_adjust_request_voltage(link->link_status, 1),
> @@ -876,8 +874,6 @@ static int dp_link_parse_vx_px(struct dp_link_private *link)
> DRM_DEBUG_DP("Requested: v_level = 0x%x, p_level = 0x%x\n",
> link->dp_link.phy_params.v_level,
> link->dp_link.phy_params.p_level);
> -
> - return ret;
> }
>
> /**
> @@ -891,8 +887,6 @@ static int dp_link_parse_vx_px(struct dp_link_private *link)
> static int dp_link_process_phy_test_pattern_request(
> struct dp_link_private *link)
> {
> - int ret = 0;
> -
> if (!(link->request.test_requested & DP_TEST_LINK_PHY_TEST_PATTERN)) {
> DRM_DEBUG_DP("no phy test\n");
> return -EINVAL;
> @@ -918,12 +912,9 @@ static int dp_link_process_phy_test_pattern_request(
> link->dp_link.link_params.rate =
> drm_dp_bw_code_to_link_rate(link->request.test_link_rate);
>
> - ret = dp_link_parse_vx_px(link);
> -
> - if (ret)
> - DRM_ERROR("parse_vx_px failed. ret=%d\n", ret);
> + dp_link_parse_vx_px(link);
>
> - return ret;
> + return 0;
> }
>
> static u8 get_link_status(const u8 link_status[DP_LINK_STATUS_SIZE], int r)
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-26 0:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 13:06 [PATCH] drm/msm: remove unneeded variable ret Bernard Zhao
2021-04-07 17:55 ` [Freedreno] " abhinavk
2021-04-07 18:22 ` Stephen Boyd
2021-05-26 0:55 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).