* [PATCH -next] slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew()
@ 2018-05-22 11:46 Wei Yongjun
2018-05-23 13:42 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-05-22 11:46 UTC (permalink / raw)
To: Srinivas Kandagatla, Sagar Dharia
Cc: Wei Yongjun, alsa-devel, linux-kernel, kernel-janitors
platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.
This is detected by Coccinelle semantic patch.
@@
expression pdev, res, n, t, e, e1, e2;
@@
res = platform_get_resource_byname(pdev, t, n);
+ if (!res)
+ return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);
Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/slimbus/qcom-ctrl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
index bb36a8f..caea3b9 100644
--- a/drivers/slimbus/qcom-ctrl.c
+++ b/drivers/slimbus/qcom-ctrl.c
@@ -478,6 +478,8 @@ static void qcom_slim_prg_slew(struct platform_device *pdev,
/* SLEW RATE register for this SLIMbus */
slew_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"slew");
+ if (!slew_mem)
+ return;
ctrl->slew_reg = devm_ioremap(&pdev->dev, slew_mem->start,
resource_size(slew_mem));
if (!ctrl->slew_reg)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew()
2018-05-22 11:46 [PATCH -next] slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew() Wei Yongjun
@ 2018-05-23 13:42 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2018-05-23 13:42 UTC (permalink / raw)
To: Wei Yongjun, Sagar Dharia; +Cc: alsa-devel, linux-kernel, kernel-janitors
On 22/05/18 12:46, Wei Yongjun wrote:
> platform_get_resource() may fail and return NULL, so we should
> better check it's return value to avoid a NULL pointer dereference
> a bit later in the code.
>
> This is detected by Coccinelle semantic patch.
>
> @@
> expression pdev, res, n, t, e, e1, e2;
> @@
>
> res = platform_get_resource_byname(pdev, t, n);
> + if (!res)
> + return -EINVAL;
> ... when != res == NULL
> e = devm_ioremap(e1, res->start, e2);
>
> Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/slimbus/qcom-ctrl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
> index bb36a8f..caea3b9 100644
> --- a/drivers/slimbus/qcom-ctrl.c
> +++ b/drivers/slimbus/qcom-ctrl.c
> @@ -478,6 +478,8 @@ static void qcom_slim_prg_slew(struct platform_device *pdev,
> /* SLEW RATE register for this SLIMbus */
> slew_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "slew");
> + if (!slew_mem)
> + return;
I think a better fix would be to do a devm_ioremap_resource() instead of
devm_ioremap, which already has this check. This will also be inline
with other resource handled in this driver.
thanks,
srini
> ctrl->slew_reg = devm_ioremap(&pdev->dev, slew_mem->start,
> resource_size(slew_mem));
> if (!ctrl->slew_reg)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-23 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 11:46 [PATCH -next] slimbus: qcom: fix potential NULL dereference in qcom_slim_prg_slew() Wei Yongjun
2018-05-23 13:42 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).