* [PATCH] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe()
@ 2020-05-08 11:44 Tang Bin
2020-05-08 13:49 ` Alan Stern
0 siblings, 1 reply; 3+ messages in thread
From: Tang Bin @ 2020-05-08 11:44 UTC (permalink / raw)
To: stern, gregkh; +Cc: linux-usb, linux-kernel, Tang Bin, Zhang Shengju
Delete unused initialized value, because 'retval' will be assigined
by the function mv_ehci_enable().
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/usb/host/ehci-mv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index bd4f6ef53..1c079953e 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -108,7 +108,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
struct ehci_hcd *ehci;
struct ehci_hcd_mv *ehci_mv;
struct resource *r;
- int retval = -ENODEV;
+ int retval;
u32 offset;
if (usb_disabled())
@@ -142,8 +142,6 @@ static int mv_ehci_probe(struct platform_device *pdev)
goto err_put_hcd;
}
-
-
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ehci_mv->base = devm_ioremap_resource(&pdev->dev, r);
if (IS_ERR(ehci_mv->base)) {
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe()
2020-05-08 11:44 [PATCH] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe() Tang Bin
@ 2020-05-08 13:49 ` Alan Stern
2020-05-08 14:04 ` Tang Bin
0 siblings, 1 reply; 3+ messages in thread
From: Alan Stern @ 2020-05-08 13:49 UTC (permalink / raw)
To: Tang Bin; +Cc: gregkh, linux-usb, linux-kernel, Zhang Shengju
On Fri, 8 May 2020, Tang Bin wrote:
> Delete unused initialized value, because 'retval' will be assigined
> by the function mv_ehci_enable().
This should also mention the extra blank line that the patch removes.
Alan Stern
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/usb/host/ehci-mv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
> index bd4f6ef53..1c079953e 100644
> --- a/drivers/usb/host/ehci-mv.c
> +++ b/drivers/usb/host/ehci-mv.c
> @@ -108,7 +108,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
> struct ehci_hcd *ehci;
> struct ehci_hcd_mv *ehci_mv;
> struct resource *r;
> - int retval = -ENODEV;
> + int retval;
> u32 offset;
>
> if (usb_disabled())
> @@ -142,8 +142,6 @@ static int mv_ehci_probe(struct platform_device *pdev)
> goto err_put_hcd;
> }
>
> -
> -
> r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> ehci_mv->base = devm_ioremap_resource(&pdev->dev, r);
> if (IS_ERR(ehci_mv->base)) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe()
2020-05-08 13:49 ` Alan Stern
@ 2020-05-08 14:04 ` Tang Bin
0 siblings, 0 replies; 3+ messages in thread
From: Tang Bin @ 2020-05-08 14:04 UTC (permalink / raw)
To: Alan Stern; +Cc: gregkh, linux-usb, linux-kernel
On 2020/5/8 21:49, Alan Stern wrote:
> On Fri, 8 May 2020, Tang Bin wrote:
>
>> Delete unused initialized value, because 'retval' will be assigined
>> by the function mv_ehci_enable().
> This should also mention the extra blank line that the patch removes.
Sorry, my mistake, I'll send v2 for you.
Thanks,
Tang Bin
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-08 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 11:44 [PATCH] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe() Tang Bin
2020-05-08 13:49 ` Alan Stern
2020-05-08 14:04 ` Tang Bin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).