From: Kirill Marinushkin <k.marinushkin@gmail.com>
To: Takashi Iwai <tiwai@suse.de>, Mike Brady <mikebrady@eircom.net>
Cc: stefan.wahren@i2se.com, devel@driverdev.osuosl.org,
alsa-devel@alsa-project.org, f.fainelli@gmail.com,
eric@anholt.net, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr,
linux-rpi-kernel@lists.infradead.org,
nishka.dasgupta_ug18@ashoka.edu.in,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay
Date: Thu, 25 Oct 2018 19:20:40 +0200 [thread overview]
Message-ID: <5bc8295a-1e38-99b5-d54c-72e920600f83@gmail.com> (raw)
In-Reply-To: <s5hftwuo4t0.wl-tiwai@suse.de>
Hello Takashi, Mike,
@Takashi
On 10/25/18 09:37, Takashi Iwai wrote:
> Well, in the API POV, it's nothing wrong to keep hwptr sticking while
> updating only delay value. It implies that the hardware chip doesn't
> provide the hwptr update.
Thank you for the clarification. Modifying `runtime->delay` from the `pointer`
function looked wrong for me. Now I understand the motivation and the use-case.
I will be more careful when analyzing the code which doesn't fit my expectations.
@Mike
I was wrong. You can ignore my comments. Please don't take them personal: it's
all about having high-quality code in kernel.
Best Regards,
Kirill
next prev parent reply other threads:[~2018-10-25 17:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 10:57 [PATCH] staging: bcm2835-audio: interpolate audio delay Mike Brady
2018-10-18 11:02 ` Takashi Iwai
2018-10-18 19:48 ` Kirill Marinushkin
2018-10-22 19:08 ` Mike Brady
2018-10-22 19:17 ` [PATCH v2] " Mike Brady
2018-10-22 22:25 ` Kirill Marinushkin
2018-10-24 8:20 ` [alsa-devel] " Mike Brady
2018-10-24 18:06 ` Kirill Marinushkin
2018-10-24 19:54 ` Mike Brady
2018-10-24 22:02 ` Kirill Marinushkin
2018-10-25 7:37 ` Takashi Iwai
2018-10-25 17:20 ` Kirill Marinushkin [this message]
2018-10-28 14:24 ` Mike Brady
2018-10-28 14:26 ` Mike Brady
2018-11-05 15:57 ` Mike Brady
2018-11-05 16:11 ` Takashi Iwai
2018-11-06 21:05 ` Mike Brady
2018-11-06 21:31 ` Takashi Iwai
2018-11-11 18:08 ` Mike Brady
2018-11-11 18:21 ` [PATCH v2] ARM: " Mike Brady
2018-11-11 20:18 ` Stefan Wahren
2018-11-13 16:50 ` Takashi Iwai
2019-01-01 10:02 ` Mike Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc8295a-1e38-99b5-d54c-72e920600f83@gmail.com \
--to=k.marinushkin@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mikebrady@eircom.net \
--cc=nishka.dasgupta_ug18@ashoka.edu.in \
--cc=stefan.wahren@i2se.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).