From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: William Breathitt Gray <vilhelm.gray@gmail.com>, jic23@kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de,
a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com,
gwendal@chromium.org, alexandre.belloni@bootlin.com,
david@lechnology.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com,
patrick.havelange@essensium.com, fabrice.gasnier@st.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
o.rempel@pengutronix.de
Subject: Re: [PATCH v12 00/17] Introduce the Counter character device interface
Date: Tue, 6 Jul 2021 14:40:01 +0300 [thread overview]
Message-ID: <5bdd9ee6-86af-3bcc-43ff-418fd1a2e3e8@linux.intel.com> (raw)
In-Reply-To: <cover.1625471640.git.vilhelm.gray@gmail.com>
Hi
On 7/5/21 11:18 AM, William Breathitt Gray wrote:
> To summarize the main points of this patchset: there are no changes to
> the existing Counter sysfs userspace interface; a Counter character
> device interface is introduced that allows Counter events and associated
> data to be read() by userspace; the events_configure() and
> watch_validate() driver callbacks are introduced to support Counter
> events; and IRQ support is added to the 104-QUAD-8 driver, serving as an
> example of how to support the new Counter events functionality.
>
I quickly tested this set on top of linux-next next-20210706 and didn't
see any issue with intel-qep.c. However I noticed two mutex issues in
patch 15/17. Perhaps visible due the CONFIG_DEBUG_MUTEXES=y etc. I have on.
I'll be out of office next few weeks so cannot test if you have a new
version meanwhile but wanted to share no show stopper from intel-qep.c
and those two mutex warnings.
Jarkko
next prev parent reply other threads:[~2021-07-06 12:06 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 8:18 [PATCH v12 00/17] Introduce the Counter character device interface William Breathitt Gray
2021-07-05 8:18 ` [PATCH v12 01/17] counter: 104-quad-8: Return error when invalid mode during ceiling_write William Breathitt Gray
2021-07-05 8:18 ` [PATCH v12 02/17] counter: Return error code on invalid modes William Breathitt Gray
2021-07-09 17:40 ` David Lechner
2021-07-05 8:18 ` [PATCH v12 03/17] counter: Standardize to ERANGE for limit exceeded errors William Breathitt Gray
2021-07-05 8:18 ` [PATCH v12 04/17] counter: Rename counter_signal_value to counter_signal_level William Breathitt Gray
2021-07-05 8:18 ` [PATCH v12 05/17] counter: Rename counter_count_function to counter_function William Breathitt Gray
2021-07-05 8:18 ` [PATCH v12 06/17] counter: Internalize sysfs interface code William Breathitt Gray
2021-07-11 9:49 ` Syed Nayyar Waris
2021-07-11 11:42 ` Jonathan Cameron
2021-07-05 8:18 ` [PATCH v12 07/17] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray
2021-07-09 17:49 ` David Lechner
2021-07-10 9:41 ` William Breathitt Gray
2021-07-05 8:18 ` [PATCH v12 08/17] docs: counter: Update " William Breathitt Gray
2021-07-09 17:56 ` David Lechner
2021-07-05 8:18 ` [PATCH v12 09/17] counter: Move counter enums to uapi header William Breathitt Gray
2021-07-05 8:18 ` [PATCH v12 10/17] counter: Add character device interface William Breathitt Gray
2021-07-10 19:37 ` David Lechner
2021-07-11 12:20 ` Jonathan Cameron
2021-07-12 10:28 ` William Breathitt Gray
2021-07-05 8:18 ` [PATCH v12 11/17] docs: counter: Document " William Breathitt Gray
2021-07-10 20:15 ` David Lechner
2021-07-11 10:41 ` William Breathitt Gray
2021-07-05 8:19 ` [PATCH v12 12/17] tools/counter: Create Counter tools William Breathitt Gray
2021-07-10 16:53 ` David Lechner
2021-07-11 11:28 ` William Breathitt Gray
2021-07-11 14:05 ` David Lechner
2021-07-11 13:22 ` Jonathan Cameron
2021-07-05 8:19 ` [PATCH v12 13/17] counter: Implement signalZ_action_component_id sysfs attribute William Breathitt Gray
2021-07-10 16:20 ` David Lechner
2021-07-05 8:19 ` [PATCH v12 14/17] counter: Implement *_component_id sysfs attributes William Breathitt Gray
2021-07-10 17:06 ` David Lechner
2021-07-11 13:28 ` Jonathan Cameron
2021-07-11 14:08 ` David Lechner
2021-07-12 10:19 ` Jonathan Cameron
2021-07-05 8:19 ` [PATCH v12 15/17] counter: Implement events_queue_size sysfs attribute William Breathitt Gray
2021-07-06 7:48 ` Dan Carpenter
2021-07-06 11:40 ` Jarkko Nikula
2021-07-10 10:25 ` William Breathitt Gray
2021-07-10 15:43 ` David Lechner
2021-07-10 16:08 ` David Lechner
2021-07-10 17:53 ` David Lechner
2021-07-11 9:12 ` William Breathitt Gray
2021-07-05 8:19 ` [PATCH v12 16/17] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray
2021-07-05 8:19 ` [PATCH v12 17/17] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray
2021-07-11 13:44 ` Jonathan Cameron
2021-07-12 10:59 ` William Breathitt Gray
2021-07-06 11:40 ` Jarkko Nikula [this message]
2021-07-07 0:28 ` [PATCH v12 00/17] Introduce the Counter character device interface William Breathitt Gray
2021-07-11 13:48 ` Jonathan Cameron
2021-07-12 10:48 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bdd9ee6-86af-3bcc-43ff-418fd1a2e3e8@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=a.fatoum@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=david@lechnology.com \
--cc=fabrice.gasnier@st.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=kamel.bouhara@bootlin.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=patrick.havelange@essensium.com \
--cc=syednwaris@gmail.com \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).