* [PATCH net-next] net: phy: Make iproc_mdio_resume static
@ 2020-05-07 8:03 Zheng Zengkai
2020-05-07 15:43 ` Florian Fainelli
2020-05-07 19:55 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Zheng Zengkai @ 2020-05-07 8:03 UTC (permalink / raw)
To: andrew, davem, rjui
Cc: f.fainelli, bcm-kernel-feedback-list, netdev, linux-kernel, zhengzengkai
Fix sparse warnings:
drivers/net/phy/mdio-bcm-iproc.c:182:5: warning:
symbol 'iproc_mdio_resume' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
---
drivers/net/phy/mdio-bcm-iproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-bcm-iproc.c
index f1ded03f0229..89bdfcc0e506 100644
--- a/drivers/net/phy/mdio-bcm-iproc.c
+++ b/drivers/net/phy/mdio-bcm-iproc.c
@@ -179,7 +179,7 @@ static int iproc_mdio_remove(struct platform_device *pdev)
}
#ifdef CONFIG_PM_SLEEP
-int iproc_mdio_resume(struct device *dev)
+static int iproc_mdio_resume(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct iproc_mdio_priv *priv = platform_get_drvdata(pdev);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: Make iproc_mdio_resume static
2020-05-07 8:03 [PATCH net-next] net: phy: Make iproc_mdio_resume static Zheng Zengkai
@ 2020-05-07 15:43 ` Florian Fainelli
2020-05-07 19:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-05-07 15:43 UTC (permalink / raw)
To: Zheng Zengkai, andrew, davem, rjui
Cc: bcm-kernel-feedback-list, netdev, linux-kernel
On 5/7/2020 1:03 AM, Zheng Zengkai wrote:
> Fix sparse warnings:
>
> drivers/net/phy/mdio-bcm-iproc.c:182:5: warning:
> symbol 'iproc_mdio_resume' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: Make iproc_mdio_resume static
2020-05-07 8:03 [PATCH net-next] net: phy: Make iproc_mdio_resume static Zheng Zengkai
2020-05-07 15:43 ` Florian Fainelli
@ 2020-05-07 19:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-05-07 19:55 UTC (permalink / raw)
To: zhengzengkai
Cc: andrew, rjui, f.fainelli, bcm-kernel-feedback-list, netdev, linux-kernel
From: Zheng Zengkai <zhengzengkai@huawei.com>
Date: Thu, 7 May 2020 16:03:26 +0800
> Fix sparse warnings:
>
> drivers/net/phy/mdio-bcm-iproc.c:182:5: warning:
> symbol 'iproc_mdio_resume' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-07 19:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 8:03 [PATCH net-next] net: phy: Make iproc_mdio_resume static Zheng Zengkai
2020-05-07 15:43 ` Florian Fainelli
2020-05-07 19:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).