From: Thara Gopinath <thara.gopinath@linaro.org>
To: Zhang Rui <rui.zhang@intel.com>,
daniel.lezcano@linaro.org, robh+dt@kernel.org
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 4/4] thermal: Modify thermal governors to do nothing for "cold" trip points
Date: Wed, 15 Jul 2020 19:13:08 -0400 [thread overview]
Message-ID: <5c9eec96-79b6-3499-fe06-7312504ffc4a@linaro.org> (raw)
In-Reply-To: <d2eeca29328a87433a46c35947ffb490d49c168a.camel@intel.com>
On 7/15/20 4:35 AM, Zhang Rui wrote:
> On Fri, 2020-07-10 at 09:51 -0400, Thara Gopinath wrote:
>> For now, thermal governors do not support monitoring of falling
>> temperature. Hence, in case of calls to the governor for trip points
>> marked
>> as cold, return doing nothing.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>> ---
>> drivers/thermal/gov_bang_bang.c | 8 ++++++++
>> drivers/thermal/gov_fair_share.c | 8 ++++++++
>> drivers/thermal/gov_power_allocator.c | 8 ++++++++
>> drivers/thermal/gov_step_wise.c | 8 ++++++++
>> 4 files changed, 32 insertions(+)
>
> userspace governor does not support cold trip point neither.
>
> So how about adding the check in handle_non_critical_trips first, and
> remove the check later, after all the governors support cold trip?
Yeah, no governors support cold trip for now. Putting check in
handle_non_critical_trips is another way to handle this. I can do it and
come back to this solution when one or more governors start supporting
cold trip points.
--
Warm Regards
Thara
next prev parent reply other threads:[~2020-07-15 23:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 13:51 [RFC PATCH 0/4] thermal: Introduce support for monitoring falling temperature Thara Gopinath
2020-07-10 13:51 ` [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type Thara Gopinath
2020-07-13 15:05 ` Daniel Lezcano
2020-07-13 17:01 ` Thara Gopinath
2020-07-13 17:03 ` Daniel Lezcano
2020-07-10 13:51 ` [RFC PATCH 2/4] thermal: Add support for cold trip point Thara Gopinath
2020-07-10 13:51 ` [RFC PATCH 3/4] thermal:core:Add genetlink notifications for monitoring falling temperature Thara Gopinath
2020-07-15 8:46 ` Zhang Rui
2020-07-15 23:15 ` Thara Gopinath
2020-07-10 13:51 ` [RFC PATCH 4/4] thermal: Modify thermal governors to do nothing for "cold" trip points Thara Gopinath
2020-07-15 8:35 ` Zhang Rui
2020-07-15 23:13 ` Thara Gopinath [this message]
2020-07-13 15:03 ` [RFC PATCH 0/4] thermal: Introduce support for monitoring falling temperature Daniel Lezcano
2020-07-14 13:49 ` Zhang Rui
2020-07-14 21:39 ` Thara Gopinath
2020-07-15 8:27 ` Zhang Rui
2020-07-15 23:10 ` Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c9eec96-79b6-3499-fe06-7312504ffc4a@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).