linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: display/panel: Add missing unit names
@ 2019-03-25 16:08 Guido Günther
  2019-03-31  6:41 ` Rob Herring
  2019-04-03 16:15 ` Thierry Reding
  0 siblings, 2 replies; 3+ messages in thread
From: Guido Günther @ 2019-03-25 16:08 UTC (permalink / raw)
  To: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
	Mark Rutland, dri-devel, devicetree, linux-kernel, Fabio Estevam

Some examples were missing the unit names triggering

 Warning (unit_address_vs_reg): .../panel: node has a reg or ranges property, but no unit name

warnings when used verbatim in DTs and running dtc with W=1.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 .../devicetree/bindings/display/panel/innolux,p079zca.txt       | 2 +-
 .../devicetree/bindings/display/panel/innolux,p097pfg.txt       | 2 +-
 .../devicetree/bindings/display/panel/kingdisplay,kd097d04.txt  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt b/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt
index d0f55161579a..3ab8c7412cf6 100644
--- a/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt
+++ b/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt
@@ -12,7 +12,7 @@ Optional properties:
 Example:
 
 	&mipi_dsi {
-		panel {
+		panel@0 {
 			compatible = "innolux,p079zca";
 			reg = <0>;
 			power-supply = <...>;
diff --git a/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.txt b/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.txt
index 595d9dfeffd3..d1cab3a8f0fb 100644
--- a/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.txt
+++ b/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.txt
@@ -13,7 +13,7 @@ Optional properties:
 Example:
 
 	&mipi_dsi {
-		panel {
+		panel@0 {
 			compatible = "innolux,p079zca";
 			reg = <0>;
 			avdd-supply = <...>;
diff --git a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd097d04.txt b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd097d04.txt
index 164a5fa236da..cfefff688614 100644
--- a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd097d04.txt
+++ b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd097d04.txt
@@ -12,7 +12,7 @@ Optional properties:
 Example:
 
 	&mipi_dsi {
-		panel {
+		panel@0 {
 			compatible = "kingdisplay,kd097d04";
 			reg = <0>;
 			power-supply = <...>;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: display/panel: Add missing unit names
  2019-03-25 16:08 [PATCH] dt-bindings: display/panel: Add missing unit names Guido Günther
@ 2019-03-31  6:41 ` Rob Herring
  2019-04-03 16:15 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-03-31  6:41 UTC (permalink / raw)
  To: Guido Günther
  Cc: Thierry Reding, David Airlie, Daniel Vetter, Mark Rutland,
	dri-devel, devicetree, linux-kernel, Fabio Estevam

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

On Mon, 25 Mar 2019 17:08:10 +0100, =?UTF-8?q?Guido=20G=C3=BCnther?= wrote:
> Some examples were missing the unit names triggering
> 
>  Warning (unit_address_vs_reg): .../panel: node has a reg or ranges property, but no unit name
> 
> warnings when used verbatim in DTs and running dtc with W=1.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
>  .../devicetree/bindings/display/panel/innolux,p079zca.txt       | 2 +-
>  .../devicetree/bindings/display/panel/innolux,p097pfg.txt       | 2 +-
>  .../devicetree/bindings/display/panel/kingdisplay,kd097d04.txt  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: display/panel: Add missing unit names
  2019-03-25 16:08 [PATCH] dt-bindings: display/panel: Add missing unit names Guido Günther
  2019-03-31  6:41 ` Rob Herring
@ 2019-04-03 16:15 ` Thierry Reding
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2019-04-03 16:15 UTC (permalink / raw)
  To: Guido Günther
  Cc: David Airlie, Daniel Vetter, Rob Herring, Mark Rutland,
	dri-devel, devicetree, linux-kernel, Fabio Estevam

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

On Mon, Mar 25, 2019 at 05:08:10PM +0100, Guido Günther wrote:
> Some examples were missing the unit names triggering
> 
>  Warning (unit_address_vs_reg): .../panel: node has a reg or ranges property, but no unit name
> 
> warnings when used verbatim in DTs and running dtc with W=1.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
>  .../devicetree/bindings/display/panel/innolux,p079zca.txt       | 2 +-
>  .../devicetree/bindings/display/panel/innolux,p097pfg.txt       | 2 +-
>  .../devicetree/bindings/display/panel/kingdisplay,kd097d04.txt  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-03 16:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 16:08 [PATCH] dt-bindings: display/panel: Add missing unit names Guido Günther
2019-03-31  6:41 ` Rob Herring
2019-04-03 16:15 ` Thierry Reding

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).