From: Jiri Slaby <jirislaby@kernel.org>
To: Jann Horn <jannh@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: Remove dead termiox code
Date: Fri, 4 Dec 2020 08:22:41 +0100 [thread overview]
Message-ID: <5cca5126-60ba-d123-0f7d-47fdbac4c4db@kernel.org> (raw)
In-Reply-To: <20201203020331.2394754-1-jannh@google.com>
On 03. 12. 20, 3:03, Jann Horn wrote:
> set_termiox() and the TCGETX handler bail out with -EINVAL immediately
> if ->termiox is NULL, but there are no code paths that can set
> ->termiox to a non-NULL pointer; and no such code paths seem to have
> existed since the termiox mechanism was introduced back in
> commit 1d65b4a088de ("tty: Add termiox") in v2.6.28.
> Similarly, no driver actually implements .set_termiox; and it looks like
> no driver ever has.
Nice!
> Delete this dead code; but leave the definition of struct termiox in the
> UAPI headers intact.
I am thinking -- can/should we mark the structure as deprecated so that
userspace stops using it eventually?
--
js
next prev parent reply other threads:[~2020-12-04 7:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 2:03 [PATCH] tty: Remove dead termiox code Jann Horn
2020-12-03 18:43 ` Greg Kroah-Hartman
2020-12-04 7:22 ` Jiri Slaby [this message]
2020-12-04 8:17 ` Greg Kroah-Hartman
2020-12-04 8:20 ` Jiri Slaby
2020-12-04 8:36 ` Greg Kroah-Hartman
2020-12-04 8:51 ` Jiri Slaby
2020-12-04 9:10 ` Greg Kroah-Hartman
2020-12-07 10:19 ` Adam Borowski
2020-12-07 13:57 ` Greg Kroah-Hartman
2020-12-08 11:13 ` Christoph Hellwig
2020-12-08 11:23 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cca5126-60ba-d123-0f7d-47fdbac4c4db@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).