linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 02/17] OMAP: Add TI OMAP1610 accelerator entry.
@ 2007-06-26 12:34 Trilok Soni
  2007-06-26 16:52 ` Sam Ravnborg
  0 siblings, 1 reply; 3+ messages in thread
From: Trilok Soni @ 2007-06-26 12:34 UTC (permalink / raw)
  To: linux-fbdev-devel, adaplas, akpm
  Cc: Tony Lindgren, imre.deak, juha.yrjola, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 18 bytes --]

-- 
--Trilok Soni

[-- Attachment #2: 0002-OMAP-Add-TI-OMAP1610-accelerator-entry.patch --]
[-- Type: text/x-patch, Size: 1025 bytes --]

From 1f9d5862e4d4d078f38a3a033b739457f24ef986 Mon Sep 17 00:00:00 2001
From: Imre Deak <imre.deak@solidboot.com>
Date: Sat, 26 May 2007 19:19:19 +0530
Subject: [PATCH 02/17] OMAP: Add TI OMAP1610 accelerator entry.

Signed-off-by: Trilok Soni <soni.trilok@gmail.com>
---
 include/linux/fb.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/fb.h b/include/linux/fb.h
index 6622682..cb40250 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -119,6 +119,7 @@ struct dentry;
 #define FB_ACCEL_NV_40          46      /* nVidia Arch 40               */
 #define FB_ACCEL_XGI_VOLARI_V	47	/* XGI Volari V3XT, V5, V8      */
 #define FB_ACCEL_XGI_VOLARI_Z	48	/* XGI Volari Z7                */
+#define FB_ACCEL_OMAP1610	49	/* TI OMAP16xx                  */
 #define FB_ACCEL_NEOMAGIC_NM2070 90	/* NeoMagic NM2070              */
 #define FB_ACCEL_NEOMAGIC_NM2090 91	/* NeoMagic NM2090              */
 #define FB_ACCEL_NEOMAGIC_NM2093 92	/* NeoMagic NM2093              */
-- 
1.5.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 02/17] OMAP: Add TI OMAP1610 accelerator entry.
  2007-06-26 12:34 [PATCH 02/17] OMAP: Add TI OMAP1610 accelerator entry Trilok Soni
@ 2007-06-26 16:52 ` Sam Ravnborg
  2007-06-27 11:30   ` Trilok Soni
  0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2007-06-26 16:52 UTC (permalink / raw)
  To: Trilok Soni
  Cc: linux-fbdev-devel, adaplas, akpm, Tony Lindgren, imre.deak,
	juha.yrjola, linux-kernel

Your patch ordering is bad.
Patch 1 uses the symbol: FB_ACCEL_OMAP1610
but it is defined by patch 2.

Please reorder patches so the module compiles for each
and every patch being applied.

In this way you do not break git bisect for example.

	Sam

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 02/17] OMAP: Add TI OMAP1610 accelerator entry.
  2007-06-26 16:52 ` Sam Ravnborg
@ 2007-06-27 11:30   ` Trilok Soni
  0 siblings, 0 replies; 3+ messages in thread
From: Trilok Soni @ 2007-06-27 11:30 UTC (permalink / raw)
  To: Sam Ravnborg
  Cc: linux-fbdev-devel, adaplas, akpm, Tony Lindgren, imre.deak,
	juha.yrjola, linux-kernel

On 6/26/07, Sam Ravnborg <sam@ravnborg.org> wrote:
> Your patch ordering is bad.
> Patch 1 uses the symbol: FB_ACCEL_OMAP1610
> but it is defined by patch 2.
>
> Please reorder patches so the module compiles for each
> and every patch being applied.
>
> In this way you do not break git bisect for example.
>

Yes, in this case I will merge 1st and 2nd patch.

-- 
--Trilok Soni

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-06-27 11:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-26 12:34 [PATCH 02/17] OMAP: Add TI OMAP1610 accelerator entry Trilok Soni
2007-06-26 16:52 ` Sam Ravnborg
2007-06-27 11:30   ` Trilok Soni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).