From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Nadav Amit <nadav.amit@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v3 2/3] selftests: soft-dirty: Add test for mprotect
Date: Fri, 22 Jul 2022 16:07:47 +0200 [thread overview]
Message-ID: <5d6c745e-219c-3abf-a30d-b3fb8e8e752c@redhat.com> (raw)
In-Reply-To: <8fd4d9fa-7370-3d97-20d0-a4dfed914600@redhat.com>
On 22.07.22 16:00, David Hildenbrand wrote:
> On 22.07.22 15:44, Peter Xu wrote:
>> On Fri, Jul 22, 2022 at 09:17:34AM +0200, David Hildenbrand wrote:
>>> On 21.07.22 20:33, Peter Xu wrote:
>>>> Add two soft-diryt test cases for mprotect() on both anon or file.
>>>
>>> s/soft-diryt/soft-dirty/
>>
>> Fixed.
>>
>>>
>>>>
>>>> Signed-off-by: Peter Xu <peterx@redhat.com>
>>>> ---
>>>> tools/testing/selftests/vm/soft-dirty.c | 69 ++++++++++++++++++++++++-
>>>> 1 file changed, 68 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/tools/testing/selftests/vm/soft-dirty.c b/tools/testing/selftests/vm/soft-dirty.c
>>>> index 08ab62a4a9d0..7d93906aa43f 100644
>>>> --- a/tools/testing/selftests/vm/soft-dirty.c
>>>> +++ b/tools/testing/selftests/vm/soft-dirty.c
>>>> @@ -121,13 +121,78 @@ static void test_hugepage(int pagemap_fd, int pagesize)
>>>> free(map);
>>>> }
>>>>
>>>> +static void test_mprotect(int pagemap_fd, int pagesize, bool anon)
>>>> +{
>>>> + const char *type[] = {"file", "anon"};
>>>> + const char *fname = "./soft-dirty-test-file";
>>>> + int test_fd;
>>>> + char *map;
>>>
>>> Instead of fname, unlink, open, close, unlink you can use a tmpfile
>>>
>>> FILE *file;
>>>
>>> file = tmpfile();
>>> if (!file) {
>>> ksft_test_result_fail("tmpfile() failed\n");
>>> return;
>>> }
>>> test_fd = fileno(file);
>>
>> Note that tmpfile() should by default fetch from /tmp which is very
>> possibly a tmpfs afaict. It's tricky in this special test case since I
>> don't think tmpfs can trigger this bug (shmem doesn't define page_mkwrite).
>>
>
> I don't think we need that? SOFTDIRTY tracking enabled should be
> sufficient, or what am I missing?
>
I think you're right that it doesn't work with tmpfile. I do wonder why,
because I'd have thought that it's sufficient for
vma_wants_writenotify() to return "1" due to the
vma_soft_dirty_enabled() check.
Hm ....
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-07-22 14:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 18:33 [PATCH v3 0/3] mm/mprotect: Fix soft-dirty checks Peter Xu
2022-07-21 18:33 ` [PATCH v3 1/3] mm/mprotect: Fix soft-dirty check in can_change_pte_writable() Peter Xu
2022-07-22 7:08 ` David Hildenbrand
2022-07-22 13:51 ` Peter Xu
2022-07-22 13:59 ` David Hildenbrand
2022-07-22 17:21 ` Nadav Amit
2022-07-25 13:59 ` Peter Xu
2022-07-25 14:11 ` David Hildenbrand
2022-07-21 18:33 ` [PATCH v3 2/3] selftests: soft-dirty: Add test for mprotect Peter Xu
2022-07-22 7:17 ` David Hildenbrand
2022-07-22 13:44 ` Peter Xu
2022-07-22 14:00 ` David Hildenbrand
2022-07-22 14:07 ` David Hildenbrand [this message]
2022-07-22 14:37 ` Peter Xu
2022-07-21 18:33 ` [PATCH v3 3/3] selftests: Add soft-dirty into run_vmtests.sh Peter Xu
2022-07-22 7:18 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d6c745e-219c-3abf-a30d-b3fb8e8e752c@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nadav.amit@gmail.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).