From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Nadav Amit <nadav.amit@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v3 1/3] mm/mprotect: Fix soft-dirty check in can_change_pte_writable()
Date: Fri, 22 Jul 2022 15:59:03 +0200 [thread overview]
Message-ID: <a85537d0-d828-2049-6f8e-3272156ae1ed@redhat.com> (raw)
In-Reply-To: <Ytqrb0ffgs+tA+0n@xz-m1.local>
On 22.07.22 15:51, Peter Xu wrote:
> On Fri, Jul 22, 2022 at 09:08:59AM +0200, David Hildenbrand wrote:
>> On 21.07.22 20:33, Peter Xu wrote:
>>> The check wanted to make sure when soft-dirty tracking is enabled we won't
>>> grant write bit by accident, as a page fault is needed for dirty tracking.
>>> The intention is correct but we didn't check it right because VM_SOFTDIRTY
>>> set actually means soft-dirty tracking disabled. Fix it.
>>>
>>> There's another thing tricky about soft-dirty is that, we can't check the
>>> vma flag !(vma_flags & VM_SOFTDIRTY) directly but only check it after we
>>> checked CONFIG_MEM_SOFT_DIRTY because otherwise VM_SOFTDIRTY will be
>>> defined as zero, and !(vma_flags & VM_SOFTDIRTY) will constantly return
>>> true. To avoid misuse, introduce a helper for checking whether vma has
>>> soft-dirty tracking enabled.
>>>
>>
>>
>> [...]
>>
>>>
>>> Here we attach a Fixes to commit 64fe24a3e05e only for easy tracking, as
>>> this patch won't apply to a tree before that point. However the commit
>>> wasn't the source of problem, it's just that then anonymous memory will
>>> also suffer from this problem with mprotect().
>>
>> I'd remove that paragraph and also add
>>
>> Fixes: 64e455079e1b ("mm: softdirty: enable write notifications on VMAs after VM_SOFTDIRTY cleared")
>>
>> That introduced this wrong check for pagecache pages AFAIKS.
>>
>> We don't care if the patch applies before 64fe24a3e05e, if someone wants to
>> backport the fix, they can just adjust it accordingly.
>
> IMO besides marking the culprit commit, Fixes can also provide input to
> stable trees to see whether we should try pick some patch up. What I
> wanted to express here is we don't need to try pick this patch up before
> kernel that doesn't have 64fe24a3e05e because it won't apply.
>
> I can attach both Fixes with the hope that it'll help in both cases if
> you're fine with it, with slight explanations.
Makes sense. Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-07-22 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 18:33 [PATCH v3 0/3] mm/mprotect: Fix soft-dirty checks Peter Xu
2022-07-21 18:33 ` [PATCH v3 1/3] mm/mprotect: Fix soft-dirty check in can_change_pte_writable() Peter Xu
2022-07-22 7:08 ` David Hildenbrand
2022-07-22 13:51 ` Peter Xu
2022-07-22 13:59 ` David Hildenbrand [this message]
2022-07-22 17:21 ` Nadav Amit
2022-07-25 13:59 ` Peter Xu
2022-07-25 14:11 ` David Hildenbrand
2022-07-21 18:33 ` [PATCH v3 2/3] selftests: soft-dirty: Add test for mprotect Peter Xu
2022-07-22 7:17 ` David Hildenbrand
2022-07-22 13:44 ` Peter Xu
2022-07-22 14:00 ` David Hildenbrand
2022-07-22 14:07 ` David Hildenbrand
2022-07-22 14:37 ` Peter Xu
2022-07-21 18:33 ` [PATCH v3 3/3] selftests: Add soft-dirty into run_vmtests.sh Peter Xu
2022-07-22 7:18 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a85537d0-d828-2049-6f8e-3272156ae1ed@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nadav.amit@gmail.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).