* [PATCH] dt-bindings: display: imx: fix native-mode setting
@ 2019-09-18 19:38 Martin Kaiser
2019-10-01 22:09 ` Rob Herring
2019-10-05 13:09 ` [PATCH v2 0/2] dt-bindings: display: " Martin Kaiser
0 siblings, 2 replies; 7+ messages in thread
From: Martin Kaiser @ 2019-09-18 19:38 UTC (permalink / raw)
To: Shawn Guo, Bartlomiej Zolnierkiewicz, Rob Herring,
Pengutronix Kernel Team, NXP Linux Team
Cc: devicetree, linux-kernel, Martin Kaiser
According to
Documentation/devicetree/bindings/display/panel/display-timing.txt,
native-mode is a property of the display-timings node.
If it's located outside of display-timings, the native-mode setting is
ignored and the first display timing is used.
We've already fixed the board definitions which got this wrong. Fix the
example in the imx framebuffer bindings as well.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
index e5a8b363d829..f4df9e83bcd2 100644
--- a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
+++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
@@ -38,10 +38,10 @@ Example:
display0: display0 {
model = "Primeview-PD050VL1";
- native-mode = <&timing_disp0>;
bits-per-pixel = <16>;
fsl,pcr = <0xf0c88080>; /* non-standard but required */
display-timings {
+ native-mode = <&timing_disp0>;
timing_disp0: 640x480 {
hactive = <640>;
vactive = <480>;
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] dt-bindings: display: imx: fix native-mode setting
2019-09-18 19:38 [PATCH] dt-bindings: display: imx: fix native-mode setting Martin Kaiser
@ 2019-10-01 22:09 ` Rob Herring
2019-10-05 13:09 ` [PATCH v2 0/2] dt-bindings: display: " Martin Kaiser
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2019-10-01 22:09 UTC (permalink / raw)
To: Martin Kaiser
Cc: Shawn Guo, Bartlomiej Zolnierkiewicz, Pengutronix Kernel Team,
NXP Linux Team, devicetree, linux-kernel
On Wed, Sep 18, 2019 at 09:38:53PM +0200, Martin Kaiser wrote:
> According to
> Documentation/devicetree/bindings/display/panel/display-timing.txt,
> native-mode is a property of the display-timings node.
>
> If it's located outside of display-timings, the native-mode setting is
> ignored and the first display timing is used.
>
> We've already fixed the board definitions which got this wrong. Fix the
> example in the imx framebuffer bindings as well.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please also fix
Documentation/devicetree/bindings/display/cirrus,clps711x-fb.txt
>
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> index e5a8b363d829..f4df9e83bcd2 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
> @@ -38,10 +38,10 @@ Example:
>
> display0: display0 {
> model = "Primeview-PD050VL1";
> - native-mode = <&timing_disp0>;
> bits-per-pixel = <16>;
> fsl,pcr = <0xf0c88080>; /* non-standard but required */
> display-timings {
> + native-mode = <&timing_disp0>;
> timing_disp0: 640x480 {
> hactive = <640>;
> vactive = <480>;
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 0/2] dt-bindings: display: fix native-mode setting
2019-09-18 19:38 [PATCH] dt-bindings: display: imx: fix native-mode setting Martin Kaiser
2019-10-01 22:09 ` Rob Herring
@ 2019-10-05 13:09 ` Martin Kaiser
2019-10-05 13:09 ` [PATCH v2 1/2] dt-bindings: display: imx: " Martin Kaiser
2019-10-05 13:09 ` [PATCH v2 2/2] dt-bindings: display: clps711x-fb: " Martin Kaiser
1 sibling, 2 replies; 7+ messages in thread
From: Martin Kaiser @ 2019-10-05 13:09 UTC (permalink / raw)
To: Shawn Guo, Bartlomiej Zolnierkiewicz, Rob Herring,
Pengutronix Kernel Team, NXP Linux Team, Alexander Shiyan
Cc: devicetree, linux-kernel, Martin Kaiser
According to
Documentation/devicetree/bindings/display/panel/display-timing.txt,
native-mode is a property of the display-timings node.
If it's located outside of display-timings, the native-mode setting is
ignored and the first display timing is used.
We've already fixed the board definitions which got this wrong. Fix the
examples in the device tree bindings as well.
Martin Kaiser (2):
dt-bindings: display: imx: fix native-mode setting
dt-bindings: display: clps711x-fb: fix native-mode setting
Documentation/devicetree/bindings/display/cirrus,clps711x-fb.txt | 2 +-
Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] dt-bindings: display: imx: fix native-mode setting
2019-10-05 13:09 ` [PATCH v2 0/2] dt-bindings: display: " Martin Kaiser
@ 2019-10-05 13:09 ` Martin Kaiser
2019-10-11 15:30 ` Rob Herring
2019-10-05 13:09 ` [PATCH v2 2/2] dt-bindings: display: clps711x-fb: " Martin Kaiser
1 sibling, 1 reply; 7+ messages in thread
From: Martin Kaiser @ 2019-10-05 13:09 UTC (permalink / raw)
To: Shawn Guo, Bartlomiej Zolnierkiewicz, Rob Herring,
Pengutronix Kernel Team, NXP Linux Team, Alexander Shiyan
Cc: devicetree, linux-kernel, Martin Kaiser
Move the native-mode setting inside the display-timing node. Outside of
display-timing, it is ignored.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v2
move parts of the commit message into the cover letter
Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
index e5a8b363d829..f4df9e83bcd2 100644
--- a/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
+++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt
@@ -38,10 +38,10 @@ Example:
display0: display0 {
model = "Primeview-PD050VL1";
- native-mode = <&timing_disp0>;
bits-per-pixel = <16>;
fsl,pcr = <0xf0c88080>; /* non-standard but required */
display-timings {
+ native-mode = <&timing_disp0>;
timing_disp0: 640x480 {
hactive = <640>;
vactive = <480>;
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: display: imx: fix native-mode setting
2019-10-05 13:09 ` [PATCH v2 1/2] dt-bindings: display: imx: " Martin Kaiser
@ 2019-10-11 15:30 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2019-10-11 15:30 UTC (permalink / raw)
To: Martin Kaiser
Cc: Shawn Guo, Bartlomiej Zolnierkiewicz, Pengutronix Kernel Team,
NXP Linux Team, Alexander Shiyan, devicetree, linux-kernel,
Martin Kaiser
On Sat, 5 Oct 2019 15:09:20 +0200, Martin Kaiser wrote:
> Move the native-mode setting inside the display-timing node. Outside of
> display-timing, it is ignored.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> changes in v2
> move parts of the commit message into the cover letter
>
> Documentation/devicetree/bindings/display/imx/fsl,imx-fb.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] dt-bindings: display: clps711x-fb: fix native-mode setting
2019-10-05 13:09 ` [PATCH v2 0/2] dt-bindings: display: " Martin Kaiser
2019-10-05 13:09 ` [PATCH v2 1/2] dt-bindings: display: imx: " Martin Kaiser
@ 2019-10-05 13:09 ` Martin Kaiser
2019-10-11 15:30 ` Rob Herring
1 sibling, 1 reply; 7+ messages in thread
From: Martin Kaiser @ 2019-10-05 13:09 UTC (permalink / raw)
To: Shawn Guo, Bartlomiej Zolnierkiewicz, Rob Herring,
Pengutronix Kernel Team, NXP Linux Team, Alexander Shiyan
Cc: devicetree, linux-kernel, Martin Kaiser
Move the native-mode setting inside the display-timing node. Outside of
display-timing, it is ignored.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
changes in v2
fix the example in this binding as well
Documentation/devicetree/bindings/display/cirrus,clps711x-fb.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/cirrus,clps711x-fb.txt b/Documentation/devicetree/bindings/display/cirrus,clps711x-fb.txt
index b0e506610400..0ab5f0663611 100644
--- a/Documentation/devicetree/bindings/display/cirrus,clps711x-fb.txt
+++ b/Documentation/devicetree/bindings/display/cirrus,clps711x-fb.txt
@@ -27,11 +27,11 @@ Example:
display: display {
model = "320x240x4";
- native-mode = <&timing0>;
bits-per-pixel = <4>;
ac-prescale = <17>;
display-timings {
+ native-mode = <&timing0>;
timing0: 320x240 {
hactive = <320>;
hback-porch = <0>;
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 2/2] dt-bindings: display: clps711x-fb: fix native-mode setting
2019-10-05 13:09 ` [PATCH v2 2/2] dt-bindings: display: clps711x-fb: " Martin Kaiser
@ 2019-10-11 15:30 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2019-10-11 15:30 UTC (permalink / raw)
To: Martin Kaiser
Cc: Shawn Guo, Bartlomiej Zolnierkiewicz, Pengutronix Kernel Team,
NXP Linux Team, Alexander Shiyan, devicetree, linux-kernel,
Martin Kaiser
On Sat, 5 Oct 2019 15:09:21 +0200, Martin Kaiser wrote:
> Move the native-mode setting inside the display-timing node. Outside of
> display-timing, it is ignored.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> changes in v2
> fix the example in this binding as well
>
> Documentation/devicetree/bindings/display/cirrus,clps711x-fb.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-11 15:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-18 19:38 [PATCH] dt-bindings: display: imx: fix native-mode setting Martin Kaiser
2019-10-01 22:09 ` Rob Herring
2019-10-05 13:09 ` [PATCH v2 0/2] dt-bindings: display: " Martin Kaiser
2019-10-05 13:09 ` [PATCH v2 1/2] dt-bindings: display: imx: " Martin Kaiser
2019-10-11 15:30 ` Rob Herring
2019-10-05 13:09 ` [PATCH v2 2/2] dt-bindings: display: clps711x-fb: " Martin Kaiser
2019-10-11 15:30 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).