From: Tony Jones <tonyj@suse.de>
To: Andi Kleen <ak@linux.intel.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c
Date: Mon, 24 Apr 2017 08:45:48 -0700 [thread overview]
Message-ID: <5e91ca3e-248a-0882-094d-60c37446483b@suse.de> (raw)
In-Reply-To: <20170424130547.GS4021@tassilo.jf.intel.com>
On 04/24/2017 06:05 AM, Andi Kleen wrote:
> On Sun, Apr 23, 2017 at 09:26:32PM -0700, Tony Jones wrote:
>> Guard _GNU_SOURCE (as done in pt-decoder/intel-pt-decoder.c) to prevent
>> possible redefinition error.
>
> Who defines it?
>
> If it's always defined somewhere else it can be just removed.
>
> -Andi
sometimes it's defaulted on (I believe) by the toolchain. it fails on our SLE12-SP3 toolchain.
I assumed the existing guard in pt-decoder/intel-pt-decoder.c (only other use) was for a reason.
tony
prev parent reply other threads:[~2017-04-24 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 4:26 [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c Tony Jones
2017-04-24 4:26 ` [PATCH 2/2] perf tools: Add NULL end elements to 'unit_to_pmu' map Tony Jones
2017-04-24 13:05 ` [PATCH 1/2] perf tools: Guard _GNU_SOURCE in pmu-events/jevents.c Andi Kleen
2017-04-24 15:45 ` Tony Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e91ca3e-248a-0882-094d-60c37446483b@suse.de \
--to=tonyj@suse.de \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).