linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86/mm: fix "cpu" set but not used
@ 2019-02-28 22:01 Qian Cai
  2019-02-28 23:43 ` Andy Lutomirski
  2019-03-06 22:33 ` [tip:x86/urgent] x86/mm: Remove unused variable 'cpu' tip-bot for Qian Cai
  0 siblings, 2 replies; 4+ messages in thread
From: Qian Cai @ 2019-02-28 22:01 UTC (permalink / raw)
  To: dave.hansen, luto, peterz
  Cc: tglx, mingo, bp, hpa, x86, linux-kernel, Qian Cai

The commit a2055abe9c67 ("x86/mm: Pass flush_tlb_info to
flush_tlb_others() etc") removed the unnecessary cpu parameter from
uv_flush_tlb_others() but left an unused variable.

arch/x86/mm/tlb.c: In function 'native_flush_tlb_others':
arch/x86/mm/tlb.c:688:16: warning: variable 'cpu' set but not used
[-Wunused-but-set-variable]
   unsigned int cpu;
                ^~~

Signed-off-by: Qian Cai <cai@lca.pw>
---
 arch/x86/mm/tlb.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 999d6d8f0bef..bc4bc7b2f075 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -685,9 +685,6 @@ void native_flush_tlb_others(const struct cpumask *cpumask,
 		 * that UV should be updated so that smp_call_function_many(),
 		 * etc, are optimal on UV.
 		 */
-		unsigned int cpu;
-
-		cpu = smp_processor_id();
 		cpumask = uv_flush_tlb_others(cpumask, info);
 		if (cpumask)
 			smp_call_function_many(cpumask, flush_tlb_func_remote,
-- 
2.17.2 (Apple Git-113)


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] x86/mm: fix "cpu" set but not used
  2019-02-28 22:01 [PATCH] x86/mm: fix "cpu" set but not used Qian Cai
@ 2019-02-28 23:43 ` Andy Lutomirski
  2019-03-06 22:33 ` [tip:x86/urgent] x86/mm: Remove unused variable 'cpu' tip-bot for Qian Cai
  1 sibling, 0 replies; 4+ messages in thread
From: Andy Lutomirski @ 2019-02-28 23:43 UTC (permalink / raw)
  To: Qian Cai
  Cc: Dave Hansen, Andrew Lutomirski, Peter Zijlstra, Thomas Gleixner,
	Ingo Molnar, Borislav Petkov, H. Peter Anvin, X86 ML, LKML

On Thu, Feb 28, 2019 at 2:02 PM Qian Cai <cai@lca.pw> wrote:
>
> The commit a2055abe9c67 ("x86/mm: Pass flush_tlb_info to
> flush_tlb_others() etc") removed the unnecessary cpu parameter from
> uv_flush_tlb_others() but left an unused variable.
>
> arch/x86/mm/tlb.c: In function 'native_flush_tlb_others':
> arch/x86/mm/tlb.c:688:16: warning: variable 'cpu' set but not used
> [-Wunused-but-set-variable]
>    unsigned int cpu;
>                 ^~~
>

Acked-by: Andyt Lutomirski <luto@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip:x86/urgent] x86/mm: Remove unused variable 'cpu'
  2019-02-28 22:01 [PATCH] x86/mm: fix "cpu" set but not used Qian Cai
  2019-02-28 23:43 ` Andy Lutomirski
@ 2019-03-06 22:33 ` tip-bot for Qian Cai
  2019-03-07  0:56   ` Zhangshaokun
  1 sibling, 1 reply; 4+ messages in thread
From: tip-bot for Qian Cai @ 2019-03-06 22:33 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: luto, linux-kernel, tglx, mingo, hpa, cai

Commit-ID:  3609e31bc8dc03b701390f79c74fc7fe92b95039
Gitweb:     https://git.kernel.org/tip/3609e31bc8dc03b701390f79c74fc7fe92b95039
Author:     Qian Cai <cai@lca.pw>
AuthorDate: Thu, 28 Feb 2019 17:01:55 -0500
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 6 Mar 2019 23:24:52 +0100

x86/mm: Remove unused variable 'cpu'

The commit a2055abe9c67 ("x86/mm: Pass flush_tlb_info to
flush_tlb_others() etc") removed the unnecessary cpu parameter from
uv_flush_tlb_others() but left an unused variable.

arch/x86/mm/tlb.c: In function 'native_flush_tlb_others':
arch/x86/mm/tlb.c:688:16: warning: variable 'cpu' set but not used
[-Wunused-but-set-variable]
   unsigned int cpu;
                ^~~

Fixes: a2055abe9c67 ("x86/mm: Pass flush_tlb_info to flush_tlb_others() etc")
Signed-off-by: Qian Cai <cai@lca.pw>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Andyt Lutomirski <luto@kernel.org>
Cc: dave.hansen@linux.intel.com
Cc: peterz@infradead.org
Cc: bp@alien8.de
Cc: hpa@zytor.com
Link: https://lkml.kernel.org/r/20190228220155.88124-1-cai@lca.pw

---
 arch/x86/mm/tlb.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 999d6d8f0bef..bc4bc7b2f075 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -685,9 +685,6 @@ void native_flush_tlb_others(const struct cpumask *cpumask,
 		 * that UV should be updated so that smp_call_function_many(),
 		 * etc, are optimal on UV.
 		 */
-		unsigned int cpu;
-
-		cpu = smp_processor_id();
 		cpumask = uv_flush_tlb_others(cpumask, info);
 		if (cpumask)
 			smp_call_function_many(cpumask, flush_tlb_func_remote,

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [tip:x86/urgent] x86/mm: Remove unused variable 'cpu'
  2019-03-06 22:33 ` [tip:x86/urgent] x86/mm: Remove unused variable 'cpu' tip-bot for Qian Cai
@ 2019-03-07  0:56   ` Zhangshaokun
  0 siblings, 0 replies; 4+ messages in thread
From: Zhangshaokun @ 2019-03-07  0:56 UTC (permalink / raw)
  To: hpa, linux-kernel, cai, luto, tglx, mingo, linux-tip-commits,
	Borislav Petkov

A little confused,
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/cleanups&id=691b9ab6c9676e5868a4787be9041dd990005311

On 2019/3/7 6:33, tip-bot for Qian Cai wrote:
> Commit-ID:  3609e31bc8dc03b701390f79c74fc7fe92b95039
> Gitweb:     https://git.kernel.org/tip/3609e31bc8dc03b701390f79c74fc7fe92b95039
> Author:     Qian Cai <cai@lca.pw>
> AuthorDate: Thu, 28 Feb 2019 17:01:55 -0500
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 6 Mar 2019 23:24:52 +0100
> 
> x86/mm: Remove unused variable 'cpu'
> 
> The commit a2055abe9c67 ("x86/mm: Pass flush_tlb_info to
> flush_tlb_others() etc") removed the unnecessary cpu parameter from
> uv_flush_tlb_others() but left an unused variable.
> 
> arch/x86/mm/tlb.c: In function 'native_flush_tlb_others':
> arch/x86/mm/tlb.c:688:16: warning: variable 'cpu' set but not used
> [-Wunused-but-set-variable]
>    unsigned int cpu;
>                 ^~~
> 
> Fixes: a2055abe9c67 ("x86/mm: Pass flush_tlb_info to flush_tlb_others() etc")
> Signed-off-by: Qian Cai <cai@lca.pw>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Acked-by: Andyt Lutomirski <luto@kernel.org>
> Cc: dave.hansen@linux.intel.com
> Cc: peterz@infradead.org
> Cc: bp@alien8.de
> Cc: hpa@zytor.com
> Link: https://lkml.kernel.org/r/20190228220155.88124-1-cai@lca.pw
> 
> ---
>  arch/x86/mm/tlb.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 999d6d8f0bef..bc4bc7b2f075 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c
> @@ -685,9 +685,6 @@ void native_flush_tlb_others(const struct cpumask *cpumask,
>  		 * that UV should be updated so that smp_call_function_many(),
>  		 * etc, are optimal on UV.
>  		 */
> -		unsigned int cpu;
> -
> -		cpu = smp_processor_id();
>  		cpumask = uv_flush_tlb_others(cpumask, info);
>  		if (cpumask)
>  			smp_call_function_many(cpumask, flush_tlb_func_remote,
> 
> .
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-07  0:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-28 22:01 [PATCH] x86/mm: fix "cpu" set but not used Qian Cai
2019-02-28 23:43 ` Andy Lutomirski
2019-03-06 22:33 ` [tip:x86/urgent] x86/mm: Remove unused variable 'cpu' tip-bot for Qian Cai
2019-03-07  0:56   ` Zhangshaokun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).