* [PATCH v2 1/9] clocksource: sp804: cleanup clk_get_sys()
2020-09-12 11:45 [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
@ 2020-09-12 11:45 ` Zhen Lei
2020-09-12 11:45 ` [PATCH v2 2/9] clocksource: sp804: remove unused sp804_timer_disable() and timer-sp804.h Zhen Lei
` (8 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Zhen Lei @ 2020-09-12 11:45 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Zhen Lei, Libin, Kefeng Wang, Jianguo Chen
From: Kefeng Wang <wangkefeng.wang@huawei.com>
Move the clk_get_sys() part into sp804_get_clock_rate(), cleanup the same
code.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/clocksource/timer-sp804.c | 30 ++++++++++--------------------
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/drivers/clocksource/timer-sp804.c b/drivers/clocksource/timer-sp804.c
index 5cd0abf9b396..bec2d372e0df 100644
--- a/drivers/clocksource/timer-sp804.c
+++ b/drivers/clocksource/timer-sp804.c
@@ -22,11 +22,18 @@
#include "timer-sp.h"
-static long __init sp804_get_clock_rate(struct clk *clk)
+static long __init sp804_get_clock_rate(struct clk *clk, const char *name)
{
long rate;
int err;
+ if (!clk)
+ clk = clk_get_sys("sp804", name);
+ if (IS_ERR(clk)) {
+ pr_err("sp804: %s clock not found: %ld\n", name, PTR_ERR(clk));
+ return PTR_ERR(clk);
+ }
+
err = clk_prepare(clk);
if (err) {
pr_err("sp804: clock failed to prepare: %d\n", err);
@@ -72,16 +79,7 @@ int __init __sp804_clocksource_and_sched_clock_init(void __iomem *base,
{
long rate;
- if (!clk) {
- clk = clk_get_sys("sp804", name);
- if (IS_ERR(clk)) {
- pr_err("sp804: clock not found: %d\n",
- (int)PTR_ERR(clk));
- return PTR_ERR(clk);
- }
- }
-
- rate = sp804_get_clock_rate(clk);
+ rate = sp804_get_clock_rate(clk, name);
if (rate < 0)
return -EINVAL;
@@ -173,15 +171,7 @@ int __init __sp804_clockevents_init(void __iomem *base, unsigned int irq, struct
struct clock_event_device *evt = &sp804_clockevent;
long rate;
- if (!clk)
- clk = clk_get_sys("sp804", name);
- if (IS_ERR(clk)) {
- pr_err("sp804: %s clock not found: %d\n", name,
- (int)PTR_ERR(clk));
- return PTR_ERR(clk);
- }
-
- rate = sp804_get_clock_rate(clk);
+ rate = sp804_get_clock_rate(clk, name);
if (rate < 0)
return -EINVAL;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 2/9] clocksource: sp804: remove unused sp804_timer_disable() and timer-sp804.h
2020-09-12 11:45 [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
2020-09-12 11:45 ` [PATCH v2 1/9] clocksource: sp804: cleanup clk_get_sys() Zhen Lei
@ 2020-09-12 11:45 ` Zhen Lei
2020-09-12 11:45 ` [PATCH v2 3/9] clocksource: sp804: delete the leading "__" of some functions Zhen Lei
` (7 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Zhen Lei @ 2020-09-12 11:45 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Zhen Lei, Libin, Kefeng Wang, Jianguo Chen
Since commit 7484c727b636 ("ARM: realview: delete the RealView board
files") and commit 16956fed35fe ("ARM: versatile: switch to DT only
booting and remove legacy code"), there's no one to use the functions
defined or declared in include/clocksource/timer-sp804.h. Delete it.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/clocksource/timer-sp804.c | 7 -------
include/clocksource/timer-sp804.h | 29 -----------------------------
2 files changed, 36 deletions(-)
delete mode 100644 include/clocksource/timer-sp804.h
diff --git a/drivers/clocksource/timer-sp804.c b/drivers/clocksource/timer-sp804.c
index bec2d372e0df..97b41a493253 100644
--- a/drivers/clocksource/timer-sp804.c
+++ b/drivers/clocksource/timer-sp804.c
@@ -18,8 +18,6 @@
#include <linux/of_irq.h>
#include <linux/sched_clock.h>
-#include <clocksource/timer-sp804.h>
-
#include "timer-sp.h"
static long __init sp804_get_clock_rate(struct clk *clk, const char *name)
@@ -67,11 +65,6 @@ static u64 notrace sp804_read(void)
return ~readl_relaxed(sched_clock_base + TIMER_VALUE);
}
-void __init sp804_timer_disable(void __iomem *base)
-{
- writel(0, base + TIMER_CTRL);
-}
-
int __init __sp804_clocksource_and_sched_clock_init(void __iomem *base,
const char *name,
struct clk *clk,
diff --git a/include/clocksource/timer-sp804.h b/include/clocksource/timer-sp804.h
deleted file mode 100644
index a5b41f31a1c2..000000000000
--- a/include/clocksource/timer-sp804.h
+++ /dev/null
@@ -1,29 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __CLKSOURCE_TIMER_SP804_H
-#define __CLKSOURCE_TIMER_SP804_H
-
-struct clk;
-
-int __sp804_clocksource_and_sched_clock_init(void __iomem *,
- const char *, struct clk *, int);
-int __sp804_clockevents_init(void __iomem *, unsigned int,
- struct clk *, const char *);
-void sp804_timer_disable(void __iomem *);
-
-static inline void sp804_clocksource_init(void __iomem *base, const char *name)
-{
- __sp804_clocksource_and_sched_clock_init(base, name, NULL, 0);
-}
-
-static inline void sp804_clocksource_and_sched_clock_init(void __iomem *base,
- const char *name)
-{
- __sp804_clocksource_and_sched_clock_init(base, name, NULL, 1);
-}
-
-static inline void sp804_clockevents_init(void __iomem *base, unsigned int irq, const char *name)
-{
- __sp804_clockevents_init(base, irq, NULL, name);
-
-}
-#endif
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 3/9] clocksource: sp804: delete the leading "__" of some functions
2020-09-12 11:45 [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
2020-09-12 11:45 ` [PATCH v2 1/9] clocksource: sp804: cleanup clk_get_sys() Zhen Lei
2020-09-12 11:45 ` [PATCH v2 2/9] clocksource: sp804: remove unused sp804_timer_disable() and timer-sp804.h Zhen Lei
@ 2020-09-12 11:45 ` Zhen Lei
2020-09-12 11:45 ` [PATCH v2 4/9] clocksource: sp804: remove a mismatched comment Zhen Lei
` (6 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Zhen Lei @ 2020-09-12 11:45 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Zhen Lei, Libin, Kefeng Wang, Jianguo Chen
Delete the leading "__" of __sp804_clocksource_and_sched_clock_init() and
__sp804_clockevents_init(), make it looks a little more comfortable.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/clocksource/timer-sp804.c | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/clocksource/timer-sp804.c b/drivers/clocksource/timer-sp804.c
index 97b41a493253..097f5a83163c 100644
--- a/drivers/clocksource/timer-sp804.c
+++ b/drivers/clocksource/timer-sp804.c
@@ -65,10 +65,10 @@ static u64 notrace sp804_read(void)
return ~readl_relaxed(sched_clock_base + TIMER_VALUE);
}
-int __init __sp804_clocksource_and_sched_clock_init(void __iomem *base,
- const char *name,
- struct clk *clk,
- int use_sched_clock)
+int __init sp804_clocksource_and_sched_clock_init(void __iomem *base,
+ const char *name,
+ struct clk *clk,
+ int use_sched_clock)
{
long rate;
@@ -159,7 +159,8 @@ static struct clock_event_device sp804_clockevent = {
.rating = 300,
};
-int __init __sp804_clockevents_init(void __iomem *base, unsigned int irq, struct clk *clk, const char *name)
+int __init sp804_clockevents_init(void __iomem *base, unsigned int irq,
+ struct clk *clk, const char *name)
{
struct clock_event_device *evt = &sp804_clockevent;
long rate;
@@ -228,21 +229,22 @@ static int __init sp804_of_init(struct device_node *np)
of_property_read_u32(np, "arm,sp804-has-irq", &irq_num);
if (irq_num == 2) {
- ret = __sp804_clockevents_init(base + TIMER_2_BASE, irq, clk2, name);
+ ret = sp804_clockevents_init(base + TIMER_2_BASE, irq, clk2, name);
if (ret)
goto err;
- ret = __sp804_clocksource_and_sched_clock_init(base, name, clk1, 1);
+ ret = sp804_clocksource_and_sched_clock_init(base,
+ name, clk1, 1);
if (ret)
goto err;
} else {
- ret = __sp804_clockevents_init(base, irq, clk1 , name);
+ ret = sp804_clockevents_init(base, irq, clk1, name);
if (ret)
goto err;
- ret =__sp804_clocksource_and_sched_clock_init(base + TIMER_2_BASE,
- name, clk2, 1);
+ ret = sp804_clocksource_and_sched_clock_init(base + TIMER_2_BASE,
+ name, clk2, 1);
if (ret)
goto err;
}
@@ -282,7 +284,8 @@ static int __init integrator_cp_of_init(struct device_node *np)
goto err;
if (!init_count) {
- ret = __sp804_clocksource_and_sched_clock_init(base, name, clk, 0);
+ ret = sp804_clocksource_and_sched_clock_init(base,
+ name, clk, 0);
if (ret)
goto err;
} else {
@@ -290,7 +293,7 @@ static int __init integrator_cp_of_init(struct device_node *np)
if (irq <= 0)
goto err;
- ret = __sp804_clockevents_init(base, irq, clk, name);
+ ret = sp804_clockevents_init(base, irq, clk, name);
if (ret)
goto err;
}
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 4/9] clocksource: sp804: remove a mismatched comment
2020-09-12 11:45 [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
` (2 preceding siblings ...)
2020-09-12 11:45 ` [PATCH v2 3/9] clocksource: sp804: delete the leading "__" of some functions Zhen Lei
@ 2020-09-12 11:45 ` Zhen Lei
2020-09-12 11:45 ` [PATCH v2 5/9] clocksource: sp804: prepare for support non-standard register offset Zhen Lei
` (5 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Zhen Lei @ 2020-09-12 11:45 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Zhen Lei, Libin, Kefeng Wang, Jianguo Chen
writel(0, base + TIMER_CTRL);
... ...
writel(xxx | TIMER_CTRL_PERIODIC, base + TIMER_CTRL);
The timer is just temporarily disabled, and it will be set to periodic
mode later.
The description of the field TimerMode of the register TimerXControl
as shown below:
0 = Timer module is in free-running mode (default)
1 = Timer module is in periodic mode.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/clocksource/timer-sp804.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clocksource/timer-sp804.c b/drivers/clocksource/timer-sp804.c
index 097f5a83163c..a443f392a8e7 100644
--- a/drivers/clocksource/timer-sp804.c
+++ b/drivers/clocksource/timer-sp804.c
@@ -76,7 +76,6 @@ int __init sp804_clocksource_and_sched_clock_init(void __iomem *base,
if (rate < 0)
return -EINVAL;
- /* setup timer 0 as free-running clocksource */
writel(0, base + TIMER_CTRL);
writel(0xffffffff, base + TIMER_LOAD);
writel(0xffffffff, base + TIMER_VALUE);
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 5/9] clocksource: sp804: prepare for support non-standard register offset
2020-09-12 11:45 [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
` (3 preceding siblings ...)
2020-09-12 11:45 ` [PATCH v2 4/9] clocksource: sp804: remove a mismatched comment Zhen Lei
@ 2020-09-12 11:45 ` Zhen Lei
2020-09-12 11:45 ` [PATCH v2 6/9] clocksource: sp804: " Zhen Lei
` (4 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Zhen Lei @ 2020-09-12 11:45 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Zhen Lei, Libin, Kefeng Wang, Jianguo Chen
Add two local variables: timer1_base and timer2_base in sp804_of_init(),
to avoid repeatedly calculate the base address of timer2, and make it
easier to recognize timer1. Hope to make the next patch looks more clear.
No functional change.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/clocksource/timer-sp804.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/clocksource/timer-sp804.c b/drivers/clocksource/timer-sp804.c
index a443f392a8e7..471c5c6aaf51 100644
--- a/drivers/clocksource/timer-sp804.c
+++ b/drivers/clocksource/timer-sp804.c
@@ -188,6 +188,8 @@ static int __init sp804_of_init(struct device_node *np)
{
static bool initialized = false;
void __iomem *base;
+ void __iomem *timer1_base;
+ void __iomem *timer2_base;
int irq, ret = -EINVAL;
u32 irq_num = 0;
struct clk *clk1, *clk2;
@@ -197,9 +199,12 @@ static int __init sp804_of_init(struct device_node *np)
if (!base)
return -ENXIO;
+ timer1_base = base;
+ timer2_base = base + TIMER_2_BASE;
+
/* Ensure timers are disabled */
- writel(0, base + TIMER_CTRL);
- writel(0, base + TIMER_2_BASE + TIMER_CTRL);
+ writel(0, timer1_base + TIMER_CTRL);
+ writel(0, timer2_base + TIMER_CTRL);
if (initialized || !of_device_is_available(np)) {
ret = -EINVAL;
@@ -228,21 +233,21 @@ static int __init sp804_of_init(struct device_node *np)
of_property_read_u32(np, "arm,sp804-has-irq", &irq_num);
if (irq_num == 2) {
- ret = sp804_clockevents_init(base + TIMER_2_BASE, irq, clk2, name);
+ ret = sp804_clockevents_init(timer2_base, irq, clk2, name);
if (ret)
goto err;
- ret = sp804_clocksource_and_sched_clock_init(base,
+ ret = sp804_clocksource_and_sched_clock_init(timer1_base,
name, clk1, 1);
if (ret)
goto err;
} else {
- ret = sp804_clockevents_init(base, irq, clk1, name);
+ ret = sp804_clockevents_init(timer1_base, irq, clk1, name);
if (ret)
goto err;
- ret = sp804_clocksource_and_sched_clock_init(base + TIMER_2_BASE,
+ ret = sp804_clocksource_and_sched_clock_init(timer2_base,
name, clk2, 1);
if (ret)
goto err;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 6/9] clocksource: sp804: support non-standard register offset
2020-09-12 11:45 [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
` (4 preceding siblings ...)
2020-09-12 11:45 ` [PATCH v2 5/9] clocksource: sp804: prepare for support non-standard register offset Zhen Lei
@ 2020-09-12 11:45 ` Zhen Lei
2020-09-12 11:45 ` [PATCH v2 7/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
` (3 subsequent siblings)
9 siblings, 0 replies; 14+ messages in thread
From: Zhen Lei @ 2020-09-12 11:45 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Zhen Lei, Libin, Kefeng Wang, Jianguo Chen
The ARM SP804 supports a maximum of 32-bit counter, but Hisilicon extends
it to 64-bit. That means, the registers: TimerXload, TimerXValue and
TimerXBGLoad are 64bits, all other registers are the same as those in the
SP804. The driver code can be completely reused except that the register
offset is different.
Currently, we get a timer register address by: add the constant register
offset to the timer base address. e.g. "base + TIMER_CTRL". It can not be
dynamically adjusted at run time.
So create a new structure "sp804_timer" to record the original registers
offset, and create a new structure "sp804_clkevt" to record the
calculated registers address. So the "base + TIMER_CTRL" is changed to
"clkevt->ctrl", this will faster than "base + timer->ctrl".
For example:
struct sp804_timer arm_sp804_timer = {
.ctrl = TIMER_CTRL,
};
struct sp804_clkevt clkevt;
clkevt.ctrl = base + arm_sp804_timer.ctrl.
- writel(0, base + TIMER_CTRL);
+ writel(0, clkevt->ctrl);
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/clocksource/timer-sp.h | 26 +++++++
drivers/clocksource/timer-sp804.c | 108 +++++++++++++++++++++++-------
2 files changed, 108 insertions(+), 26 deletions(-)
diff --git a/drivers/clocksource/timer-sp.h b/drivers/clocksource/timer-sp.h
index b2037eb94a41..1ab75cbed0e0 100644
--- a/drivers/clocksource/timer-sp.h
+++ b/drivers/clocksource/timer-sp.h
@@ -10,6 +10,7 @@
*
* Every SP804 contains two identical timers.
*/
+#define NR_TIMERS 2
#define TIMER_1_BASE 0x00
#define TIMER_2_BASE 0x20
@@ -29,3 +30,28 @@
#define TIMER_RIS 0x10 /* CVR ro */
#define TIMER_MIS 0x14 /* CVR ro */
#define TIMER_BGLOAD 0x18 /* CVR rw */
+
+struct sp804_timer {
+ int load;
+ int value;
+ int ctrl;
+ int intclr;
+ int ris;
+ int mis;
+ int bgload;
+ int timer_base[NR_TIMERS];
+ int width;
+};
+
+struct sp804_clkevt {
+ void __iomem *base;
+ void __iomem *load;
+ void __iomem *value;
+ void __iomem *ctrl;
+ void __iomem *intclr;
+ void __iomem *ris;
+ void __iomem *mis;
+ void __iomem *bgload;
+ unsigned long reload;
+ int width;
+};
diff --git a/drivers/clocksource/timer-sp804.c b/drivers/clocksource/timer-sp804.c
index 471c5c6aaf51..5f4f979a8ef2 100644
--- a/drivers/clocksource/timer-sp804.c
+++ b/drivers/clocksource/timer-sp804.c
@@ -20,6 +20,17 @@
#include "timer-sp.h"
+struct sp804_timer __initdata arm_sp804_timer = {
+ .load = TIMER_LOAD,
+ .value = TIMER_VALUE,
+ .ctrl = TIMER_CTRL,
+ .intclr = TIMER_INTCLR,
+ .timer_base = {TIMER_1_BASE, TIMER_2_BASE},
+ .width = 32,
+};
+
+static struct sp804_clkevt sp804_clkevt[NR_TIMERS];
+
static long __init sp804_get_clock_rate(struct clk *clk, const char *name)
{
long rate;
@@ -58,11 +69,26 @@ static long __init sp804_get_clock_rate(struct clk *clk, const char *name)
return rate;
}
-static void __iomem *sched_clock_base;
+static struct sp804_clkevt * __init sp804_clkevt_get(void __iomem *base)
+{
+ int i;
+
+ for (i = 0; i < NR_TIMERS; i++) {
+ if (sp804_clkevt[i].base == base)
+ return &sp804_clkevt[i];
+ }
+
+ /* It's impossible to reach here */
+ WARN_ON(1);
+
+ return NULL;
+}
+
+static struct sp804_clkevt *sched_clkevt;
static u64 notrace sp804_read(void)
{
- return ~readl_relaxed(sched_clock_base + TIMER_VALUE);
+ return ~readl_relaxed(sched_clkevt->value);
}
int __init sp804_clocksource_and_sched_clock_init(void __iomem *base,
@@ -71,22 +97,25 @@ int __init sp804_clocksource_and_sched_clock_init(void __iomem *base,
int use_sched_clock)
{
long rate;
+ struct sp804_clkevt *clkevt;
rate = sp804_get_clock_rate(clk, name);
if (rate < 0)
return -EINVAL;
- writel(0, base + TIMER_CTRL);
- writel(0xffffffff, base + TIMER_LOAD);
- writel(0xffffffff, base + TIMER_VALUE);
+ clkevt = sp804_clkevt_get(base);
+
+ writel(0, clkevt->ctrl);
+ writel(0xffffffff, clkevt->load);
+ writel(0xffffffff, clkevt->value);
writel(TIMER_CTRL_32BIT | TIMER_CTRL_ENABLE | TIMER_CTRL_PERIODIC,
- base + TIMER_CTRL);
+ clkevt->ctrl);
- clocksource_mmio_init(base + TIMER_VALUE, name,
+ clocksource_mmio_init(clkevt->value, name,
rate, 200, 32, clocksource_mmio_readl_down);
if (use_sched_clock) {
- sched_clock_base = base;
+ sched_clkevt = clkevt;
sched_clock_register(sp804_read, 32, rate);
}
@@ -94,8 +123,7 @@ int __init sp804_clocksource_and_sched_clock_init(void __iomem *base,
}
-static void __iomem *clkevt_base;
-static unsigned long clkevt_reload;
+static struct sp804_clkevt *common_clkevt;
/*
* IRQ handler for the timer
@@ -105,7 +133,7 @@ static irqreturn_t sp804_timer_interrupt(int irq, void *dev_id)
struct clock_event_device *evt = dev_id;
/* clear the interrupt */
- writel(1, clkevt_base + TIMER_INTCLR);
+ writel(1, common_clkevt->intclr);
evt->event_handler(evt);
@@ -114,7 +142,7 @@ static irqreturn_t sp804_timer_interrupt(int irq, void *dev_id)
static inline void timer_shutdown(struct clock_event_device *evt)
{
- writel(0, clkevt_base + TIMER_CTRL);
+ writel(0, common_clkevt->ctrl);
}
static int sp804_shutdown(struct clock_event_device *evt)
@@ -129,8 +157,8 @@ static int sp804_set_periodic(struct clock_event_device *evt)
TIMER_CTRL_PERIODIC | TIMER_CTRL_ENABLE;
timer_shutdown(evt);
- writel(clkevt_reload, clkevt_base + TIMER_LOAD);
- writel(ctrl, clkevt_base + TIMER_CTRL);
+ writel(common_clkevt->reload, common_clkevt->load);
+ writel(ctrl, common_clkevt->ctrl);
return 0;
}
@@ -140,8 +168,8 @@ static int sp804_set_next_event(unsigned long next,
unsigned long ctrl = TIMER_CTRL_32BIT | TIMER_CTRL_IE |
TIMER_CTRL_ONESHOT | TIMER_CTRL_ENABLE;
- writel(next, clkevt_base + TIMER_LOAD);
- writel(ctrl, clkevt_base + TIMER_CTRL);
+ writel(next, common_clkevt->load);
+ writel(ctrl, common_clkevt->ctrl);
return 0;
}
@@ -168,13 +196,13 @@ int __init sp804_clockevents_init(void __iomem *base, unsigned int irq,
if (rate < 0)
return -EINVAL;
- clkevt_base = base;
- clkevt_reload = DIV_ROUND_CLOSEST(rate, HZ);
+ common_clkevt = sp804_clkevt_get(base);
+ common_clkevt->reload = DIV_ROUND_CLOSEST(rate, HZ);
evt->name = name;
evt->irq = irq;
evt->cpumask = cpu_possible_mask;
- writel(0, base + TIMER_CTRL);
+ writel(0, common_clkevt->ctrl);
if (request_irq(irq, sp804_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
"timer", &sp804_clockevent))
@@ -184,7 +212,26 @@ int __init sp804_clockevents_init(void __iomem *base, unsigned int irq,
return 0;
}
-static int __init sp804_of_init(struct device_node *np)
+static void __init sp804_clkevt_init(struct sp804_timer *timer, void __iomem *base)
+{
+ int i;
+
+ for (i = 0; i < NR_TIMERS; i++) {
+ void __iomem *timer_base;
+ struct sp804_clkevt *clkevt;
+
+ timer_base = base + timer->timer_base[i];
+ clkevt = &sp804_clkevt[i];
+ clkevt->base = timer_base;
+ clkevt->load = timer_base + timer->load;
+ clkevt->value = timer_base + timer->value;
+ clkevt->ctrl = timer_base + timer->ctrl;
+ clkevt->intclr = timer_base + timer->intclr;
+ clkevt->width = timer->width;
+ }
+}
+
+static int __init sp804_of_init(struct device_node *np, struct sp804_timer *timer)
{
static bool initialized = false;
void __iomem *base;
@@ -199,12 +246,12 @@ static int __init sp804_of_init(struct device_node *np)
if (!base)
return -ENXIO;
- timer1_base = base;
- timer2_base = base + TIMER_2_BASE;
+ timer1_base = base + timer->timer_base[0];
+ timer2_base = base + timer->timer_base[1];
/* Ensure timers are disabled */
- writel(0, timer1_base + TIMER_CTRL);
- writel(0, timer2_base + TIMER_CTRL);
+ writel(0, timer1_base + timer->ctrl);
+ writel(0, timer2_base + timer->ctrl);
if (initialized || !of_device_is_available(np)) {
ret = -EINVAL;
@@ -230,6 +277,8 @@ static int __init sp804_of_init(struct device_node *np)
if (irq <= 0)
goto err;
+ sp804_clkevt_init(timer, base);
+
of_property_read_u32(np, "arm,sp804-has-irq", &irq_num);
if (irq_num == 2) {
@@ -259,7 +308,12 @@ static int __init sp804_of_init(struct device_node *np)
iounmap(base);
return ret;
}
-TIMER_OF_DECLARE(sp804, "arm,sp804", sp804_of_init);
+
+static int __init arm_sp804_of_init(struct device_node *np)
+{
+ return sp804_of_init(np, &arm_sp804_timer);
+}
+TIMER_OF_DECLARE(sp804, "arm,sp804", arm_sp804_of_init);
static int __init integrator_cp_of_init(struct device_node *np)
{
@@ -282,11 +336,13 @@ static int __init integrator_cp_of_init(struct device_node *np)
}
/* Ensure timer is disabled */
- writel(0, base + TIMER_CTRL);
+ writel(0, base + arm_sp804_timer.ctrl);
if (init_count == 2 || !of_device_is_available(np))
goto err;
+ sp804_clkevt_init(&arm_sp804_timer, base);
+
if (!init_count) {
ret = sp804_clocksource_and_sched_clock_init(base,
name, clk, 0);
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 7/9] clocksource: sp804: add support for Hisilicon sp804 timer
2020-09-12 11:45 [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
` (5 preceding siblings ...)
2020-09-12 11:45 ` [PATCH v2 6/9] clocksource: sp804: " Zhen Lei
@ 2020-09-12 11:45 ` Zhen Lei
2020-09-18 8:53 ` Daniel Lezcano
2020-09-12 11:45 ` [PATCH v2 8/9] clocksource: sp804: enable Hisilicon sp804 timer 64bit mode Zhen Lei
` (2 subsequent siblings)
9 siblings, 1 reply; 14+ messages in thread
From: Zhen Lei @ 2020-09-12 11:45 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Zhen Lei, Libin, Kefeng Wang, Jianguo Chen
The ARM SP804 supports a maximum of 32-bit counter, but Hisilicon extends
it to 64-bit. That means, the registers: TimerXload, TimerXValue and
TimerXBGLoad are 64bits, all other registers are the same as those in the
SP804. The driver code can be completely reused except that the register
offset is different.
Use compatible = "hisilicon,sp804" mark as Hisilicon sp804 timer.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/clocksource/timer-sp.h | 12 ++++++++++++
drivers/clocksource/timer-sp804.c | 15 +++++++++++++++
2 files changed, 27 insertions(+)
diff --git a/drivers/clocksource/timer-sp.h b/drivers/clocksource/timer-sp.h
index 1ab75cbed0e0..6ca8d82e8544 100644
--- a/drivers/clocksource/timer-sp.h
+++ b/drivers/clocksource/timer-sp.h
@@ -31,6 +31,18 @@
#define TIMER_MIS 0x14 /* CVR ro */
#define TIMER_BGLOAD 0x18 /* CVR rw */
+
+#define HISI_TIMER_1_BASE 0x00
+#define HISI_TIMER_2_BASE 0x40
+#define HISI_TIMER_LOAD 0x00
+#define HISI_TIMER_VALUE 0x08
+#define HISI_TIMER_CTRL 0x10
+#define HISI_TIMER_INTCLR 0x14
+#define HISI_TIMER_RIS 0x18
+#define HISI_TIMER_MIS 0x1c
+#define HISI_TIMER_BGLOAD 0x20
+
+
struct sp804_timer {
int load;
int value;
diff --git a/drivers/clocksource/timer-sp804.c b/drivers/clocksource/timer-sp804.c
index 5f4f979a8ef2..3049f558c49b 100644
--- a/drivers/clocksource/timer-sp804.c
+++ b/drivers/clocksource/timer-sp804.c
@@ -29,6 +29,15 @@ struct sp804_timer __initdata arm_sp804_timer = {
.width = 32,
};
+struct sp804_timer __initdata hisi_sp804_timer = {
+ .load = HISI_TIMER_LOAD,
+ .value = HISI_TIMER_VALUE,
+ .ctrl = HISI_TIMER_CTRL,
+ .intclr = HISI_TIMER_INTCLR,
+ .timer_base = {HISI_TIMER_1_BASE, HISI_TIMER_2_BASE},
+ .width = 64,
+};
+
static struct sp804_clkevt sp804_clkevt[NR_TIMERS];
static long __init sp804_get_clock_rate(struct clk *clk, const char *name)
@@ -315,6 +324,12 @@ static int __init arm_sp804_of_init(struct device_node *np)
}
TIMER_OF_DECLARE(sp804, "arm,sp804", arm_sp804_of_init);
+static int __init hisi_sp804_of_init(struct device_node *np)
+{
+ return sp804_of_init(np, &hisi_sp804_timer);
+}
+TIMER_OF_DECLARE(hisi_sp804, "hisilicon,sp804", hisi_sp804_of_init);
+
static int __init integrator_cp_of_init(struct device_node *np)
{
static int init_count = 0;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 7/9] clocksource: sp804: add support for Hisilicon sp804 timer
2020-09-12 11:45 ` [PATCH v2 7/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
@ 2020-09-18 8:53 ` Daniel Lezcano
2020-09-18 9:34 ` Leizhen (ThunderTown)
0 siblings, 1 reply; 14+ messages in thread
From: Daniel Lezcano @ 2020-09-18 8:53 UTC (permalink / raw)
To: Zhen Lei, Thomas Gleixner, linux-kernel; +Cc: Libin, Kefeng Wang, Jianguo Chen
On 12/09/2020 13:45, Zhen Lei wrote:
> The ARM SP804 supports a maximum of 32-bit counter, but Hisilicon extends
> it to 64-bit. That means, the registers: TimerXload, TimerXValue and
> TimerXBGLoad are 64bits, all other registers are the same as those in the
> SP804. The driver code can be completely reused except that the register
> offset is different.
>
> Use compatible = "hisilicon,sp804" mark as Hisilicon sp804 timer.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/clocksource/timer-sp.h | 12 ++++++++++++
> drivers/clocksource/timer-sp804.c | 15 +++++++++++++++
> 2 files changed, 27 insertions(+)
>
> diff --git a/drivers/clocksource/timer-sp.h b/drivers/clocksource/timer-sp.h
> index 1ab75cbed0e0..6ca8d82e8544 100644
> --- a/drivers/clocksource/timer-sp.h
> +++ b/drivers/clocksource/timer-sp.h
> @@ -31,6 +31,18 @@
> #define TIMER_MIS 0x14 /* CVR ro */
> #define TIMER_BGLOAD 0x18 /* CVR rw */
>
> +
> +#define HISI_TIMER_1_BASE 0x00
> +#define HISI_TIMER_2_BASE 0x40
> +#define HISI_TIMER_LOAD 0x00
> +#define HISI_TIMER_VALUE 0x08
> +#define HISI_TIMER_CTRL 0x10
> +#define HISI_TIMER_INTCLR 0x14
> +#define HISI_TIMER_RIS 0x18
> +#define HISI_TIMER_MIS 0x1c
> +#define HISI_TIMER_BGLOAD 0x20
Why not put them in timer-sp804.c directly ?
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 7/9] clocksource: sp804: add support for Hisilicon sp804 timer
2020-09-18 8:53 ` Daniel Lezcano
@ 2020-09-18 9:34 ` Leizhen (ThunderTown)
0 siblings, 0 replies; 14+ messages in thread
From: Leizhen (ThunderTown) @ 2020-09-18 9:34 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Libin, Kefeng Wang, Jianguo Chen
On 2020/9/18 16:53, Daniel Lezcano wrote:
> On 12/09/2020 13:45, Zhen Lei wrote:
>> The ARM SP804 supports a maximum of 32-bit counter, but Hisilicon extends
>> it to 64-bit. That means, the registers: TimerXload, TimerXValue and
>> TimerXBGLoad are 64bits, all other registers are the same as those in the
>> SP804. The driver code can be completely reused except that the register
>> offset is different.
>>
>> Use compatible = "hisilicon,sp804" mark as Hisilicon sp804 timer.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> drivers/clocksource/timer-sp.h | 12 ++++++++++++
>> drivers/clocksource/timer-sp804.c | 15 +++++++++++++++
>> 2 files changed, 27 insertions(+)
>>
>> diff --git a/drivers/clocksource/timer-sp.h b/drivers/clocksource/timer-sp.h
>> index 1ab75cbed0e0..6ca8d82e8544 100644
>> --- a/drivers/clocksource/timer-sp.h
>> +++ b/drivers/clocksource/timer-sp.h
>> @@ -31,6 +31,18 @@
>> #define TIMER_MIS 0x14 /* CVR ro */
>> #define TIMER_BGLOAD 0x18 /* CVR rw */
>>
>> +
>> +#define HISI_TIMER_1_BASE 0x00
>> +#define HISI_TIMER_2_BASE 0x40
>> +#define HISI_TIMER_LOAD 0x00
>> +#define HISI_TIMER_VALUE 0x08
>> +#define HISI_TIMER_CTRL 0x10
>> +#define HISI_TIMER_INTCLR 0x14
>> +#define HISI_TIMER_RIS 0x18
>> +#define HISI_TIMER_MIS 0x1c
>> +#define HISI_TIMER_BGLOAD 0x20
>
> Why not put them in timer-sp804.c directly ?
I just want to put them together with TIMER_xxx, but ignore that HISI_TIMER_xxx
is used only in file timer-sp804.c
OK, I will move them into timer-sp804.c
>
> [ ... ]
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 8/9] clocksource: sp804: enable Hisilicon sp804 timer 64bit mode
2020-09-12 11:45 [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
` (6 preceding siblings ...)
2020-09-12 11:45 ` [PATCH v2 7/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
@ 2020-09-12 11:45 ` Zhen Lei
2020-09-12 11:45 ` [PATCH v2 9/9] dt-bindings: sp804: add support for Hisilicon sp804 timer Zhen Lei
2020-09-15 1:27 ` [PATCH v2 0/9] clocksource: " Leizhen (ThunderTown)
9 siblings, 0 replies; 14+ messages in thread
From: Zhen Lei @ 2020-09-12 11:45 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Zhen Lei, Libin, Kefeng Wang, Jianguo Chen
A 100MHZ 32-bit timer will be wrapped up less than 43s. Although the
kernel maintains a software high 32-bit count in the tick IRQ. But it's
not applicable to the user mode APPs.
Note: The kernel still uses the lower 32 bits of the timer.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/clocksource/timer-sp.h | 9 +++++++++
drivers/clocksource/timer-sp804.c | 8 ++++++++
2 files changed, 17 insertions(+)
diff --git a/drivers/clocksource/timer-sp.h b/drivers/clocksource/timer-sp.h
index 6ca8d82e8544..6c0a902926eb 100644
--- a/drivers/clocksource/timer-sp.h
+++ b/drivers/clocksource/timer-sp.h
@@ -35,22 +35,28 @@
#define HISI_TIMER_1_BASE 0x00
#define HISI_TIMER_2_BASE 0x40
#define HISI_TIMER_LOAD 0x00
+#define HISI_TIMER_LOAD_H 0x04
#define HISI_TIMER_VALUE 0x08
+#define HISI_TIMER_VALUE_H 0x0c
#define HISI_TIMER_CTRL 0x10
#define HISI_TIMER_INTCLR 0x14
#define HISI_TIMER_RIS 0x18
#define HISI_TIMER_MIS 0x1c
#define HISI_TIMER_BGLOAD 0x20
+#define HISI_TIMER_BGLOAD_H 0x24
struct sp804_timer {
int load;
+ int load_h;
int value;
+ int value_h;
int ctrl;
int intclr;
int ris;
int mis;
int bgload;
+ int bgload_h;
int timer_base[NR_TIMERS];
int width;
};
@@ -58,12 +64,15 @@ struct sp804_timer {
struct sp804_clkevt {
void __iomem *base;
void __iomem *load;
+ void __iomem *load_h;
void __iomem *value;
+ void __iomem *value_h;
void __iomem *ctrl;
void __iomem *intclr;
void __iomem *ris;
void __iomem *mis;
void __iomem *bgload;
+ void __iomem *bgload_h;
unsigned long reload;
int width;
};
diff --git a/drivers/clocksource/timer-sp804.c b/drivers/clocksource/timer-sp804.c
index 3049f558c49b..8d16e7fa7a7a 100644
--- a/drivers/clocksource/timer-sp804.c
+++ b/drivers/clocksource/timer-sp804.c
@@ -31,7 +31,9 @@ struct sp804_timer __initdata arm_sp804_timer = {
struct sp804_timer __initdata hisi_sp804_timer = {
.load = HISI_TIMER_LOAD,
+ .load_h = HISI_TIMER_LOAD_H,
.value = HISI_TIMER_VALUE,
+ .value_h = HISI_TIMER_VALUE_H,
.ctrl = HISI_TIMER_CTRL,
.intclr = HISI_TIMER_INTCLR,
.timer_base = {HISI_TIMER_1_BASE, HISI_TIMER_2_BASE},
@@ -117,6 +119,10 @@ int __init sp804_clocksource_and_sched_clock_init(void __iomem *base,
writel(0, clkevt->ctrl);
writel(0xffffffff, clkevt->load);
writel(0xffffffff, clkevt->value);
+ if (clkevt->width == 64) {
+ writel(0xffffffff, clkevt->load_h);
+ writel(0xffffffff, clkevt->value_h);
+ }
writel(TIMER_CTRL_32BIT | TIMER_CTRL_ENABLE | TIMER_CTRL_PERIODIC,
clkevt->ctrl);
@@ -233,7 +239,9 @@ static void __init sp804_clkevt_init(struct sp804_timer *timer, void __iomem *ba
clkevt = &sp804_clkevt[i];
clkevt->base = timer_base;
clkevt->load = timer_base + timer->load;
+ clkevt->load_h = timer_base + timer->load_h;
clkevt->value = timer_base + timer->value;
+ clkevt->value_h = timer_base + timer->value_h;
clkevt->ctrl = timer_base + timer->ctrl;
clkevt->intclr = timer_base + timer->intclr;
clkevt->width = timer->width;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v2 9/9] dt-bindings: sp804: add support for Hisilicon sp804 timer
2020-09-12 11:45 [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
` (7 preceding siblings ...)
2020-09-12 11:45 ` [PATCH v2 8/9] clocksource: sp804: enable Hisilicon sp804 timer 64bit mode Zhen Lei
@ 2020-09-12 11:45 ` Zhen Lei
2020-09-15 1:27 ` [PATCH v2 0/9] clocksource: " Leizhen (ThunderTown)
9 siblings, 0 replies; 14+ messages in thread
From: Zhen Lei @ 2020-09-12 11:45 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Zhen Lei, Libin, Kefeng Wang, Jianguo Chen
Some Hisilicon SoCs, such as Hi1212, use the Hisilicon extended sp804
timer.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
Documentation/devicetree/bindings/timer/arm,sp804.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/timer/arm,sp804.txt b/Documentation/devicetree/bindings/timer/arm,sp804.txt
index 5cd8eee74af1..01a5451d33f2 100644
--- a/Documentation/devicetree/bindings/timer/arm,sp804.txt
+++ b/Documentation/devicetree/bindings/timer/arm,sp804.txt
@@ -3,6 +3,8 @@ ARM sp804 Dual Timers
Required properties:
- compatible: Should be "arm,sp804" & "arm,primecell"
+ or "hisilicon,sp804" & "arm,primecell" for some Hisilicon SoCs,
+ such as Hi1212.
- interrupts: Should contain the list of Dual Timer interrupts. This is the
interrupt for timer 1 and timer 2. In the case of a single entry, it is
the combined interrupt or if "arm,sp804-has-irq" is present that
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer
2020-09-12 11:45 [PATCH v2 0/9] clocksource: sp804: add support for Hisilicon sp804 timer Zhen Lei
` (8 preceding siblings ...)
2020-09-12 11:45 ` [PATCH v2 9/9] dt-bindings: sp804: add support for Hisilicon sp804 timer Zhen Lei
@ 2020-09-15 1:27 ` Leizhen (ThunderTown)
2020-09-17 12:34 ` Daniel Lezcano
9 siblings, 1 reply; 14+ messages in thread
From: Leizhen (ThunderTown) @ 2020-09-15 1:27 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, linux-kernel
Cc: Libin, Kefeng Wang, Jianguo Chen
Hi, Daniel Lezcano, Thomas Gleixner:
Do you have time to review these patches?
On 2020/9/12 19:45, Zhen Lei wrote:
> v1 --> v2:
> 1. Split the Patch 3 of v1 into three patches: Patch 3-5
> 2. Change compatible "hisi,sp804" to "hisilicon,sp804" in Patch 7.
> 3. Add dt-binding description of "hisilicon,sp804", Patch 9
>
> Other patches are not changed.
>
>
> v1:
> The ARM SP804 supports a maximum of 32-bit counter, but Hisilicon extends
> it to 64-bit. That means, the registers: TimerXload, TimerXValue and
> TimerXBGLoad are 64bits, all other registers are the same as those in the
> SP804. The driver code can be completely reused except that the register
> offset is different
>
> The register offset differences between ARM-SP804 and HISI-SP804 are as follows:
>
> ARM-SP804 HISI-SP804
> TIMER_LOAD 0x00 HISI_TIMER_LOAD 0x00
> HISI_TIMER_LOAD_H 0x04
> TIMER_VALUE 0x04 HISI_TIMER_VALUE 0x08
> HISI_TIMER_VALUE_H 0x0c
> TIMER_CTRL 0x08 HISI_TIMER_CTRL 0x10
> TIMER_INTCLR 0x0c HISI_TIMER_INTCLR 0x14
> TIMER_RIS 0x10 HISI_TIMER_RIS 0x18
> TIMER_MIS 0x14 HISI_TIMER_MIS 0x1c
> TIMER_BGLOAD 0x18 HISI_TIMER_BGLOAD 0x20
> HISI_TIMER_BGLOAD_H 0x24
> TIMER_2_BASE 0x20 HISI_TIMER_2_BASE 0x40
> ----------------
>
> In order to make the timer-sp804 driver support both ARM-SP804 and HISI-SP804.
> Create a new structure "sp804_clkevt" to record the calculated registers
> address in advance, avoid judging and calculating the register address every
> place that is used.
>
> For example:
> struct sp804_timer arm_sp804_timer = {
> .ctrl = TIMER_CTRL,
> };
>
> struct sp804_timer hisi_sp804_timer = {
> .ctrl = HISI_TIMER_CTRL,
> };
>
> struct sp804_clkevt clkevt;
>
> In the initialization phase:
> if (hisi_sp804)
> clkevt.ctrl = base + hisi_sp804_timer.ctrl;
> else if (arm_sp804)
> clkevt.ctrl = base + arm_sp804_timer.ctrl;
>
> After initialization:
> - writel(0, base + TIMER_CTRL);
> + writel(0, clkevt.ctrl);
> ----------------
>
> Additional information:
> These patch series are the V2 of https://lore.kernel.org/patchwork/cover/681876/
> And many of the main ideas in https://lore.kernel.org/patchwork/patch/681875/ have been considered.
> Thanks for Daniel Lezcano's review comments.
>
> Kefeng Wang (1):
> clocksource: sp804: cleanup clk_get_sys()
>
> Zhen Lei (8):
> clocksource: sp804: remove unused sp804_timer_disable() and
> timer-sp804.h
> clocksource: sp804: delete the leading "__" of some functions
> clocksource: sp804: remove a mismatched comment
> clocksource: sp804: prepare for support non-standard register offset
> clocksource: sp804: support non-standard register offset
> clocksource: sp804: add support for Hisilicon sp804 timer
> clocksource: sp804: enable Hisilicon sp804 timer 64bit mode
> dt-bindings: sp804: add support for Hisilicon sp804 timer
>
> .../devicetree/bindings/timer/arm,sp804.txt | 2 +
> drivers/clocksource/timer-sp.h | 47 +++++
> drivers/clocksource/timer-sp804.c | 195 ++++++++++++------
> include/clocksource/timer-sp804.h | 29 ---
> 4 files changed, 181 insertions(+), 92 deletions(-)
> delete mode 100644 include/clocksource/timer-sp804.h
>
^ permalink raw reply [flat|nested] 14+ messages in thread