linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>,
	Jeff Dike <jdike@addtoit.com>,
	Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: kernel@axis.com, devicetree@vger.kernel.org,
	linux-um@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] um: virtio_uml: allow probing from devicetree
Date: Tue, 21 Dec 2021 21:48:26 +0100	[thread overview]
Message-ID: <5f104044649ec60ba93648e68c3df2183e032072.camel@sipsolutions.net> (raw)
In-Reply-To: <20211221090447.1567-1-vincent.whitchurch@axis.com>

On Tue, 2021-12-21 at 10:04 +0100, Vincent Whitchurch wrote:
> Allow the virtio_uml device to be probed from the devicetree so that
> sub-devices can be specified using the standard virtio bindings, for
> example:
> 
>   virtio@1 {
>     compatible = "virtio,uml";
>     socket-path = "i2c.sock";
>     virtio-device-id = <0x22>;
> 

Given this, maybe it should modify
Documentation/devicetree/bindings/virtio/virtio-device.yaml? Or actually
add a new Documentation/devicetree/bindings/virtio/uml.yaml I guess?

+Rob, because I'm not really into any of this.

Also, I'm not even sure we should/need to document the DT bits that are
basically only used for testing in the first place?

Code looks good to me.

johannes

  reply	other threads:[~2021-12-21 20:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21  9:04 [PATCH] um: virtio_uml: allow probing from devicetree Vincent Whitchurch
2021-12-21 20:48 ` Johannes Berg [this message]
2021-12-22 10:34   ` Vincent Whitchurch
2021-12-22 11:11     ` Anton Ivanov
2021-12-22 19:41       ` Richard Weinberger
2022-01-04 10:44         ` [PATCH] um: Document dtb command line option anton.ivanov
2022-01-13 15:09           ` Vincent Whitchurch
2022-01-04 14:13     ` [PATCH] um: virtio_uml: allow probing from devicetree Anton Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f104044649ec60ba93648e68c3df2183e032072.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jdike@addtoit.com \
    --cc=kernel@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=vincent.whitchurch@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).