From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Rob Herring <robh+dt@kernel.org>, kernel <kernel@axis.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-um@lists.infradead.org" <linux-um@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] um: virtio_uml: allow probing from devicetree
Date: Tue, 4 Jan 2022 14:13:25 +0000 [thread overview]
Message-ID: <a862c00c-0db4-e2b7-4ee7-958f3bdd856e@cambridgegreys.com> (raw)
In-Reply-To: <20211222103417.GB25135@axis.com>
On 22/12/2021 10:34, Vincent Whitchurch wrote:
> On Tue, Dec 21, 2021 at 09:48:26PM +0100, Johannes Berg wrote:
>> On Tue, 2021-12-21 at 10:04 +0100, Vincent Whitchurch wrote:
>>> Allow the virtio_uml device to be probed from the devicetree so that
>>> sub-devices can be specified using the standard virtio bindings, for
>>> example:
>>>
>>> virtio@1 {
>>> compatible = "virtio,uml";
>>> socket-path = "i2c.sock";
>>> virtio-device-id = <0x22>;
>>>
>>
>> Given this, maybe it should modify
>> Documentation/devicetree/bindings/virtio/virtio-device.yaml? Or actually
>> add a new Documentation/devicetree/bindings/virtio/uml.yaml I guess?
>>
>> +Rob, because I'm not really into any of this.
>>
>> Also, I'm not even sure we should/need to document the DT bits that are
>> basically only used for testing in the first place?
If we start adding the UML devices themselves to the DT, we might as well add all of them.
In the doc patch have described the DT support as mostly for development at this point.
It can be a good alternative to the endless command line (especially for complex devices like f.e. l2tpv3).
>
> I wasn't sure either, but Rob was OK with not documenting some other
> bindings which are only used for testing[0], so I assumed that that
> applied here too:
>
> [0] https://lore.kernel.org/all/5baa1ae6.1c69fb81.847f2.3ab1@mx.google.com/
>
> Also, DT bindings are supposed to be generic and based on what the
> hardware has, but here we have no hardware and something very Linux and
> UML-specific.
>
>> Code looks good to me.
>
> Thanks!
>
Brgds,
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
prev parent reply other threads:[~2022-01-04 14:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 9:04 [PATCH] um: virtio_uml: allow probing from devicetree Vincent Whitchurch
2021-12-21 20:48 ` Johannes Berg
2021-12-22 10:34 ` Vincent Whitchurch
2021-12-22 11:11 ` Anton Ivanov
2021-12-22 19:41 ` Richard Weinberger
2022-01-04 10:44 ` [PATCH] um: Document dtb command line option anton.ivanov
2022-01-13 15:09 ` Vincent Whitchurch
2022-01-04 14:13 ` Anton Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a862c00c-0db4-e2b7-4ee7-958f3bdd856e@cambridgegreys.com \
--to=anton.ivanov@cambridgegreys.com \
--cc=devicetree@vger.kernel.org \
--cc=jdike@addtoit.com \
--cc=johannes@sipsolutions.net \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).