linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Question regarding the TODO in virt/kvm/kvm_main.c:226
@ 2021-05-25 11:45 Hamza Mahfooz
  2021-06-25  5:16 ` Hamza Mahfooz
  0 siblings, 1 reply; 3+ messages in thread
From: Hamza Mahfooz @ 2021-05-25 11:45 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: kvm, linux-kernel

Would it be preferable to remove kvm_arch_vcpu_should_kick or
kvm_request_needs_ipi when merging them. I ask since, the last time I
checked, both functions are only used in kvm_main.c on Linus's tree.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Question regarding the TODO in virt/kvm/kvm_main.c:226
  2021-05-25 11:45 Question regarding the TODO in virt/kvm/kvm_main.c:226 Hamza Mahfooz
@ 2021-06-25  5:16 ` Hamza Mahfooz
  2021-06-25 17:20   ` Paolo Bonzini
  0 siblings, 1 reply; 3+ messages in thread
From: Hamza Mahfooz @ 2021-06-25  5:16 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: kvm, linux-kernel

ping

On Tue, May 25 2021 at 07:45:53 AM -0400, Hamza Mahfooz 
<someguy@effective-light.com> wrote:
> Would it be preferable to remove kvm_arch_vcpu_should_kick or
> kvm_request_needs_ipi when merging them. I ask since, the last time I
> checked, both functions are only used in kvm_main.c on Linus's tree.
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Question regarding the TODO in virt/kvm/kvm_main.c:226
  2021-06-25  5:16 ` Hamza Mahfooz
@ 2021-06-25 17:20   ` Paolo Bonzini
  0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2021-06-25 17:20 UTC (permalink / raw)
  To: Hamza Mahfooz; +Cc: kvm, linux-kernel

On 25/06/21 07:16, Hamza Mahfooz wrote:
> ping
> 
> On Tue, May 25 2021 at 07:45:53 AM -0400, Hamza Mahfooz 
> <someguy@effective-light.com> wrote:
>> Would it be preferable to remove kvm_arch_vcpu_should_kick or
>> kvm_request_needs_ipi when merging them. I ask since, the last time I
>> checked, both functions are only used in kvm_main.c on Linus's tree.

I think none, the logic have changed enough that the TODO is obsolete.

Paolo


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-25 17:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 11:45 Question regarding the TODO in virt/kvm/kvm_main.c:226 Hamza Mahfooz
2021-06-25  5:16 ` Hamza Mahfooz
2021-06-25 17:20   ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).