* [PATCH 2/2] media: dvb-core: fix demux.h non-ASCII characters
@ 2017-08-28 23:10 Randy Dunlap
2017-08-30 21:24 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2017-08-28 23:10 UTC (permalink / raw)
To: LKML, linux-media, Mauro Carvalho Chehab; +Cc: Jonathan Corbet, linux-doc
From: Randy Dunlap <rdunlap@infradead.org>
Fix non-ASCII charactes in kernel-doc comment to prevent the kernel-doc
build warning below.
WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno ../drivers/media/dvb-core/demux.h' processing failed with: 'ascii' codec can't decode byte 0xe2 in position 6368: ordinal not in range(128)
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/media/dvb-core/demux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-413-rc7.orig/drivers/media/dvb-core/demux.h
+++ lnx-413-rc7/drivers/media/dvb-core/demux.h
@@ -210,7 +210,7 @@ struct dmx_section_feed {
* the start of the first undelivered TS packet within a circular buffer.
* The @buffer2 buffer parameter is normally NULL, except when the received
* TS packets have crossed the last address of the circular buffer and
- * ”wrapped” to the beginning of the buffer. In the latter case the @buffer1
+ * "wrapped" to the beginning of the buffer. In the latter case the @buffer1
* parameter would contain an address within the circular buffer, while the
* @buffer2 parameter would contain the first address of the circular buffer.
* The number of bytes delivered with this function (i.e. @buffer1_length +
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] media: dvb-core: fix demux.h non-ASCII characters
2017-08-28 23:10 [PATCH 2/2] media: dvb-core: fix demux.h non-ASCII characters Randy Dunlap
@ 2017-08-30 21:24 ` Jonathan Corbet
2017-08-30 22:17 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Corbet @ 2017-08-30 21:24 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, linux-media, Mauro Carvalho Chehab, linux-doc
On Mon, 28 Aug 2017 16:10:16 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> Fix non-ASCII charactes in kernel-doc comment to prevent the kernel-doc
> build warning below.
>
> WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno ../drivers/media/dvb-core/demux.h' processing failed with: 'ascii' codec can't decode byte 0xe2 in position 6368: ordinal not in range(128)
I'll leave this one for Mauro to decide on. My inclination would be to
apply it, though, my previous comments on handling non-ASCII text
notwithstanding. The weird quotes don't buy us anything here.
Thanks,
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] media: dvb-core: fix demux.h non-ASCII characters
2017-08-30 21:24 ` Jonathan Corbet
@ 2017-08-30 22:17 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2017-08-30 22:17 UTC (permalink / raw)
To: Jonathan Corbet; +Cc: Randy Dunlap, LKML, linux-media, linux-doc
Em Wed, 30 Aug 2017 15:24:30 -0600
Jonathan Corbet <corbet@lwn.net> escreveu:
> On Mon, 28 Aug 2017 16:10:16 -0700
> Randy Dunlap <rdunlap@infradead.org> wrote:
>
> > Fix non-ASCII charactes in kernel-doc comment to prevent the kernel-doc
> > build warning below.
> >
> > WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno ../drivers/media/dvb-core/demux.h' processing failed with: 'ascii' codec can't decode byte 0xe2 in position 6368: ordinal not in range(128)
>
> I'll leave this one for Mauro to decide on. My inclination would be to
> apply it, though, my previous comments on handling non-ASCII text
> notwithstanding. The weird quotes don't buy us anything here.
Yeah, it doesn't make sense to have this character there.
I'll apply it on my tree. Yet, I'm considering adding an UTF-8
character on a kernel-doc markup.
One DVB parameter is called "Rolloff", and its usual symbol is
the greek letter alpha. There, it would make sense to use a
non-ascII character.
By coincidence, I just wrote such patch earlier today.
Regards,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-30 22:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 23:10 [PATCH 2/2] media: dvb-core: fix demux.h non-ASCII characters Randy Dunlap
2017-08-30 21:24 ` Jonathan Corbet
2017-08-30 22:17 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).