* [PATCH] staging: rtl8723bs: remove temporary variable CrystalCap
@ 2020-02-23 15:14 Colin King
2020-02-24 5:25 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-02-23 15:14 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently variable CrystalCap is being initialized with the value
0x20 that is never read so that is redundant and can be removed.
Clean up the code by removing the need for variable CrystalCap
since the calculation of the return value is relatively simple.
Addresses-Coverity: ("Unused Value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
index 95edd148ac24..34d83b238265 100644
--- a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
+++ b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
@@ -40,16 +40,11 @@ static void odm_SetCrystalCap(void *pDM_VOID, u8 CrystalCap)
static u8 odm_GetDefaultCrytaltalCap(void *pDM_VOID)
{
PDM_ODM_T pDM_Odm = (PDM_ODM_T)pDM_VOID;
- u8 CrystalCap = 0x20;
struct adapter *Adapter = pDM_Odm->Adapter;
struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
- CrystalCap = pHalData->CrystalCap;
-
- CrystalCap = CrystalCap & 0x3f;
-
- return CrystalCap;
+ return pHalData->CrystalCap & 0x3f;
}
static void odm_SetATCStatus(void *pDM_VOID, bool ATCStatus)
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove temporary variable CrystalCap
2020-02-23 15:14 [PATCH] staging: rtl8723bs: remove temporary variable CrystalCap Colin King
@ 2020-02-24 5:25 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2020-02-24 5:25 UTC (permalink / raw)
To: Colin King, Greg Kroah-Hartman, devel; +Cc: kernel-janitors, linux-kernel
On Sun, 2020-02-23 at 15:14 +0000, Colin King wrote:
> odm_GetDefaultCrytaltalCap
Might change the likely function name typo too
from
odm_GetDefaultCrytaltalCap
to
odm_GetDefaultCrystalCap
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-24 5:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-23 15:14 [PATCH] staging: rtl8723bs: remove temporary variable CrystalCap Colin King
2020-02-24 5:25 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).