* [PATCH] libbpf: Use $(SRCARCH) for include path
@ 2019-12-27 2:41 Shile Zhang
2019-12-30 5:21 ` Andrii Nakryiko
0 siblings, 1 reply; 3+ messages in thread
From: Shile Zhang @ 2019-12-27 2:41 UTC (permalink / raw)
To: Martin KaFai Lau, Song Liu, Yonghong Song, Andrii Nakryiko
Cc: bpf, linux-kernel, Shile Zhang
To include right x86 centric include path for ARCH=x86_64.
Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
---
tools/lib/bpf/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
index defae23a0169..197d96886303 100644
--- a/tools/lib/bpf/Makefile
+++ b/tools/lib/bpf/Makefile
@@ -59,7 +59,7 @@ FEATURE_USER = .libbpf
FEATURE_TESTS = libelf libelf-mmap bpf reallocarray
FEATURE_DISPLAY = libelf bpf
-INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(ARCH)/include/uapi -I$(srctree)/tools/include/uapi
+INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(SRCARCH)/include/uapi -I$(srctree)/tools/include/uapi
FEATURE_CHECK_CFLAGS-bpf = $(INCLUDES)
check_feat := 1
--
2.24.0.rc2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libbpf: Use $(SRCARCH) for include path
2019-12-27 2:41 [PATCH] libbpf: Use $(SRCARCH) for include path Shile Zhang
@ 2019-12-30 5:21 ` Andrii Nakryiko
2019-12-30 6:29 ` Shile Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Andrii Nakryiko @ 2019-12-30 5:21 UTC (permalink / raw)
To: Shile Zhang
Cc: Martin KaFai Lau, Song Liu, Yonghong Song, Andrii Nakryiko, bpf,
open list
On Thu, Dec 26, 2019 at 6:42 PM Shile Zhang
<shile.zhang@linux.alibaba.com> wrote:
>
> To include right x86 centric include path for ARCH=x86_64.
>
> Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
> ---
> tools/lib/bpf/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index defae23a0169..197d96886303 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile
> @@ -59,7 +59,7 @@ FEATURE_USER = .libbpf
> FEATURE_TESTS = libelf libelf-mmap bpf reallocarray
> FEATURE_DISPLAY = libelf bpf
>
> -INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(ARCH)/include/uapi -I$(srctree)/tools/include/uapi
> +INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(SRCARCH)/include/uapi -I$(srctree)/tools/include/uapi
Is this breaking anything at all right now? I just tried removing
arch-specific include and everything still compiled successfully. So
maybe instead let's just drop arch-specific include path?
> FEATURE_CHECK_CFLAGS-bpf = $(INCLUDES)
>
> check_feat := 1
> --
> 2.24.0.rc2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libbpf: Use $(SRCARCH) for include path
2019-12-30 5:21 ` Andrii Nakryiko
@ 2019-12-30 6:29 ` Shile Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Shile Zhang @ 2019-12-30 6:29 UTC (permalink / raw)
To: Andrii Nakryiko
Cc: Martin KaFai Lau, Song Liu, Yonghong Song, Andrii Nakryiko, bpf,
open list
On 2019/12/30 13:21, Andrii Nakryiko wrote:
> On Thu, Dec 26, 2019 at 6:42 PM Shile Zhang
> <shile.zhang@linux.alibaba.com> wrote:
>> To include right x86 centric include path for ARCH=x86_64.
>>
>> Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
>> ---
>> tools/lib/bpf/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
>> index defae23a0169..197d96886303 100644
>> --- a/tools/lib/bpf/Makefile
>> +++ b/tools/lib/bpf/Makefile
>> @@ -59,7 +59,7 @@ FEATURE_USER = .libbpf
>> FEATURE_TESTS = libelf libelf-mmap bpf reallocarray
>> FEATURE_DISPLAY = libelf bpf
>>
>> -INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(ARCH)/include/uapi -I$(srctree)/tools/include/uapi
>> +INCLUDES = -I. -I$(srctree)/tools/include -I$(srctree)/tools/arch/$(SRCARCH)/include/uapi -I$(srctree)/tools/include/uapi
> Is this breaking anything at all right now? I just tried removing
> arch-specific include and everything still compiled successfully. So
> maybe instead let's just drop arch-specific include path?
>
No compile error/warning, but just include wrong (non-existed) include path.
I think it's OK to drop it if that path is needless.
Thanks!
>> FEATURE_CHECK_CFLAGS-bpf = $(INCLUDES)
>>
>> check_feat := 1
>> --
>> 2.24.0.rc2
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-30 6:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-27 2:41 [PATCH] libbpf: Use $(SRCARCH) for include path Shile Zhang
2019-12-30 5:21 ` Andrii Nakryiko
2019-12-30 6:29 ` Shile Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).