linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Tong Zhang <ztong0001@gmail.com>,
	gregkh@linuxfoundation.org, linux-serial@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Peter Hurley <peter@hurleysoftware.com>
Subject: Re: [PATCH v2] Fixes: tty: serial: earlycon dependency
Date: Tue, 18 Aug 2020 07:42:29 +0200	[thread overview]
Message-ID: <603a20ef-fe09-c4ae-11d0-3f1dc7b87580@kernel.org> (raw)
In-Reply-To: <20200817185419.1133596-1-ztong0001@gmail.com>

On 17. 08. 20, 20:54, Tong Zhang wrote:
> parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
> in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
> should automatically select SERIAL_CORE, otherwise will result in symbol
> not found error during linking if SERIAL_CORE is not configured as builtin
> 
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>

The "Fixes:" keyword should not have been in the Subject but here.
According to your findings something like this:

Fixes: 73abaf87f01b (serial: earlycon: Refactor parse_options into
serial core)

I am not sure:
1) it should be "select" (and not "depends")
2) serial earlycon should depend on serial core. But it's likely OK.

>  drivers/tty/serial/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 8a0352eb337c..42e844314cbb 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -8,6 +8,7 @@ menu "Serial drivers"
>  
>  config SERIAL_EARLYCON
>  	bool
> +	select SERIAL_CORE
>  	help
>  	  Support for early consoles with the earlycon parameter. This enables
>  	  the console before standard serial driver is probed. The console is
> 

thanks,
-- 
js
suse labs

  reply	other threads:[~2020-08-18  5:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 16:50 [PATCH] tty: serial: fix earlycon dependency Tong Zhang
2020-08-17 17:00 ` Greg KH
2020-08-17 17:25   ` Tong Zhang
2020-08-17 18:54   ` [PATCH v2] Fixes: tty: serial: " Tong Zhang
2020-08-18  5:42     ` Jiri Slaby [this message]
2020-08-18 11:19     ` Greg KH
2020-08-18 16:25       ` [PATCH v3] " Tong Zhang
2020-08-18 18:54         ` [PATCH v4] " Tong Zhang
2020-08-28  8:20           ` Greg KH
2020-08-28 12:39             ` [PATCH v5] " Tong Zhang
2020-08-28 12:41             ` [PATCH v4] " Tong Zhang
2020-08-18 16:27       ` [PATCH v2] Fixes: " Tong Zhang
2020-08-17 18:52 Tong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=603a20ef-fe09-c4ae-11d0-3f1dc7b87580@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=ztong0001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).