From: Tong Zhang <ztong0001@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: fix earlycon dependency
Date: Mon, 17 Aug 2020 13:25:22 -0400 [thread overview]
Message-ID: <CAA5qM4AH7rLCve8YjZ50No02BY524nPbSOJVa+8_e3dXKmpuJw@mail.gmail.com> (raw)
In-Reply-To: <20200817170038.GA725471@kroah.com>
On Mon, Aug 17, 2020 at 1:00 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> We can handle lines 72 characters long :)
OK, thanks, I was not aware of that, I will reformat the text in the
next version
> > Signed-off-by: Tong Zhang <ztong0001@gmail.com>
>
> What broke to cause this to be needed?
newbie here, please don't laugh at me,
I just followed what people were doing after read some articles from
the internet
> Can you provide a "Fixes:" tag for this?
sure, thanks for the suggestion
>
> > ---
> > drivers/tty/serial/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index 8a0352eb337c..42e844314cbb 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -8,6 +8,7 @@ menu "Serial drivers"
> >
> > config SERIAL_EARLYCON
> > bool
> > + select SERIAL_CORE
>
> Are you _sure_ about this? This feels odd...
Yeah.. that also seems odd to me -- this bug can be triggered under
some corner cases
which I haven't figured out why --
I can encounter this problem when doing allmodconfig followed by some random
select/deselect in menuconfig. -- It seems that menuconfig is not
doing some dependency
check correctly, i.e. when SERIAL_CORE is not builtin, SERIAL_EARLYCON
should not
be selected either.
What do you suggest?
> thanks,
Thank you.
> greg k-h
next prev parent reply other threads:[~2020-08-17 17:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 16:50 [PATCH] tty: serial: fix earlycon dependency Tong Zhang
2020-08-17 17:00 ` Greg KH
2020-08-17 17:25 ` Tong Zhang [this message]
2020-08-17 18:54 ` [PATCH v2] Fixes: tty: serial: " Tong Zhang
2020-08-18 5:42 ` Jiri Slaby
2020-08-18 11:19 ` Greg KH
2020-08-18 16:25 ` [PATCH v3] " Tong Zhang
2020-08-18 18:54 ` [PATCH v4] " Tong Zhang
2020-08-28 8:20 ` Greg KH
2020-08-28 12:39 ` [PATCH v5] " Tong Zhang
2020-08-28 12:41 ` [PATCH v4] " Tong Zhang
2020-08-18 16:27 ` [PATCH v2] Fixes: " Tong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA5qM4AH7rLCve8YjZ50No02BY524nPbSOJVa+8_e3dXKmpuJw@mail.gmail.com \
--to=ztong0001@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).