From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] arc: perf: Enable generic "cache-references" and "cache-misses" events
Date: Fri, 26 Aug 2016 10:30:24 -0700 [thread overview]
Message-ID: <6074e252-6e18-bb01-4de1-023bd7e82f03@synopsys.com> (raw)
In-Reply-To: <1472125647-518-1-git-send-email-abrodkin@synopsys.com>
On 08/25/2016 04:49 AM, Alexey Brodkin wrote:
> ...
> [PERF_COUNT_ARC_EDTLB] = "edtlb", /* D-TLB Miss */
> [PERF_COUNT_ARC_EITLB] = "eitlb", /* I-TLB Miss */
> +
> + [PERF_COUNT_HW_CACHE_REFERENCES] = "imemrdc", /* Instr: mem read cached */
> + [PERF_COUNT_HW_CACHE_MISSES] = "dclm", /* D-cache Load Miss */
I think this is duplicating a mistake we already have. I vaguely remember when
doing some hackbench profiling last year with range based profiling confined to
memset routine and saw that L1-dcache-misses was counting zero. This is because it
only counts LD misses while memset only does ST.
Performance counter stats for '/sbin/hackbench':
0 L1-dcache-misses
0 L1-dcache-load-misses
1846082 L1-dcache-store-misses
@PeterZ do you concur that is wrong and we ought to setup 2 counters to do this
correctly ?
-Vineet
next prev parent reply other threads:[~2016-08-26 17:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 11:47 [PATCH] arc: perf: Enable generic "cache-references" and "cache-misses" events Alexey Brodkin
2016-08-26 17:30 ` Vineet Gupta [this message]
2016-08-31 19:05 ` Vineet Gupta
2016-09-01 8:33 ` Peter Zijlstra
2016-09-20 20:56 ` perf event grouping for dummies (was Re: [PATCH] arc: perf: Enable generic "cache-references" and "cache-misses" events) Vineet Gupta
2016-09-22 0:43 ` Paul Clarke
2016-09-22 7:56 ` Peter Zijlstra
2016-09-22 17:50 ` Vineet Gupta
2016-09-22 18:23 ` Paul Clarke
2016-09-22 19:42 ` Arnaldo Carvalho de Melo
2016-09-14 17:53 ` [PATCH] arc: perf: Enable generic "cache-references" and "cache-misses" events Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6074e252-6e18-bb01-4de1-023bd7e82f03@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).