* Re: [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe()
2021-04-08 10:01 [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe() Ruiqi Gong
@ 2021-04-08 10:01 ` Shenhar, Talel
0 siblings, 0 replies; 2+ messages in thread
From: Shenhar, Talel @ 2021-04-08 10:01 UTC (permalink / raw)
To: Ruiqi Gong, Zhang Rui, Daniel Lezcano
Cc: Wang Weiyang, linux-pm, kernel-janitors, linux-kernel,
Ronen Krupnik, talelshenhar, talel
On 4/8/2021 1:01 PM, Ruiqi Gong wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
> ---
> drivers/thermal/thermal_mmio.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c
> index d0bdf1ea3331..ded1dd0d4ef7 100644
> --- a/drivers/thermal/thermal_mmio.c
> +++ b/drivers/thermal/thermal_mmio.c
> @@ -54,11 +54,8 @@ static int thermal_mmio_probe(struct platform_device *pdev)
>
> resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource);
> - if (IS_ERR(sensor->mmio_base)) {
> - dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n",
> - PTR_ERR(sensor->mmio_base));
> + if (IS_ERR(sensor->mmio_base))
> return PTR_ERR(sensor->mmio_base);
> - }
>
> sensor_init_func = device_get_match_data(&pdev->dev);
> if (sensor_init_func) {
Acked-by: Talel Shenhar <talel@amazon.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe()
@ 2021-04-08 10:01 Ruiqi Gong
2021-04-08 10:01 ` Shenhar, Talel
0 siblings, 1 reply; 2+ messages in thread
From: Ruiqi Gong @ 2021-04-08 10:01 UTC (permalink / raw)
To: gongruiqi1, Talel Shenhar, Zhang Rui, Daniel Lezcano
Cc: Wang Weiyang, linux-pm, kernel-janitors, linux-kernel
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
---
drivers/thermal/thermal_mmio.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/thermal/thermal_mmio.c b/drivers/thermal/thermal_mmio.c
index d0bdf1ea3331..ded1dd0d4ef7 100644
--- a/drivers/thermal/thermal_mmio.c
+++ b/drivers/thermal/thermal_mmio.c
@@ -54,11 +54,8 @@ static int thermal_mmio_probe(struct platform_device *pdev)
resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource);
- if (IS_ERR(sensor->mmio_base)) {
- dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n",
- PTR_ERR(sensor->mmio_base));
+ if (IS_ERR(sensor->mmio_base))
return PTR_ERR(sensor->mmio_base);
- }
sensor_init_func = device_get_match_data(&pdev->dev);
if (sensor_init_func) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-08 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 10:01 [PATCH -next] thermal: thermal_mmio: remove redundant dev_err call in thermal_mmio_probe() Ruiqi Gong
2021-04-08 10:01 ` Shenhar, Talel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).