From: Joe Perches <joe@perches.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: "Moore, Robert" <robert.moore@intel.com>,
"Kaneda, Erik" <erik.kaneda@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
"clang-built-linux@googlegroups.com"
<clang-built-linux@googlegroups.com>, Len Brown <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
Date: Fri, 13 Nov 2020 08:29:52 -0800 [thread overview]
Message-ID: <61039da395c8a28444e2f3958d29deda4c0d49b3.camel@perches.com> (raw)
In-Reply-To: <CANiq72k13K_zA5aH5hameoe4TSf2o5cA294bA4UEZG0M6S3DXQ@mail.gmail.com>
On Fri, 2020-11-13 at 09:14 +0100, Miguel Ojeda wrote:
> On Fri, Nov 13, 2020 at 1:09 AM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> >
> > Thank you for the explicit diagnostics observed. Something fishy is
> > going on though, https://godbolt.org/z/Gbxbxa is how I expect MSVC to
> > handle include/linux/compiler_attributes.h.
> >
> > The C preprocessor should make it such that MSVC never sees
> > `__attribute__` or `__fallthrough__`; that it does begs the question.
> > That would seem to imply that `#if __has_attribute(__fallthrough__)`
> > somehow evaluates to true on MSVC, but my godbolt link shows it does
> > not.
> >
> > Could the upstream ACPICA project be #define'ing something that could
> > be altering this? (Or not #define'ing something?)
> >
> > Worst case, we could do as Joe Perches suggested and disable
> > -Wfallthrough for drivers/acpi/acpica/.
>
> I agree, something is fishy. MSVC has several flags for conformance
> and extensions support, including two full C preprocessors in newer
> versions; which means we might be missing something, but I don't see
> how the code in compiler_attributes.h could be confusing MSVC even in
> older non-conforming versions.
I believe this has nothing to do with linux and only
to do with compiling acpica for other environments
like Windows.
From: https://acpica.org/
The ACPI Component Architecture (ACPICA) project provides an
operating system (OS)-independent reference implementation of the
Advanced Configuration and Power Interface Specification (ACPI).
It can be easily adapted to execute under any host OS.
next prev parent reply other threads:[~2020-11-13 16:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 2:11 [PATCH] ACPICA: fix -Wfallthrough Nick Desaulniers
2020-11-11 15:15 ` Moore, Robert
2020-11-11 18:48 ` Nick Desaulniers
2020-11-12 15:13 ` Moore, Robert
2020-11-12 19:30 ` Nick Desaulniers
2020-11-12 20:22 ` Joe Perches
2020-11-12 21:47 ` Moore, Robert
2020-11-13 0:09 ` Nick Desaulniers
2020-11-13 8:14 ` Miguel Ojeda
2020-11-13 16:29 ` Joe Perches [this message]
2020-11-13 21:01 ` Moore, Robert
2020-11-13 21:04 ` Nick Desaulniers
2020-11-13 21:00 ` Nick Desaulniers
2020-11-13 8:10 ` Miguel Ojeda
2020-11-13 21:27 ` Moore, Robert
2020-11-13 21:32 ` Nick Desaulniers
2020-11-13 21:42 ` Moore, Robert
2020-11-13 21:43 ` Nick Desaulniers
2020-11-13 21:43 ` Moore, Robert
2020-11-13 21:45 ` Moore, Robert
2020-11-13 22:09 ` Nick Desaulniers
2020-11-13 22:12 ` Moore, Robert
2021-01-21 10:06 ` Jon Hunter
2021-01-21 19:03 ` Rafael J. Wysocki
2021-01-21 19:07 ` Nick Desaulniers
2021-01-21 22:05 ` Kaneda, Erik
2021-01-21 22:28 ` Kaneda, Erik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61039da395c8a28444e2f3958d29deda4c0d49b3.camel@perches.com \
--to=joe@perches.com \
--cc=clang-built-linux@googlegroups.com \
--cc=devel@acpica.org \
--cc=erik.kaneda@intel.com \
--cc=gustavoars@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ndesaulniers@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).