From: Nick Desaulniers <ndesaulniers@google.com>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: Joe Perches <joe@perches.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
"Kaneda, Erik" <erik.kaneda@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
"clang-built-linux@googlegroups.com"
<clang-built-linux@googlegroups.com>, Len Brown <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"devel@acpica.org" <devel@acpica.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ACPICA: fix -Wfallthrough
Date: Fri, 13 Nov 2020 13:04:08 -0800 [thread overview]
Message-ID: <CAKwvOdn4-CYtszj324JoOL6GBtUAeieTocc3cQyVUJJvd9AG6w@mail.gmail.com> (raw)
In-Reply-To: <BYAPR11MB3256ECDE31F1900EE1D9254687E60@BYAPR11MB3256.namprd11.prod.outlook.com>
On Fri, Nov 13, 2020 at 1:01 PM Moore, Robert <robert.moore@intel.com> wrote:
>
> I can do it this way:
>
> In the global header actypes.h:
>
> #ifndef ACPI_FALLTHROUGH
> #define ACPI_FALLTHROUGH
> #endif
>
> In the gcc-specific header (acgcc.h):
>
> #define ACPI_FALLTHROUGH __attribute__((__fallthrough__))
>
> This would not be #defined in the MSVC-specific header (acmsvc.h) -- thus using the default (null) in actypes.h (The per-environment headers are always included first).
>
> (We do all macros in upper case, prefixed with "ACPI_")
>
> If you can update your patch to use ACPI_FALLTHROUGH, I can do the rest (above).
Sure, I can do that. I'd need to wrap it in a little more logic for
__has_attribute to support old GCC versions, but that should be
doable.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2020-11-13 21:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 2:11 [PATCH] ACPICA: fix -Wfallthrough Nick Desaulniers
2020-11-11 15:15 ` Moore, Robert
2020-11-11 18:48 ` Nick Desaulniers
2020-11-12 15:13 ` Moore, Robert
2020-11-12 19:30 ` Nick Desaulniers
2020-11-12 20:22 ` Joe Perches
2020-11-12 21:47 ` Moore, Robert
2020-11-13 0:09 ` Nick Desaulniers
2020-11-13 8:14 ` Miguel Ojeda
2020-11-13 16:29 ` Joe Perches
2020-11-13 21:01 ` Moore, Robert
2020-11-13 21:04 ` Nick Desaulniers [this message]
2020-11-13 21:00 ` Nick Desaulniers
2020-11-13 8:10 ` Miguel Ojeda
2020-11-13 21:27 ` Moore, Robert
2020-11-13 21:32 ` Nick Desaulniers
2020-11-13 21:42 ` Moore, Robert
2020-11-13 21:43 ` Nick Desaulniers
2020-11-13 21:43 ` Moore, Robert
2020-11-13 21:45 ` Moore, Robert
2020-11-13 22:09 ` Nick Desaulniers
2020-11-13 22:12 ` Moore, Robert
2021-01-21 10:06 ` Jon Hunter
2021-01-21 19:03 ` Rafael J. Wysocki
2021-01-21 19:07 ` Nick Desaulniers
2021-01-21 22:05 ` Kaneda, Erik
2021-01-21 22:28 ` Kaneda, Erik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdn4-CYtszj324JoOL6GBtUAeieTocc3cQyVUJJvd9AG6w@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=devel@acpica.org \
--cc=erik.kaneda@intel.com \
--cc=gustavoars@kernel.org \
--cc=joe@perches.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).