* [PATCH] scsi:remove unreachable code on scsi_decide_disposition func
@ 2019-12-17 11:53 wubo (T)
2019-12-17 15:05 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: wubo (T) @ 2019-12-17 11:53 UTC (permalink / raw)
To: jejb, martin.petersen, linux-scsi, linux-kernel; +Cc: Mingfangsen
From: Wu Bo <wubo40@huawei.com>
Remove unreachable code on scsi_decide_disposition func.
Signed-off-by: Wu Bo <wubo40@huawei.com>
---
drivers/scsi/scsi_error.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index ae2fa17..c5e05c4 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -1934,7 +1934,6 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
default:
return FAILED;
}
- return FAILED;
maybe_retry:
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi:remove unreachable code on scsi_decide_disposition func
2019-12-17 11:53 [PATCH] scsi:remove unreachable code on scsi_decide_disposition func wubo (T)
@ 2019-12-17 15:05 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2019-12-17 15:05 UTC (permalink / raw)
To: wubo (T), jejb, martin.petersen, linux-scsi, linux-kernel; +Cc: Mingfangsen
On 2019-12-17 03:53, wubo (T) wrote:
> From: Wu Bo <wubo40@huawei.com>
>
> Remove unreachable code on scsi_decide_disposition func.
>
> Signed-off-by: Wu Bo <wubo40@huawei.com>
> ---
> drivers/scsi/scsi_error.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index ae2fa17..c5e05c4 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -1934,7 +1934,6 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
> default:
> return FAILED;
> }
> - return FAILED;
>
> maybe_retry:
I'm not sure it's worth to address this issue. If
scsi_decide_disposition() is changed I prefer to remove the "default:
return FAILED;" code because compilers can provide more useful
diagnostics about switch/case statements that do not have a default
statement, especially if the "switch" applies to a value with
enumeration type.
Bart.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-17 15:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 11:53 [PATCH] scsi:remove unreachable code on scsi_decide_disposition func wubo (T)
2019-12-17 15:05 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).