* [PATCH] ARM: Fix __show_regs output timestamps
@ 2017-04-26 17:39 Joe Perches
2017-04-26 20:18 ` Andreas Kemnade
2017-05-03 19:23 ` Russell King - ARM Linux
0 siblings, 2 replies; 8+ messages in thread
From: Joe Perches @ 2017-04-26 17:39 UTC (permalink / raw)
To: linux-kernel; +Cc: Andreas Kemnade, Russell King, linux-arm-kernel
Multiple line formats are not preferred as the second and
subsequent lines may not have timestamps.
Lacking timestamps makes reading the output a bit difficult.
This also makes arm/arm64 output more similar.
Previous:
[ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
sp : ecdd7e20 ip : 00000000 fp : ffffffff
New:
[ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
[ 1514.105316] sp : ecdd7e20 ip : 00000000 fp : ffffffff
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/arm/kernel/process.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index 939e8b58c59d..151cece4a293 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -123,10 +123,10 @@ void __show_regs(struct pt_regs *regs)
print_symbol("PC is at %s\n", instruction_pointer(regs));
print_symbol("LR is at %s\n", regs->ARM_lr);
- printk("pc : [<%08lx>] lr : [<%08lx>] psr: %08lx\n"
- "sp : %08lx ip : %08lx fp : %08lx\n",
- regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr,
- regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
+ printk("pc : [<%08lx>] lr : [<%08lx>] psr: %08lx\n",
+ regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr);
+ printk("sp : %08lx ip : %08lx fp : %08lx\n",
+ regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
printk("r10: %08lx r9 : %08lx r8 : %08lx\n",
regs->ARM_r10, regs->ARM_r9,
regs->ARM_r8);
--
2.10.0.rc2.1.g053435c
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Fix __show_regs output timestamps
2017-04-26 17:39 [PATCH] ARM: Fix __show_regs output timestamps Joe Perches
@ 2017-04-26 20:18 ` Andreas Kemnade
2017-05-03 19:23 ` Russell King - ARM Linux
1 sibling, 0 replies; 8+ messages in thread
From: Andreas Kemnade @ 2017-04-26 20:18 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, Russell King, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 2043 bytes --]
On Wed, 26 Apr 2017 10:39:49 -0700
Joe Perches <joe@perches.com> wrote:
> Multiple line formats are not preferred as the second and
> subsequent lines may not have timestamps.
>
> Lacking timestamps makes reading the output a bit difficult.
> This also makes arm/arm64 output more similar.
>
> Previous:
>
> [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> sp : ecdd7e20 ip : 00000000 fp : ffffffff
>
> New:
>
> [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> [ 1514.105316] sp : ecdd7e20 ip : 00000000 fp : ffffffff
>
[ 102.669036] PC is at hso_start_net_device+0x50/0xc0 [hso]
[ 102.674835] LR is at hso_net_open+0x68/0x84 [hso]
[ 102.679809] pc : [<bf785304>] lr : [<bf785ed8>] psr: a00b0013
[ 102.686462] sp : ed047e20 ip : 00000000 fp : ffffffff
yes, the kernel oopses in a nicer way.
Tested-by: Andreas Kemnade <andreas@kemnade.info>
Regards,
Andreas Kemnade
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/arm/kernel/process.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 939e8b58c59d..151cece4a293 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -123,10 +123,10 @@ void __show_regs(struct pt_regs *regs)
>
> print_symbol("PC is at %s\n", instruction_pointer(regs));
> print_symbol("LR is at %s\n", regs->ARM_lr);
> - printk("pc : [<%08lx>] lr : [<%08lx>] psr: %08lx\n"
> - "sp : %08lx ip : %08lx fp : %08lx\n",
> - regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr,
> - regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
> + printk("pc : [<%08lx>] lr : [<%08lx>] psr: %08lx\n",
> + regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr);
> + printk("sp : %08lx ip : %08lx fp : %08lx\n",
> + regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
> printk("r10: %08lx r9 : %08lx r8 : %08lx\n",
> regs->ARM_r10, regs->ARM_r9,
> regs->ARM_r8);
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Fix __show_regs output timestamps
2017-04-26 17:39 [PATCH] ARM: Fix __show_regs output timestamps Joe Perches
2017-04-26 20:18 ` Andreas Kemnade
@ 2017-05-03 19:23 ` Russell King - ARM Linux
2017-05-03 19:40 ` Joe Perches
2017-05-03 19:44 ` Joe Perches
1 sibling, 2 replies; 8+ messages in thread
From: Russell King - ARM Linux @ 2017-05-03 19:23 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, Andreas Kemnade, linux-arm-kernel
On Wed, Apr 26, 2017 at 10:39:49AM -0700, Joe Perches wrote:
> Multiple line formats are not preferred as the second and
> subsequent lines may not have timestamps.
>
> Lacking timestamps makes reading the output a bit difficult.
> This also makes arm/arm64 output more similar.
>
> Previous:
>
> [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> sp : ecdd7e20 ip : 00000000 fp : ffffffff
>
> New:
>
> [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> [ 1514.105316] sp : ecdd7e20 ip : 00000000 fp : ffffffff
>
> Signed-off-by: Joe Perches <joe@perches.com>
Hi Joe,
Could you put this in my patch system please, I'm unlikely to remember to
apply it otherwise if not already there (massive email backlog.)
Thanks.
> ---
> arch/arm/kernel/process.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index 939e8b58c59d..151cece4a293 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -123,10 +123,10 @@ void __show_regs(struct pt_regs *regs)
>
> print_symbol("PC is at %s\n", instruction_pointer(regs));
> print_symbol("LR is at %s\n", regs->ARM_lr);
> - printk("pc : [<%08lx>] lr : [<%08lx>] psr: %08lx\n"
> - "sp : %08lx ip : %08lx fp : %08lx\n",
> - regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr,
> - regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
> + printk("pc : [<%08lx>] lr : [<%08lx>] psr: %08lx\n",
> + regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr);
> + printk("sp : %08lx ip : %08lx fp : %08lx\n",
> + regs->ARM_sp, regs->ARM_ip, regs->ARM_fp);
> printk("r10: %08lx r9 : %08lx r8 : %08lx\n",
> regs->ARM_r10, regs->ARM_r9,
> regs->ARM_r8);
> --
> 2.10.0.rc2.1.g053435c
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Fix __show_regs output timestamps
2017-05-03 19:23 ` Russell King - ARM Linux
@ 2017-05-03 19:40 ` Joe Perches
2017-05-03 19:44 ` Joe Perches
1 sibling, 0 replies; 8+ messages in thread
From: Joe Perches @ 2017-05-03 19:40 UTC (permalink / raw)
To: Russell King - ARM Linux; +Cc: linux-kernel, Andreas Kemnade, linux-arm-kernel
On Wed, 2017-05-03 at 20:23 +0100, Russell King - ARM Linux wrote:
> On Wed, Apr 26, 2017 at 10:39:49AM -0700, Joe Perches wrote:
> > Multiple line formats are not preferred as the second and
> > subsequent lines may not have timestamps.
> >
> > Lacking timestamps makes reading the output a bit difficult.
> > This also makes arm/arm64 output more similar.
> >
> > Previous:
> >
> > [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> > sp : ecdd7e20 ip : 00000000 fp : ffffffff
> >
> > New:
> >
> > [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> > [ 1514.105316] sp : ecdd7e20 ip : 00000000 fp : ffffffff
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> Hi Joe,
>
> Could you put this in my patch system please, I'm unlikely to remember to
> apply it otherwise if not already there (massive email backlog.)
>
> Thanks.
Rehi Russell.
Done, and I had to lookup your "my patch system", even
though it was in your trailer, the email address of the
system wasn't listed until bullet point 8.
If you've the time to ask me to do this, it seems likely
you could have forwarded the original email to your patch
system yourself instead.
Also "patches@armlinux.org.uk" isn't mentioned at all in
either the documentation or MAINTAINERS. Should it be?
btw: http://www.armlinux.org.uk/developer/patches/info.php
has many outdated references like:
Once the 2.7 kernel opens, support for new features in the 2.6
kernels will not be accepted unless similar support is also available
for the 2.7 kernel.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Fix __show_regs output timestamps
2017-05-03 19:23 ` Russell King - ARM Linux
2017-05-03 19:40 ` Joe Perches
@ 2017-05-03 19:44 ` Joe Perches
2017-05-03 21:30 ` Russell King - ARM Linux
1 sibling, 1 reply; 8+ messages in thread
From: Joe Perches @ 2017-05-03 19:44 UTC (permalink / raw)
To: Russell King - ARM Linux; +Cc: linux-kernel, Andreas Kemnade, linux-arm-kernel
On Wed, 2017-05-03 at 20:23 +0100, Russell King - ARM Linux wrote:
> On Wed, Apr 26, 2017 at 10:39:49AM -0700, Joe Perches wrote:
> > Multiple line formats are not preferred as the second and
> > subsequent lines may not have timestamps.
> >
> > Lacking timestamps makes reading the output a bit difficult.
> > This also makes arm/arm64 output more similar.
> >
> > Previous:
> >
> > [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> > sp : ecdd7e20 ip : 00000000 fp : ffffffff
> >
> > New:
> >
> > [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> > [ 1514.105316] sp : ecdd7e20 ip : 00000000 fp : ffffffff
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> Hi Joe,
>
> Could you put this in my patch system please, I'm unlikely to remember to
> apply it otherwise if not already there (massive email backlog.)
>
> Thanks.
Your patch system bounced my perfectly formatted patch
because your system wants totally unnecessary additional
information specific to your workflow.
No thanks, I don't need the additional work just to
please your system and neither should anyone else.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Fix __show_regs output timestamps
2017-05-03 19:44 ` Joe Perches
@ 2017-05-03 21:30 ` Russell King - ARM Linux
2017-05-04 0:24 ` Joe Perches
0 siblings, 1 reply; 8+ messages in thread
From: Russell King - ARM Linux @ 2017-05-03 21:30 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, Andreas Kemnade, linux-arm-kernel
On Wed, May 03, 2017 at 12:44:11PM -0700, Joe Perches wrote:
> On Wed, 2017-05-03 at 20:23 +0100, Russell King - ARM Linux wrote:
> > On Wed, Apr 26, 2017 at 10:39:49AM -0700, Joe Perches wrote:
> > > Multiple line formats are not preferred as the second and
> > > subsequent lines may not have timestamps.
> > >
> > > Lacking timestamps makes reading the output a bit difficult.
> > > This also makes arm/arm64 output more similar.
> > >
> > > Previous:
> > >
> > > [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> > > sp : ecdd7e20 ip : 00000000 fp : ffffffff
> > >
> > > New:
> > >
> > > [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> > > [ 1514.105316] sp : ecdd7e20 ip : 00000000 fp : ffffffff
> > >
> > > Signed-off-by: Joe Perches <joe@perches.com>
> >
> > Hi Joe,
> >
> > Could you put this in my patch system please, I'm unlikely to remember to
> > apply it otherwise if not already there (massive email backlog.)
> >
> > Thanks.
>
> Your patch system bounced my perfectly formatted patch
> because your system wants totally unnecessary additional
> information specific to your workflow.
>
> No thanks, I don't need the additional work just to
> please your system and neither should anyone else.
Don't expect me to remember to apply your patch then. I've got days of
catch up, and I'm just not going to remember. Sorry.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Fix __show_regs output timestamps
2017-05-03 21:30 ` Russell King - ARM Linux
@ 2017-05-04 0:24 ` Joe Perches
2017-05-04 8:27 ` Vladimir Murzin
0 siblings, 1 reply; 8+ messages in thread
From: Joe Perches @ 2017-05-04 0:24 UTC (permalink / raw)
To: Russell King - ARM Linux; +Cc: linux-kernel, Andreas Kemnade, linux-arm-kernel
On Wed, 2017-05-03 at 22:30 +0100, Russell King - ARM Linux wrote:
> On Wed, May 03, 2017 at 12:44:11PM -0700, Joe Perches wrote:
> > On Wed, 2017-05-03 at 20:23 +0100, Russell King - ARM Linux wrote:
> > > On Wed, Apr 26, 2017 at 10:39:49AM -0700, Joe Perches wrote:
> > > > Multiple line formats are not preferred as the second and
> > > > subsequent lines may not have timestamps.
> > > >
> > > > Lacking timestamps makes reading the output a bit difficult.
> > > > This also makes arm/arm64 output more similar.
> > > >
> > > > Previous:
> > > >
> > > > [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> > > > sp : ecdd7e20 ip : 00000000 fp : ffffffff
> > > >
> > > > New:
> > > >
> > > > [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
> > > > [ 1514.105316] sp : ecdd7e20 ip : 00000000 fp : ffffffff
> > > >
> > > > Signed-off-by: Joe Perches <joe@perches.com>
> > >
> > > Hi Joe,
> > >
> > > Could you put this in my patch system please, I'm unlikely to remember to
> > > apply it otherwise if not already there (massive email backlog.)
> > >
> > > Thanks.
> >
> > Your patch system bounced my perfectly formatted patch
> > because your system wants totally unnecessary additional
> > information specific to your workflow.
> >
> > No thanks, I don't need the additional work just to
> > please your system and neither should anyone else.
>
> Don't expect me to remember to apply your patch then. I've got days of
> catch up, and I'm just not going to remember. Sorry.
<shrug>
If your systems require special handling on the
part of patch submitters, you should document it
in the kernel tree.
Better, someone else should find the time to apply
properly formatted patches.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: Fix __show_regs output timestamps
2017-05-04 0:24 ` Joe Perches
@ 2017-05-04 8:27 ` Vladimir Murzin
0 siblings, 0 replies; 8+ messages in thread
From: Vladimir Murzin @ 2017-05-04 8:27 UTC (permalink / raw)
To: Joe Perches, Russell King - ARM Linux
Cc: Andreas Kemnade, linux-kernel, linux-arm-kernel
On 04/05/17 01:24, Joe Perches wrote:
> On Wed, 2017-05-03 at 22:30 +0100, Russell King - ARM Linux wrote:
>> On Wed, May 03, 2017 at 12:44:11PM -0700, Joe Perches wrote:
>>> On Wed, 2017-05-03 at 20:23 +0100, Russell King - ARM Linux wrote:
>>>> On Wed, Apr 26, 2017 at 10:39:49AM -0700, Joe Perches wrote:
>>>>> Multiple line formats are not preferred as the second and
>>>>> subsequent lines may not have timestamps.
>>>>>
>>>>> Lacking timestamps makes reading the output a bit difficult.
>>>>> This also makes arm/arm64 output more similar.
>>>>>
>>>>> Previous:
>>>>>
>>>>> [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
>>>>> sp : ecdd7e20 ip : 00000000 fp : ffffffff
>>>>>
>>>>> New:
>>>>>
>>>>> [ 1514.093231] pc : [<bf79c304>] lr : [<bf79ced8>] psr: a00f0013
>>>>> [ 1514.105316] sp : ecdd7e20 ip : 00000000 fp : ffffffff
>>>>>
>>>>> Signed-off-by: Joe Perches <joe@perches.com>
>>>>
>>>> Hi Joe,
>>>>
>>>> Could you put this in my patch system please, I'm unlikely to remember to
>>>> apply it otherwise if not already there (massive email backlog.)
>>>>
>>>> Thanks.
>>>
>>> Your patch system bounced my perfectly formatted patch
>>> because your system wants totally unnecessary additional
>>> information specific to your workflow.
>>>
>>> No thanks, I don't need the additional work just to
>>> please your system and neither should anyone else.
>>
>> Don't expect me to remember to apply your patch then. I've got days of
>> catch up, and I'm just not going to remember. Sorry.
>
> <shrug>
>
> If your systems require special handling on the
> part of patch submitters, you should document it
> in the kernel tree.
>
> Better, someone else should find the time to apply
> properly formatted patches.
>
Joe, I find this patch handy, so I've uploaded it into Russell's patch system
on your behalf and it has been accepted as patch 8673/1.
Cheers
Vladimir
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-05-04 8:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-26 17:39 [PATCH] ARM: Fix __show_regs output timestamps Joe Perches
2017-04-26 20:18 ` Andreas Kemnade
2017-05-03 19:23 ` Russell King - ARM Linux
2017-05-03 19:40 ` Joe Perches
2017-05-03 19:44 ` Joe Perches
2017-05-03 21:30 ` Russell King - ARM Linux
2017-05-04 0:24 ` Joe Perches
2017-05-04 8:27 ` Vladimir Murzin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).