From: Johannes Berg <johannes@sipsolutions.net>
To: madhuparnabhowmik10@gmail.com, davem@davemloft.net, kuba@kernel.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, frextrite@gmail.com,
joel@joelfernandes.org, paulmck@kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 4/4] net: mac80211: mlme.c: Add lockdep condition for RCU list usage
Date: Fri, 24 Apr 2020 11:24:40 +0200 [thread overview]
Message-ID: <61c8c547b9148b8297aa946a93df23608f408d28.camel@sipsolutions.net> (raw)
In-Reply-To: <20200409082925.27481-1-madhuparnabhowmik10@gmail.com> (sfid-20200409_102943_941405_F4B3E85F)
On Thu, 2020-04-09 at 13:59 +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> ieee80211_add_vht_ie() is called with sdata->wdev.mtx held from
> ieee80211_send_assoc(). Add lockdep condition to avoid false positive
> warnings.
Again, wrong lock!
Over the course of the three patches, you've now claimed that any one of
* RTNL,
* local->iflist_mtx,
* local->mtx, and
* sdata->wdev.mtx
are sufficient to iterate the interface list, but only the first two are
really true.
johannes
prev parent reply other threads:[~2020-04-24 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 8:29 [PATCH 4/4] net: mac80211: mlme.c: Add lockdep condition for RCU list usage madhuparnabhowmik10
2020-04-24 9:24 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61c8c547b9148b8297aa946a93df23608f408d28.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).