* [PATCH] video: matroxfb: Delete an error message for a failed memory allocation in matroxfb_crtc2_probe()
@ 2017-11-26 21:32 ` SF Markus Elfring
2018-03-28 14:08 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-11-26 21:32 UTC (permalink / raw)
To: linux-fbdev, dri-devel, Bartlomiej Zolnierkiewicz; +Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 26 Nov 2017 22:13:55 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/video/fbdev/matrox/matroxfb_crtc2.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/matrox/matroxfb_crtc2.c b/drivers/video/fbdev/matrox/matroxfb_crtc2.c
index 02796a4317a9..f64e1d55d7a1 100644
--- a/drivers/video/fbdev/matrox/matroxfb_crtc2.c
+++ b/drivers/video/fbdev/matrox/matroxfb_crtc2.c
@@ -696,10 +696,9 @@ static void* matroxfb_crtc2_probe(struct matrox_fb_info* minfo) {
if (!minfo->devflags.crtc2)
return NULL;
m2info = kzalloc(sizeof(*m2info), GFP_KERNEL);
- if (!m2info) {
- printk(KERN_ERR "matroxfb_crtc2: Not enough memory for CRTC2 control structs\n");
+ if (!m2info)
return NULL;
- }
+
m2info->primary_dev = minfo;
if (matroxfb_dh_registerfb(m2info)) {
kfree(m2info);
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: matroxfb: Delete an error message for a failed memory allocation in matroxfb_crtc2_probe()
2017-11-26 21:32 ` [PATCH] video: matroxfb: Delete an error message for a failed memory allocation in matroxfb_crtc2_probe() SF Markus Elfring
@ 2018-03-28 14:08 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-03-28 14:08 UTC (permalink / raw)
To: SF Markus Elfring; +Cc: linux-fbdev, dri-devel, LKML, kernel-janitors
On Sunday, November 26, 2017 10:32:06 PM SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 26 Nov 2017 22:13:55 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Patch queued for 4.17, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-28 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20171126213211epcas5p16bb3e55e1ca996b6ee57286abf39ce44@epcas5p1.samsung.com>
2017-11-26 21:32 ` [PATCH] video: matroxfb: Delete an error message for a failed memory allocation in matroxfb_crtc2_probe() SF Markus Elfring
2018-03-28 14:08 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).