From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Wei, Jiangang" <weijg.fnst@cn.fujitsu.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"david.vrabel@citrix.com" <david.vrabel@citrix.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"jgross@suse.com" <jgross@suse.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask
Date: Wed, 13 Jul 2016 14:51:07 -0400 [thread overview]
Message-ID: <6227c76d-eb29-fa28-98cc-a3fcf9680d0c@oracle.com> (raw)
In-Reply-To: <1468396427.2020.14.camel@localhost>
On 07/13/2016 03:56 AM, Wei, Jiangang wrote:
> On Thu, 2016-07-07 at 11:37 -0400, Boris Ostrovsky wrote:
>> On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote:
>>> On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote:
>>>> verify_local_APIC() had been removed by
>>>> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"),
>>>> so apic_id_mask isn't used by it.
>> Is anyone actually using this field? It looks like 4399c03c6780 removed
>> the only user.
> Indeed, the field is useless.
> Maybe we can remove this field from the struct apic .
> what's your opinion?
Since noone seems to be using those I think it can be removed.
-boris
>
> Thanks,
> wei
>> -boris
>>
>>
>>> CC-ing the proper maintainers.
>>>> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
>>>> ---
>>>> arch/x86/xen/apic.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c
>>>> index db52a7fafcc2..9cbb1f48381b 100644
>>>> --- a/arch/x86/xen/apic.c
>>>> +++ b/arch/x86/xen/apic.c
>>>> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = {
>>>>
>>>> .get_apic_id = xen_get_apic_id,
>>>> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
>>>> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */
>>>> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */
>>>>
>>>> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and,
>>>>
>>>> --
>>>> 1.9.3
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Xen-devel mailing list
>>>> Xen-devel@lists.xen.org
>>>> https://lists.xen.org/xen-devel
>>
>>
>>
>
>
prev parent reply other threads:[~2016-07-13 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 3:28 [PATCH] xen/apic: Update the comment for apic_id_mask Wei Jiangang
2016-07-07 15:25 ` [Xen-devel] " Konrad Rzeszutek Wilk
2016-07-07 15:37 ` Boris Ostrovsky
2016-07-13 7:56 ` Wei, Jiangang
2016-07-13 18:51 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6227c76d-eb29-fa28-98cc-a3fcf9680d0c@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=weijg.fnst@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).