From: Dmitry Safonov <dsafonov@virtuozzo.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: <linux-kernel@vger.kernel.org>, <0x7f454c46@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrey Vagin <avagin@openvz.org>, Rob Landley <rob@landley.net>
Subject: Re: [RFC] proc: don't show kernel-internal mnt_id in fdinfo (if possible)
Date: Mon, 7 Nov 2016 20:30:46 +0300 [thread overview]
Message-ID: <623d3267-2189-2f33-1805-2691769b87a7@virtuozzo.com> (raw)
In-Reply-To: <87pom743ty.fsf@xmission.com>
On 11/07/2016 08:06 PM, Eric W. Biederman wrote:
> Dmitry Safonov <dsafonov@virtuozzo.com> writes:
>
>> Some kernel special fs could be mounted by userspace, let's show
>> userspace mnt_id in those cases.
>
> You are asking the kernel to lie to userspace in the case when
> the truth in inconvenient. That seems blantantly wrong.
>
> In the case of an internal mount you may want to use the device id
> of the device the filesystem is mounted on so you can tie all of
> the mounts together. That would allow restore and other things
> to do something useful.
>
> That information is available with fstat on a file descriptor so I don't
> think we need to export it. But if it is not available I can see
> the point of a patch.
>
> Outright ling to userpsace. No. That is just horrible.
>
> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Ah, ok right, I see your point - then let's just drop the patch.
Thanks,
Dmitry
prev parent reply other threads:[~2016-11-07 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 16:06 [RFC] proc: don't show kernel-internal mnt_id in fdinfo (if possible) Dmitry Safonov
2016-11-07 17:06 ` Eric W. Biederman
2016-11-07 17:30 ` Dmitry Safonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=623d3267-2189-2f33-1805-2691769b87a7@virtuozzo.com \
--to=dsafonov@virtuozzo.com \
--cc=0x7f454c46@gmail.com \
--cc=avagin@openvz.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@landley.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).