From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] KVM: x86: TDP level cleanups and shadow NPT fix
Date: Fri, 31 Jul 2020 00:18:18 +0200 [thread overview]
Message-ID: <6249777c-8adb-51ca-2d40-4b9a7583b41f@redhat.com> (raw)
In-Reply-To: <20200716034122.5998-1-sean.j.christopherson@intel.com>
On 16/07/20 05:41, Sean Christopherson wrote:
> The primary purpose of this series is to implement a suggestion from Paolo
> to have the MMU make the decision between 4 and 5 level EPT/TDP (when
> 5-level page tables are supported). Having the MMU "own" the decision of
> whether or not to use 5-level paging leads to a variety of nice cleanups,
> and ultimately gets rid of another kvm_x86_ops.
>
> Patch 1 is a fix for SVM's shadow NPT that is compile tested only. I
> don't know enough about the shadow NPT details to know if it's a "real"
> bug or just a supericial oddity that can't actually cause problems.
>
> "Remove temporary WARN on expected vs. actual EPTP level mismatch" could
> easily be squashed with "Pull the PGD's level from the MMU instead of
> recalculating it", I threw it in as a separate patch to provide a
> bisection helper in case things go sideways.
>
> Sean Christopherson (9):
> KVM: nSVM: Correctly set the shadow NPT root level in its MMU role
> KVM: x86/mmu: Add separate helper for shadow NPT root page role calc
> KVM: VMX: Drop a duplicate declaration of construct_eptp()
> KVM: VMX: Make vmx_load_mmu_pgd() static
> KVM: x86: Pull the PGD's level from the MMU instead of recalculating
> it
> KVM: VXM: Remove temporary WARN on expected vs. actual EPTP level
> mismatch
> KVM: x86: Dynamically calculate TDP level from max level and
> MAXPHYADDR
> KVM: x86/mmu: Rename max_page_level to max_huge_page_level
> KVM: x86: Specify max TDP level via kvm_configure_mmu()
>
> arch/x86/include/asm/kvm_host.h | 9 ++---
> arch/x86/kvm/cpuid.c | 2 --
> arch/x86/kvm/mmu.h | 10 ++++--
> arch/x86/kvm/mmu/mmu.c | 63 +++++++++++++++++++++++++--------
> arch/x86/kvm/svm/nested.c | 1 -
> arch/x86/kvm/svm/svm.c | 8 ++---
> arch/x86/kvm/vmx/nested.c | 2 +-
> arch/x86/kvm/vmx/vmx.c | 31 +++++++---------
> arch/x86/kvm/vmx/vmx.h | 6 ++--
> arch/x86/kvm/x86.c | 1 -
> 10 files changed, 81 insertions(+), 52 deletions(-)
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-07-30 22:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 3:41 [PATCH 0/9] KVM: x86: TDP level cleanups and shadow NPT fix Sean Christopherson
2020-07-16 3:41 ` [PATCH 1/9] KVM: nSVM: Correctly set the shadow NPT root level in its MMU role Sean Christopherson
2020-07-22 17:02 ` Vitaly Kuznetsov
2020-07-16 3:41 ` [PATCH 2/9] KVM: x86/mmu: Add separate helper for shadow NPT root page role calc Sean Christopherson
2020-07-22 17:05 ` Vitaly Kuznetsov
2020-07-16 3:41 ` [PATCH 3/9] KVM: VMX: Drop a duplicate declaration of construct_eptp() Sean Christopherson
2020-07-16 3:41 ` [PATCH 4/9] KVM: VMX: Make vmx_load_mmu_pgd() static Sean Christopherson
2020-07-16 3:41 ` [PATCH 5/9] KVM: x86: Pull the PGD's level from the MMU instead of recalculating it Sean Christopherson
2020-07-22 17:11 ` Vitaly Kuznetsov
2020-07-31 16:14 ` Sean Christopherson
2020-07-16 3:41 ` [PATCH 6/9] KVM: VXM: Remove temporary WARN on expected vs. actual EPTP level mismatch Sean Christopherson
2020-07-16 3:41 ` [PATCH 7/9] KVM: x86: Dynamically calculate TDP level from max level and MAXPHYADDR Sean Christopherson
2020-07-16 3:41 ` [PATCH 8/9] KVM: x86/mmu: Rename max_page_level to max_huge_page_level Sean Christopherson
2020-07-16 3:41 ` [PATCH 9/9] KVM: x86: Specify max TDP level via kvm_configure_mmu() Sean Christopherson
2020-07-30 22:18 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6249777c-8adb-51ca-2d40-4b9a7583b41f@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).