[PATCH 1/3] dt-bindings: clock: add pcm reset for ipq806x lcc

[PATCH 1/3] dt-bindings: clock: add pcm reset for ipq806x lcc

[Christian 'Ansuel' Marangi]

Add pcm reset define for ipq806x lcc.

Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
---
 include/dt-bindings/clock/qcom,lcc-ipq806x.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/dt-bindings/clock/qcom,lcc-ipq806x.h b/include/dt-bindings/clock/qcom,lcc-ipq806x.h
index 25b92bbf0ab4..e0fb4acf4ba8 100644
--- a/include/dt-bindings/clock/qcom,lcc-ipq806x.h
+++ b/include/dt-bindings/clock/qcom,lcc-ipq806x.h
@@ -19,4 +19,6 @@
 #define SPDIF_CLK			10
 #define AHBIX_CLK			11
 
+#define LCC_PCM_RESET			0
+
 #endif
-- 
2.36.1

[PATCH 2/3] clk: qcom: lcc-ipq806x: add reset definition

[Christian 'Ansuel' Marangi]

Add reset definition for lcc-ipq806x.

Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
---
 drivers/clk/qcom/lcc-ipq806x.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/clk/qcom/lcc-ipq806x.c b/drivers/clk/qcom/lcc-ipq806x.c
index 1a2be4aeb31d..ba90bebba597 100644
--- a/drivers/clk/qcom/lcc-ipq806x.c
+++ b/drivers/clk/qcom/lcc-ipq806x.c
@@ -22,6 +22,7 @@
 #include "clk-branch.h"
 #include "clk-regmap-divider.h"
 #include "clk-regmap-mux.h"
+#include "reset.h"
 
 static struct clk_pll pll4 = {
 	.l_reg = 0x4,
@@ -405,6 +406,10 @@ static struct clk_regmap *lcc_ipq806x_clks[] = {
 	[AHBIX_CLK] = &ahbix_clk.clkr,
 };
 
+static const struct qcom_reset_map lcc_ipq806x_resets[] = {
+	[LCC_PCM_RESET] = { 0x54, 13 },
+};
+
 static const struct regmap_config lcc_ipq806x_regmap_config = {
 	.reg_bits	= 32,
 	.reg_stride	= 4,
@@ -417,6 +422,8 @@ static const struct qcom_cc_desc lcc_ipq806x_desc = {
 	.config = &lcc_ipq806x_regmap_config,
 	.clks = lcc_ipq806x_clks,
 	.num_clks = ARRAY_SIZE(lcc_ipq806x_clks),
+	.resets = lcc_ipq806x_resets,
+	.num_resets = ARRAY_SIZE(lcc_ipq806x_resets),
 };
 
 static const struct of_device_id lcc_ipq806x_match_table[] = {
-- 
2.36.1

[PATCH 3/3] clk: qcom: lcc-ipq806x: convert to parent data

[Christian 'Ansuel' Marangi]

Convert lcc-ipq806x driver to parent_data API.

Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
---
 drivers/clk/qcom/lcc-ipq806x.c | 79 +++++++++++++++++++---------------
 1 file changed, 44 insertions(+), 35 deletions(-)

diff --git a/drivers/clk/qcom/lcc-ipq806x.c b/drivers/clk/qcom/lcc-ipq806x.c
index ba90bebba597..c07ca8dc6e3a 100644
--- a/drivers/clk/qcom/lcc-ipq806x.c
+++ b/drivers/clk/qcom/lcc-ipq806x.c
@@ -24,6 +24,10 @@
 #include "clk-regmap-mux.h"
 #include "reset.h"
 
+static const struct clk_parent_data gcc_pxo[] = {
+	{ .fw_name = "pxo", .name = "pxo" },
+};
+
 static struct clk_pll pll4 = {
 	.l_reg = 0x4,
 	.m_reg = 0x8,
@@ -34,7 +38,7 @@ static struct clk_pll pll4 = {
 	.status_bit = 16,
 	.clkr.hw.init = &(struct clk_init_data){
 		.name = "pll4",
-		.parent_names = (const char *[]){ "pxo" },
+		.parent_data = gcc_pxo,
 		.num_parents = 1,
 		.ops = &clk_pll_ops,
 	},
@@ -64,9 +68,9 @@ static const struct parent_map lcc_pxo_pll4_map[] = {
 	{ P_PLL4, 2 }
 };
 
-static const char * const lcc_pxo_pll4[] = {
-	"pxo",
-	"pll4_vote",
+static const struct clk_parent_data lcc_pxo_pll4[] = {
+	{ .fw_name = "pxo", .name = "pxo" },
+	{ .fw_name = "pll4_vote", .name = "pll4_vote" },
 };
 
 static struct freq_tbl clk_tbl_aif_mi2s[] = {
@@ -131,18 +135,14 @@ static struct clk_rcg mi2s_osr_src = {
 		.enable_mask = BIT(9),
 		.hw.init = &(struct clk_init_data){
 			.name = "mi2s_osr_src",
-			.parent_names = lcc_pxo_pll4,
-			.num_parents = 2,
+			.parent_data = lcc_pxo_pll4,
+			.num_parents = ARRAY_SIZE(lcc_pxo_pll4),
 			.ops = &clk_rcg_ops,
 			.flags = CLK_SET_RATE_GATE,
 		},
 	},
 };
 
-static const char * const lcc_mi2s_parents[] = {
-	"mi2s_osr_src",
-};
-
 static struct clk_branch mi2s_osr_clk = {
 	.halt_reg = 0x50,
 	.halt_bit = 1,
@@ -152,7 +152,9 @@ static struct clk_branch mi2s_osr_clk = {
 		.enable_mask = BIT(17),
 		.hw.init = &(struct clk_init_data){
 			.name = "mi2s_osr_clk",
-			.parent_names = lcc_mi2s_parents,
+			.parent_hws = (const struct clk_hw*[]){
+				&mi2s_osr_src.clkr.hw,
+			},
 			.num_parents = 1,
 			.ops = &clk_branch_ops,
 			.flags = CLK_SET_RATE_PARENT,
@@ -167,7 +169,9 @@ static struct clk_regmap_div mi2s_div_clk = {
 	.clkr = {
 		.hw.init = &(struct clk_init_data){
 			.name = "mi2s_div_clk",
-			.parent_names = lcc_mi2s_parents,
+			.parent_hws = (const struct clk_hw*[]){
+				&mi2s_osr_src.clkr.hw,
+			},
 			.num_parents = 1,
 			.ops = &clk_regmap_div_ops,
 		},
@@ -183,7 +187,9 @@ static struct clk_branch mi2s_bit_div_clk = {
 		.enable_mask = BIT(15),
 		.hw.init = &(struct clk_init_data){
 			.name = "mi2s_bit_div_clk",
-			.parent_names = (const char *[]){ "mi2s_div_clk" },
+			.parent_hws = (const struct clk_hw*[]){
+				&mi2s_div_clk.clkr.hw,
+			},
 			.num_parents = 1,
 			.ops = &clk_branch_ops,
 			.flags = CLK_SET_RATE_PARENT,
@@ -191,6 +197,10 @@ static struct clk_branch mi2s_bit_div_clk = {
 	},
 };
 
+static const struct clk_parent_data lcc_mi2s_bit_div_codec_clk[] = {
+	{ .hw = &mi2s_bit_div_clk.clkr.hw, },
+	{ .fw_name = "mi2s_codec_clk", .name = "mi2s_codec_clk" },
+};
 
 static struct clk_regmap_mux mi2s_bit_clk = {
 	.reg = 0x48,
@@ -199,11 +209,8 @@ static struct clk_regmap_mux mi2s_bit_clk = {
 	.clkr = {
 		.hw.init = &(struct clk_init_data){
 			.name = "mi2s_bit_clk",
-			.parent_names = (const char *[]){
-				"mi2s_bit_div_clk",
-				"mi2s_codec_clk",
-			},
-			.num_parents = 2,
+			.parent_data = lcc_mi2s_bit_div_codec_clk,
+			.num_parents = ARRAY_SIZE(lcc_mi2s_bit_div_codec_clk),
 			.ops = &clk_regmap_mux_closest_ops,
 			.flags = CLK_SET_RATE_PARENT,
 		},
@@ -245,8 +252,8 @@ static struct clk_rcg pcm_src = {
 		.enable_mask = BIT(9),
 		.hw.init = &(struct clk_init_data){
 			.name = "pcm_src",
-			.parent_names = lcc_pxo_pll4,
-			.num_parents = 2,
+			.parent_data = lcc_pxo_pll4,
+			.num_parents = ARRAY_SIZE(lcc_pxo_pll4),
 			.ops = &clk_rcg_ops,
 			.flags = CLK_SET_RATE_GATE,
 		},
@@ -262,7 +269,9 @@ static struct clk_branch pcm_clk_out = {
 		.enable_mask = BIT(11),
 		.hw.init = &(struct clk_init_data){
 			.name = "pcm_clk_out",
-			.parent_names = (const char *[]){ "pcm_src" },
+			.parent_hws = (const struct clk_hw*[]){
+				&pcm_src.clkr.hw,
+			},
 			.num_parents = 1,
 			.ops = &clk_branch_ops,
 			.flags = CLK_SET_RATE_PARENT,
@@ -270,6 +279,11 @@ static struct clk_branch pcm_clk_out = {
 	},
 };
 
+static const struct clk_parent_data lcc_pcm_clk_out_codec_clk[] = {
+	{ .hw = &pcm_clk_out.clkr.hw, },
+	{ .fw_name = "pcm_codec_clk", .name = "pcm_codec_clk" },
+};
+
 static struct clk_regmap_mux pcm_clk = {
 	.reg = 0x54,
 	.shift = 10,
@@ -277,11 +291,8 @@ static struct clk_regmap_mux pcm_clk = {
 	.clkr = {
 		.hw.init = &(struct clk_init_data){
 			.name = "pcm_clk",
-			.parent_names = (const char *[]){
-				"pcm_clk_out",
-				"pcm_codec_clk",
-			},
-			.num_parents = 2,
+			.parent_data = lcc_pcm_clk_out_codec_clk,
+			.num_parents = ARRAY_SIZE(lcc_pcm_clk_out_codec_clk),
 			.ops = &clk_regmap_mux_closest_ops,
 			.flags = CLK_SET_RATE_PARENT,
 		},
@@ -325,18 +336,14 @@ static struct clk_rcg spdif_src = {
 		.enable_mask = BIT(9),
 		.hw.init = &(struct clk_init_data){
 			.name = "spdif_src",
-			.parent_names = lcc_pxo_pll4,
-			.num_parents = 2,
+			.parent_data = lcc_pxo_pll4,
+			.num_parents = ARRAY_SIZE(lcc_pxo_pll4),
 			.ops = &clk_rcg_ops,
 			.flags = CLK_SET_RATE_GATE,
 		},
 	},
 };
 
-static const char * const lcc_spdif_parents[] = {
-	"spdif_src",
-};
-
 static struct clk_branch spdif_clk = {
 	.halt_reg = 0xd4,
 	.halt_bit = 1,
@@ -346,7 +353,9 @@ static struct clk_branch spdif_clk = {
 		.enable_mask = BIT(12),
 		.hw.init = &(struct clk_init_data){
 			.name = "spdif_clk",
-			.parent_names = lcc_spdif_parents,
+			.parent_hws = (const struct clk_hw*[]){
+				&spdif_src.clkr.hw,
+			},
 			.num_parents = 1,
 			.ops = &clk_branch_ops,
 			.flags = CLK_SET_RATE_PARENT,
@@ -384,8 +393,8 @@ static struct clk_rcg ahbix_clk = {
 		.enable_mask = BIT(11),
 		.hw.init = &(struct clk_init_data){
 			.name = "ahbix",
-			.parent_names = lcc_pxo_pll4,
-			.num_parents = 2,
+			.parent_data = lcc_pxo_pll4,
+			.num_parents = ARRAY_SIZE(lcc_pxo_pll4),
 			.ops = &clk_rcg_lcc_ops,
 		},
 	},
-- 
2.36.1

Re: [PATCH 1/3] dt-bindings: clock: add pcm reset for ipq806x lcc

[Ansuel Smith]

On Wed, Jun 15, 2022 at 10:43:10AM -0700, Krzysztof Kozlowski wrote:
> On 15/06/2022 09:34, Christian 'Ansuel' Marangi wrote:
> > Add pcm reset define for ipq806x lcc.
> > 
> > Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
> To prevent any confusion about identities (we have strict rules about
> these), I need to ask - who uses this email address?
> 
> https://lore.kernel.org/all/?q=ansuelsmth%40gmail.com
> 
> Best regards,
> Krzysztof

Same person. Started using extended name, wanted to do this change from
a long time but all the patch were already pushed so I couldn't change
it since they were already proposed and on the various mailing list.

-- 
	Ansuel

Re: [PATCH 1/3] dt-bindings: clock: add pcm reset for ipq806x lcc

[Ansuel Smith]

On Wed, Jun 15, 2022 at 10:50:17AM -0700, Krzysztof Kozlowski wrote:
> On 15/06/2022 09:53, Ansuel Smith wrote:
> > On Wed, Jun 15, 2022 at 10:43:10AM -0700, Krzysztof Kozlowski wrote:
> >> On 15/06/2022 09:34, Christian 'Ansuel' Marangi wrote:
> >>> Add pcm reset define for ipq806x lcc.
> >>>
> >>> Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
> >> To prevent any confusion about identities (we have strict rules about
> >> these), I need to ask - who uses this email address?
> >>
> >> https://lore.kernel.org/all/?q=ansuelsmth%40gmail.com
> >>
> >> Best regards,
> >> Krzysztof
> > 
> > Same person. Started using extended name, wanted to do this change from
> > a long time but all the patch were already pushed so I couldn't change
> > it since they were already proposed and on the various mailing list.
> 
> Previously "Ansuel Smith" was used entirely, without any parts of this
> name. Here 'Ansuel' appears in quotes, which usually is used for nicknames.
> 
> Is "Ansuel Smith" your real name or a nickname? What do you mean by
> "extended name"?
>

Ansuel is second name. Smith is not real... (sorry)
So with extendend name I mean full name + second name that is
Christian Ansuel Marangi.

Honestly it's a very stupid mistake by me not using the full name from
the start.

> 
> Best regards,
> Krzysztof

-- 
	Ansuel

Re: [PATCH 1/3] dt-bindings: clock: add pcm reset for ipq806x lcc

[Krzysztof Kozlowski]

On 15/06/2022 09:34, Christian 'Ansuel' Marangi wrote:
> Add pcm reset define for ipq806x lcc.
> 
> Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
To prevent any confusion about identities (we have strict rules about
these), I need to ask - who uses this email address?

https://lore.kernel.org/all/?q=ansuelsmth%40gmail.com

Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: clock: add pcm reset for ipq806x lcc

[Krzysztof Kozlowski]

On 15/06/2022 09:53, Ansuel Smith wrote:
> On Wed, Jun 15, 2022 at 10:43:10AM -0700, Krzysztof Kozlowski wrote:
>> On 15/06/2022 09:34, Christian 'Ansuel' Marangi wrote:
>>> Add pcm reset define for ipq806x lcc.
>>>
>>> Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
>> To prevent any confusion about identities (we have strict rules about
>> these), I need to ask - who uses this email address?
>>
>> https://lore.kernel.org/all/?q=ansuelsmth%40gmail.com
>>
>> Best regards,
>> Krzysztof
> 
> Same person. Started using extended name, wanted to do this change from
> a long time but all the patch were already pushed so I couldn't change
> it since they were already proposed and on the various mailing list.

Previously "Ansuel Smith" was used entirely, without any parts of this
name. Here 'Ansuel' appears in quotes, which usually is used for nicknames.

Is "Ansuel Smith" your real name or a nickname? What do you mean by
"extended name"?


Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: clock: add pcm reset for ipq806x lcc

[Stephen Boyd]

Quoting Ansuel Smith (2022-06-15 10:04:40)
> 
> Ansuel is second name. Smith is not real... (sorry)
> So with extendend name I mean full name + second name that is
> Christian Ansuel Marangi.
> 
> Honestly it's a very stupid mistake by me not using the full name from
> the start.

Please send a patch to the .mailmap file to fix up the name.

Re: [PATCH 1/3] dt-bindings: clock: add pcm reset for ipq806x lcc

[Krzysztof Kozlowski]

On 15/06/2022 10:04, Ansuel Smith wrote:
> On Wed, Jun 15, 2022 at 10:50:17AM -0700, Krzysztof Kozlowski wrote:
>> On 15/06/2022 09:53, Ansuel Smith wrote:
>>> On Wed, Jun 15, 2022 at 10:43:10AM -0700, Krzysztof Kozlowski wrote:
>>>> On 15/06/2022 09:34, Christian 'Ansuel' Marangi wrote:
>>>>> Add pcm reset define for ipq806x lcc.
>>>>>
>>>>> Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
>>>> To prevent any confusion about identities (we have strict rules about
>>>> these), I need to ask - who uses this email address?
>>>>
>>>> https://lore.kernel.org/all/?q=ansuelsmth%40gmail.com
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Same person. Started using extended name, wanted to do this change from
>>> a long time but all the patch were already pushed so I couldn't change
>>> it since they were already proposed and on the various mailing list.
>>
>> Previously "Ansuel Smith" was used entirely, without any parts of this
>> name. Here 'Ansuel' appears in quotes, which usually is used for nicknames.
>>
>> Is "Ansuel Smith" your real name or a nickname? What do you mean by
>> "extended name"?
>>
> 
> Ansuel is second name. Smith is not real... (sorry)
> So with extendend name I mean full name + second name that is
> Christian Ansuel Marangi.
> 
> Honestly it's a very stupid mistake by me not using the full name from
> the start.

Not-real names are no accepted [1] and since we cannot validate this, we
trust. Quite a lot in our process depends on trust. Once trust is gone,
it's not easy to get it back... Worth watching - Trust and the Linux
development model; Greg KH [2].

Anyway I have no clue which identity to trust...


[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=certificate#sign-your-work-the-developer-s-certificate-of-origin

[2] https://www.youtube.com/watch?v=nhJqaZT94z0&t=7044s&ab_channel=hupstream

Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: clock: add pcm reset for ipq806x lcc

[Ansuel Smith]

On Wed, Jun 15, 2022 at 01:53:44PM -0700, Krzysztof Kozlowski wrote:
> On 15/06/2022 10:04, Ansuel Smith wrote:
> > On Wed, Jun 15, 2022 at 10:50:17AM -0700, Krzysztof Kozlowski wrote:
> >> On 15/06/2022 09:53, Ansuel Smith wrote:
> >>> On Wed, Jun 15, 2022 at 10:43:10AM -0700, Krzysztof Kozlowski wrote:
> >>>> On 15/06/2022 09:34, Christian 'Ansuel' Marangi wrote:
> >>>>> Add pcm reset define for ipq806x lcc.
> >>>>>
> >>>>> Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
> >>>> To prevent any confusion about identities (we have strict rules about
> >>>> these), I need to ask - who uses this email address?
> >>>>
> >>>> https://lore.kernel.org/all/?q=ansuelsmth%40gmail.com
> >>>>
> >>>> Best regards,
> >>>> Krzysztof
> >>>
> >>> Same person. Started using extended name, wanted to do this change from
> >>> a long time but all the patch were already pushed so I couldn't change
> >>> it since they were already proposed and on the various mailing list.
> >>
> >> Previously "Ansuel Smith" was used entirely, without any parts of this
> >> name. Here 'Ansuel' appears in quotes, which usually is used for nicknames.
> >>
> >> Is "Ansuel Smith" your real name or a nickname? What do you mean by
> >> "extended name"?
> >>
> > 
> > Ansuel is second name. Smith is not real... (sorry)
> > So with extendend name I mean full name + second name that is
> > Christian Ansuel Marangi.
> > 
> > Honestly it's a very stupid mistake by me not using the full name from
> > the start.
> 
> Not-real names are no accepted [1] and since we cannot validate this, we
> trust. Quite a lot in our process depends on trust. Once trust is gone,
> it's not easy to get it back... Worth watching - Trust and the Linux
> development model; Greg KH [2].
> 
> Anyway I have no clue which identity to trust...
>

Again it's the same person, just a change in the name but I see your
point. As suggested in the other patch I will just change to Christian
Marangi sadly if necessary, hoping I regain trust in the future.

Just as an info, as I pushed also other patch and some are with various
revision, how to handle the Sob? Change it and put an alert in the
version changelog or should I keep the old one?

Again sorry for the mess but it had to be done, didn't think it caused
that much problems :(

> 
> [1]
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=certificate#sign-your-work-the-developer-s-certificate-of-origin
> 
> [2] https://www.youtube.com/watch?v=nhJqaZT94z0&t=7044s&ab_channel=hupstream
> 
> Best regards,
> Krzysztof

(if the concern is with understanding if I'm not stealing the identity
of someone else, there must be a way to prove that, on github I sign
every commit with the PGP key and I updated the name also there.)

-- 
	Ansuel