From: Jan Kiszka <jan.kiszka@siemens.com>
To: Du Changbin <changbin.du@gmail.com>, kbingham@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/gdb: fix lx-version for gdb 7.3-
Date: Wed, 17 Oct 2018 08:56:44 +0200 [thread overview]
Message-ID: <62b6aff8-8ca2-7d6c-d810-64d10a25f2d4@siemens.com> (raw)
In-Reply-To: <20181017023652.6867-1-changbin.du@gmail.com>
On 17.10.18 04:36, Du Changbin wrote:
> For gdb version less than 7.3, lx-version only one character.
^^^ prints?
> (gdb) lx-version
> L(gdb)
>
> This can be fixed by casting 'linux_banner' as (char *).
> (gdb) lx-version
> Linux version 4.19.0-rc1+ (changbin@acer) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018
>
> gdb 7.4 seems to be no such issue.
>
> Signed-off-by: Du Changbin <changbin.du@gmail.com>
> ---
> scripts/gdb/linux/proc.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
> index 086d27223c0c..0aebd7565b03 100644
> --- a/scripts/gdb/linux/proc.py
> +++ b/scripts/gdb/linux/proc.py
> @@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
>
> def invoke(self, arg, from_tty):
> # linux_banner should contain a newline
> - gdb.write(gdb.parse_and_eval("linux_banner").string())
> + gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())
>
> LxVersion()
>
>
Looks good to me otherwise.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2018-10-17 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 2:36 [PATCH] scripts/gdb: fix lx-version for gdb 7.3- Du Changbin
2018-10-17 6:56 ` Jan Kiszka [this message]
2018-10-17 13:39 ` Changbin Du
2018-10-17 12:31 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b6aff8-8ca2-7d6c-d810-64d10a25f2d4@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=changbin.du@gmail.com \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).