linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Wu <david.wu@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>, linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	shawn.lin@rock-chips.com,
	"Heiko Stuebner" <heiko.stuebner@bq.com>,
	许剑群 <jay.xu@rock-chips.com>
Subject: Re: [PATCH 1/2] pinctrl: rockchip: allow specifying the regmap location for pin-routes
Date: Wed, 14 Nov 2018 20:15:06 +0800	[thread overview]
Message-ID: <62b7937e-0d7e-d142-285e-6dc15e6f5822@rock-chips.com> (raw)
In-Reply-To: <20181111210047.30375-1-heiko@sntech.de>

Hi Heiko,

在 2018/11/12 上午5:00, Heiko Stuebner 写道:
> From: Heiko Stuebner<heiko.stuebner@bq.com>
> 
> Right now we expect the pin-rounting settings to be in the same area
> as the iomux setting itself. And while that seems to be true for all
> newer Rockchip socs, back in the wild west days of old this wasn't true.
> 
> Nowadays pin settings in the GRF normally stay in the GRF and the same
> is true for pins configured from PMU registers. But old socs like the
> rk3188 really sprinkle pin settings somewhat randomly through both
> for its bank0.
> 
> Therefore add the option to specify a location for the route setting,
> so that we can map older socs correctly. We'll keep "same" as the
> default, so that we only need to specify a location in the corner-cases
> described above.
> 
> Signed-off-by: Heiko Stuebner<heiko.stuebner@bq.com>

Very good, for the mixed case, really need to do the supplement.

Reviewed-by: David Wu <david.wu@rock-chips.com>


  parent reply	other threads:[~2018-11-14 12:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11 21:00 Heiko Stuebner
2018-11-11 21:00 ` [PATCH 2/2] pinctrl: rockchip: add rk3188 routes to switch between nand and emmc Heiko Stuebner
2018-11-17 12:19   ` Linus Walleij
2018-11-14 12:15 ` David Wu [this message]
2018-11-17 12:18 ` [PATCH 1/2] pinctrl: rockchip: allow specifying the regmap location for pin-routes Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62b7937e-0d7e-d142-285e-6dc15e6f5822@rock-chips.com \
    --to=david.wu@rock-chips.com \
    --cc=heiko.stuebner@bq.com \
    --cc=heiko@sntech.de \
    --cc=jay.xu@rock-chips.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=shawn.lin@rock-chips.com \
    --subject='Re: [PATCH 1/2] pinctrl: rockchip: allow specifying the regmap location for pin-routes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).