archive mirror
 help / color / mirror / Atom feed
From: David Wu <>
To: Heiko Stuebner <>,
	"Heiko Stuebner" <>,
	许剑群 <>
Subject: Re: [PATCH 1/2] pinctrl: rockchip: allow specifying the regmap location for pin-routes
Date: Wed, 14 Nov 2018 20:15:06 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Heiko,

在 2018/11/12 上午5:00, Heiko Stuebner 写道:
> From: Heiko Stuebner<>
> Right now we expect the pin-rounting settings to be in the same area
> as the iomux setting itself. And while that seems to be true for all
> newer Rockchip socs, back in the wild west days of old this wasn't true.
> Nowadays pin settings in the GRF normally stay in the GRF and the same
> is true for pins configured from PMU registers. But old socs like the
> rk3188 really sprinkle pin settings somewhat randomly through both
> for its bank0.
> Therefore add the option to specify a location for the route setting,
> so that we can map older socs correctly. We'll keep "same" as the
> default, so that we only need to specify a location in the corner-cases
> described above.
> Signed-off-by: Heiko Stuebner<>

Very good, for the mixed case, really need to do the supplement.

Reviewed-by: David Wu <>

  parent reply	other threads:[~2018-11-14 12:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11 21:00 Heiko Stuebner
2018-11-11 21:00 ` [PATCH 2/2] pinctrl: rockchip: add rk3188 routes to switch between nand and emmc Heiko Stuebner
2018-11-17 12:19   ` Linus Walleij
2018-11-14 12:15 ` David Wu [this message]
2018-11-17 12:18 ` [PATCH 1/2] pinctrl: rockchip: allow specifying the regmap location for pin-routes Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 1/2] pinctrl: rockchip: allow specifying the regmap location for pin-routes' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).