[PATCH] regmap: permit to set reg_update_bits with bulk implementation

[PATCH] regmap: permit to set reg_update_bits with bulk implementation

[Christian Marangi]

A regmap may still require to set a custom reg_update_bits instead of
relying to the regmap_bus_read/write general function.

Permit to set it in the map if provided by the regmap config.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---

If this is accepted, this is needed for net-next tree so a signed tags
is needed, if it's not a problem.

 drivers/base/regmap/regmap.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 0caa5690c560..fee221c5008c 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -882,6 +882,8 @@ struct regmap *__regmap_init(struct device *dev,
 
 	if (config && config->read && config->write) {
 		map->reg_read  = _regmap_bus_read;
+		if (config->reg_update_bits)
+			map->reg_update_bits = config->reg_update_bits;
 
 		/* Bulk read/write */
 		map->read = config->read;
-- 
2.36.1

Re: [PATCH] regmap: permit to set reg_update_bits with bulk implementation

[Mark Brown]

On Fri, 15 Jul 2022 22:10:32 +0200, Christian Marangi wrote:
> A regmap may still require to set a custom reg_update_bits instead of
> relying to the regmap_bus_read/write general function.
> 
> Permit to set it in the map if provided by the regmap config.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next

Thanks!

[1/1] regmap: permit to set reg_update_bits with bulk implementation
      commit: 739f872e48d47c97fa17a86a7b3356771b75240c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH] regmap: permit to set reg_update_bits with bulk implementation

[Christian Marangi]

On Mon, Jul 18, 2022 at 02:43:46PM +0100, Mark Brown wrote:
> On Fri, 15 Jul 2022 22:10:32 +0200, Christian Marangi wrote:
> > A regmap may still require to set a custom reg_update_bits instead of
> > relying to the regmap_bus_read/write general function.
> > 
> > Permit to set it in the map if provided by the regmap config.
> > 
> > 
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next
> 
> Thanks!
> 
> [1/1] regmap: permit to set reg_update_bits with bulk implementation
>       commit: 739f872e48d47c97fa17a86a7b3356771b75240c
> 

Hi,
thanks, assuming everything went smooth with the merge to linux-next and
no problems arise, can you provide a signed tag?

This is needed for a net-next series that is currently in RFC state as
it does depends on this.

(I had this problem before and it was said that in this kind of
situation I had to ask for a signed tag to merge the related patch in
net-next branch)

Thanks for the help!

-- 
	Ansuel

Re: [PATCH] regmap: permit to set reg_update_bits with bulk implementation

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

On Mon, Jul 18, 2022 at 03:48:52PM +0200, Christian Marangi wrote:

> thanks, assuming everything went smooth with the merge to linux-next and
> no problems arise, can you provide a signed tag?

> This is needed for a net-next series that is currently in RFC state as
> it does depends on this.

> (I had this problem before and it was said that in this kind of
> situation I had to ask for a signed tag to merge the related patch in
> net-next branch)

Oh, it would have been good to know about this when reviewing the patch
rather than after the fact - since this hadn't been mentioned it's now
applied on the main development branch with everything that's going into
the next release rather than on a separate branch for easy merging
elsewhere.  How urgent is this, given that the merge window is likely to
open at the weekend so this'll get sent to Linus at that point - is the
driver otherwise near merging?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] regmap: permit to set reg_update_bits with bulk implementation

[Christian Marangi]

On Mon, Jul 18, 2022 at 03:42:06PM +0100, Mark Brown wrote:
> On Mon, Jul 18, 2022 at 03:48:52PM +0200, Christian Marangi wrote:
> 
> > thanks, assuming everything went smooth with the merge to linux-next and
> > no problems arise, can you provide a signed tag?
> 
> > This is needed for a net-next series that is currently in RFC state as
> > it does depends on this.
> 
> > (I had this problem before and it was said that in this kind of
> > situation I had to ask for a signed tag to merge the related patch in
> > net-next branch)
> 
> Oh, it would have been good to know about this when reviewing the patch
> rather than after the fact - since this hadn't been mentioned it's now
> applied on the main development branch with everything that's going into
> the next release rather than on a separate branch for easy merging
> elsewhere.  How urgent is this, given that the merge window is likely to
> open at the weekend so this'll get sent to Linus at that point - is the
> driver otherwise near merging?

Ohh sorry, I was too generic in the patch comments and didn't mention it
was an actual dependency.

It's not too urgent, (I assume) but it was said that it was preferrable
to have the changes done in 2 weeks window (the one in net-next about
the working driver). Will ask on net-next and give you news ASAP.

-- 
	Ansuel

Re: [PATCH] regmap: permit to set reg_update_bits with bulk implementation

[Christian Marangi]

On Mon, Jul 18, 2022 at 04:44:23PM +0200, Christian Marangi wrote:
> On Mon, Jul 18, 2022 at 03:42:06PM +0100, Mark Brown wrote:
> > On Mon, Jul 18, 2022 at 03:48:52PM +0200, Christian Marangi wrote:
> > 
> > > thanks, assuming everything went smooth with the merge to linux-next and
> > > no problems arise, can you provide a signed tag?
> > 
> > > This is needed for a net-next series that is currently in RFC state as
> > > it does depends on this.
> > 
> > > (I had this problem before and it was said that in this kind of
> > > situation I had to ask for a signed tag to merge the related patch in
> > > net-next branch)
> > 
> > Oh, it would have been good to know about this when reviewing the patch
> > rather than after the fact - since this hadn't been mentioned it's now
> > applied on the main development branch with everything that's going into
> > the next release rather than on a separate branch for easy merging
> > elsewhere.  How urgent is this, given that the merge window is likely to
> > open at the weekend so this'll get sent to Linus at that point - is the
> > driver otherwise near merging?
> 
> Ohh sorry, I was too generic in the patch comments and didn't mention it
> was an actual dependency.
> 
> It's not too urgent, (I assume) but it was said that it was preferrable
> to have the changes done in 2 weeks window (the one in net-next about
> the working driver). Will ask on net-next and give you news ASAP.
> 

Hi Mark,
sorry for the delay, I pointed out this problem with net-next and we
decided to adopt a workaround so this is not urgent anymore and we can
wait the merge window to have this change in net-next.

The required code will be updated later when this change is merged.

-- 
	Ansuel