linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Matheus Castello <matheus@castello.eng.br>
Cc: manivannan.sadhasivam@linaro.org, mark.rutland@arm.com,
	robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: Add vendor prefix for Caninos Loucos
Date: Sat, 7 Mar 2020 13:34:11 +0100	[thread overview]
Message-ID: <62e115af-9d8c-572a-a400-91bdef9d9292@suse.de> (raw)
In-Reply-To: <20200307002453.350430-2-matheus@castello.eng.br>

Hi Matheus,

Am 07.03.20 um 01:24 schrieb Matheus Castello:
> The Caninos Loucos Program develops Single Board Computers with an open
> structure. The Program wants to form a community of developers to use
> the IoT technology and disseminate the learning of embedded systems in

I would suggest "IoT technologies" without "the".

> Brazil.
> 
> The boards are designed and manufactured by LSI-TEC NPO.
> 
> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> ---
>   Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 9e67944bec9c..3e974dd563cf 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -167,6 +167,8 @@ patternProperties:
>       description: Calxeda
>     "^capella,.*":
>       description: Capella Microsystems, Inc
> +  "^caninos,.*":
> +    description: Caninos Loucos LSI-TEC NPO

Alphabetical order: n goes before p.

I'm confused by the description... Either this Caninos Loucos is an 
independent vendor and gets its own prefix, or it's LSI-Tec and uses 
something like lsi-tec,caninosloucos-foo. Please clarify commit message 
and/or description line, at least by inserting something like "program 
by", "brand by" or the like rather than just concatenating names. Maybe 
compare UDOO by SECO. Is caninos,foo unique enough or should it be 
caninosloucos,foo? (crazy canines?)

Note that I usually attempt to CC the organizations I'm assigning a 
vendor prefix for. Do you represent them or coordinated with them?

Regards,
Andreas

>     "^cascoda,.*":
>       description: Cascoda, Ltd.
>     "^catalyst,.*":

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

  reply	other threads:[~2020-03-07 12:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 20:15 [PATCH v1 0/2] Add Caninos Loucos Labrador SoM and Base Board Device Tree Matheus Castello
2020-02-27 20:15 ` [PATCH v1 1/2] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello
2020-02-29 10:43   ` Manivannan Sadhasivam
2020-03-07  0:24     ` [PATCH v2 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree Matheus Castello
2020-03-07  0:24       ` [PATCH v2 1/3] dt-bindings: Add vendor prefix for Caninos Loucos Matheus Castello
2020-03-07 12:34         ` Andreas Färber [this message]
2020-03-11  4:04           ` Matheus Castello
2020-03-07  0:24       ` [PATCH v2 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello
2020-03-07  0:24       ` [PATCH v2 3/3] ARM: dts: Add " Matheus Castello
2020-03-20  3:51     ` [PATCH v3 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree Matheus Castello
2020-03-20  3:51       ` [PATCH v3 1/3] dt-bindings: Add vendor prefix for Caninos Loucos Matheus Castello
2020-03-30 23:23         ` Rob Herring
2020-04-26 10:53         ` Andreas Färber
2020-03-20  3:51       ` [PATCH v3 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello
2020-03-30 23:23         ` Rob Herring
2020-04-26 11:50         ` Andreas Färber
2020-03-20  3:51       ` [PATCH v3 3/3] ARM: dts: Add " Matheus Castello
2020-04-05  6:51         ` Manivannan Sadhasivam
2020-04-23 15:20           ` Matheus Castello
2020-04-26 11:58             ` Andreas Färber
2020-04-26 16:27               ` Matheus Castello
2020-04-26 16:58                 ` [PATCH v4 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree Matheus Castello
2020-04-26 16:58                   ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Caninos Loucos Matheus Castello
2020-04-26 16:58                   ` [PATCH v4 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello
2020-04-27 21:32                     ` Rob Herring
2020-04-26 16:58                   ` [PATCH v4 3/3] ARM: dts: Add " Matheus Castello
2020-02-27 20:15 ` [PATCH v1 2/2] " Matheus Castello
2020-02-29 10:42   ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62e115af-9d8c-572a-a400-91bdef9d9292@suse.de \
    --to=afaerber@suse.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mark.rutland@arm.com \
    --cc=matheus@castello.eng.br \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).