From: "Andreas Färber" <afaerber@suse.de>
To: Matheus Castello <matheus@castello.eng.br>
Cc: manivannan.sadhasivam@linaro.org, mark.rutland@arm.com,
robh+dt@kernel.org, edgar.righi@lsitec.org.br,
igor.lima@lsitec.org.br, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-actions@lists.infradead.org
Subject: Re: [PATCH v3 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador
Date: Sun, 26 Apr 2020 13:50:24 +0200 [thread overview]
Message-ID: <99c5fa14-cc2d-3692-fc6e-8e3fa77c5ab0@suse.de> (raw)
In-Reply-To: <20200320035104.26139-3-matheus@castello.eng.br>
+ linux-actions
Am 20.03.20 um 04:51 schrieb Matheus Castello:
> Update the documentation to add the Caninos Loucos Labrador. Labrador
> project consists of a computer on module based on the Actions Semi S500
> processor and the Labrador base board.
>
> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> ---
> Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
> index ace3fdaa8396..1b131ceb884a 100644
> --- a/Documentation/devicetree/bindings/arm/actions.yaml
> +++ b/Documentation/devicetree/bindings/arm/actions.yaml
> @@ -24,6 +24,11 @@ properties:
> - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
> - const: lemaker,guitar
> - const: actions,s500
> + - items:
> + - enum:
> + - caninos,labrador-bb # Caninos Loucos Labrador Base Board
> + - const: caninos,labrador
> + - const: actions,s500
>
> # The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC.
> - items:
Now that you chose to stick with caninos rather than lsi prefix, the
sort order compared to lemaker remains wrong.
Looking at https://caninosloucos.org/en/labrador-en/ there's a "CORE
BOARD V2.0" and a "BASE BOARD M V1.0".
Assuming the v2 is not software-relevant, shouldn't the M be reflected
in the compatible string? For example, "caninos,labrador-core" and
"caninos,labrador-m"? You're free to use -bb-m of course, but no need to
copy LeMaker -bb naming for your board. What does your PCB say?
Also note that other recent bindings have been using a description
attribute - not sure whether we can apply that a) to the SoM and b) to
the base board here. Please compare other in-tree bindings.
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2020-04-26 11:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 20:15 [PATCH v1 0/2] Add Caninos Loucos Labrador SoM and Base Board Device Tree Matheus Castello
2020-02-27 20:15 ` [PATCH v1 1/2] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello
2020-02-29 10:43 ` Manivannan Sadhasivam
2020-03-07 0:24 ` [PATCH v2 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree Matheus Castello
2020-03-07 0:24 ` [PATCH v2 1/3] dt-bindings: Add vendor prefix for Caninos Loucos Matheus Castello
2020-03-07 12:34 ` Andreas Färber
2020-03-11 4:04 ` Matheus Castello
2020-03-07 0:24 ` [PATCH v2 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello
2020-03-07 0:24 ` [PATCH v2 3/3] ARM: dts: Add " Matheus Castello
2020-03-20 3:51 ` [PATCH v3 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree Matheus Castello
2020-03-20 3:51 ` [PATCH v3 1/3] dt-bindings: Add vendor prefix for Caninos Loucos Matheus Castello
2020-03-30 23:23 ` Rob Herring
2020-04-26 10:53 ` Andreas Färber
2020-03-20 3:51 ` [PATCH v3 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello
2020-03-30 23:23 ` Rob Herring
2020-04-26 11:50 ` Andreas Färber [this message]
2020-03-20 3:51 ` [PATCH v3 3/3] ARM: dts: Add " Matheus Castello
2020-04-05 6:51 ` Manivannan Sadhasivam
2020-04-23 15:20 ` Matheus Castello
2020-04-26 11:58 ` Andreas Färber
2020-04-26 16:27 ` Matheus Castello
2020-04-26 16:58 ` [PATCH v4 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree Matheus Castello
2020-04-26 16:58 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Caninos Loucos Matheus Castello
2020-04-26 16:58 ` [PATCH v4 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello
2020-04-27 21:32 ` Rob Herring
2020-04-26 16:58 ` [PATCH v4 3/3] ARM: dts: Add " Matheus Castello
2020-02-27 20:15 ` [PATCH v1 2/2] " Matheus Castello
2020-02-29 10:42 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99c5fa14-cc2d-3692-fc6e-8e3fa77c5ab0@suse.de \
--to=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=edgar.righi@lsitec.org.br \
--cc=igor.lima@lsitec.org.br \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=matheus@castello.eng.br \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).