* [PATCH] f2fs: cleanup the code in build_sit_entries.
@ 2019-08-05 11:13 Lihong Kou
2019-08-05 13:13 ` [f2fs-dev] " Chao Yu
0 siblings, 1 reply; 2+ messages in thread
From: Lihong Kou @ 2019-08-05 11:13 UTC (permalink / raw)
To: yuchao0, jaegeuk; +Cc: fangwei1, linux-f2fs-devel, linux-kernel, koulihong
We do not need to set the SBI_NEED_FSCK flag in the error paths, if we
return error here, we will not update the checkpoint flag, so the code
is useless, just remove it.
Signed-off-by: Lihong Kou <koulihong@huawei.com>
---
fs/f2fs/segment.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index a661ac3..90e2579 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -4161,7 +4161,6 @@ static int build_sit_entries(struct f2fs_sb_info *sbi)
if (start >= MAIN_SEGS(sbi)) {
f2fs_err(sbi, "Wrong journal entry on segno %u",
start);
- set_sbi_flag(sbi, SBI_NEED_FSCK);
err = -EFSCORRUPTED;
break;
}
@@ -4201,7 +4200,6 @@ static int build_sit_entries(struct f2fs_sb_info *sbi)
if (!err && total_node_blocks != valid_node_count(sbi)) {
f2fs_err(sbi, "SIT is corrupted node# %u vs %u",
total_node_blocks, valid_node_count(sbi));
- set_sbi_flag(sbi, SBI_NEED_FSCK);
err = -EFSCORRUPTED;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: cleanup the code in build_sit_entries.
2019-08-05 11:13 [PATCH] f2fs: cleanup the code in build_sit_entries Lihong Kou
@ 2019-08-05 13:13 ` Chao Yu
0 siblings, 0 replies; 2+ messages in thread
From: Chao Yu @ 2019-08-05 13:13 UTC (permalink / raw)
To: Lihong Kou, yuchao0, jaegeuk; +Cc: linux-kernel, fangwei1, linux-f2fs-devel
On 2019-8-5 19:13, Lihong Kou wrote:
> We do not need to set the SBI_NEED_FSCK flag in the error paths, if we
> return error here, we will not update the checkpoint flag, so the code
> is useless, just remove it.
>
> Signed-off-by: Lihong Kou <koulihong@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-05 13:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 11:13 [PATCH] f2fs: cleanup the code in build_sit_entries Lihong Kou
2019-08-05 13:13 ` [f2fs-dev] " Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).