From: Linus Walleij <linus.ml.walleij@gmail.com>
To: jassi brar <jassisinghbrar@gmail.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>,
dan.j.williams@intel.com, kyungmin.park@samsung.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH v2] PL330: Add PL330 DMA controller driver
Date: Thu, 25 Mar 2010 16:20:55 +0100 [thread overview]
Message-ID: <63386a3d1003250820x3cf81000i9d27e95c755b9ca8@mail.gmail.com> (raw)
In-Reply-To: <1b68c6791003250517y4e2789baoe147e5982c363682@mail.gmail.com>
2010/3/25 jassi brar <jassisinghbrar@gmail.com>:
> My approach is to write a separate PL330 core driver as the backend which
> can be reused by any DMA API implementer driver. That will avoid
> having two copies of the PL330 driver, among other benefits.
Seems like a rather good approach.
> And if this patch is accepted, there
> _will_ exist two copies of the PL330 driver -- one in drivers/dma/pl330_dmac.c
> and another in arch/arm/plat-samsung/. Only the former will be lying unused
> until some other SoC vendor decided to use PL330, because S3C has come too
> long a way to change its drivers to driver/dma/ API and modify DMA
> drivers for every SoC.
What's wrong with merging them later then? Refactoring FTW.
> I have the pl330-core part almost ready, but i need time to implement
> some _testable_
> implementation of the scheme. If maintainers want to see structure of
> my code, I can
> share it too, but I think I pretty much made it clear.
Why not just post it on the list? I'm curious! Since I'm working on a PrimeCell
DMA API I would love to look at PrimeCell DMA engine drivers.
Yours,
Linus Walleij
next prev parent reply other threads:[~2010-03-25 15:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 3:17 [PATCH v2] PL330: Add PL330 DMA controller driver Joonyoung Shim
2010-03-25 5:34 ` jassi brar
2010-03-25 8:30 ` Linus Walleij
2010-03-25 12:17 ` jassi brar
2010-03-25 15:13 ` Dan Williams
2010-03-25 22:27 ` jassi brar
2010-03-25 23:12 ` Dan Williams
2010-03-25 23:59 ` jassi brar
2010-03-26 0:29 ` Kyungmin Park
2010-03-26 0:48 ` jassi brar
2010-03-26 0:54 ` Joonyoung Shim
2010-03-26 1:01 ` jassi brar
2010-03-25 15:20 ` Linus Walleij [this message]
2010-03-25 22:36 ` jassi brar
2010-04-01 5:34 ` jassi brar
2010-04-01 23:23 ` Linus Walleij
2010-04-02 1:38 ` jassi brar
2010-04-17 7:06 ` Kyungmin Park
2010-04-19 1:14 ` jassi brar
2010-03-25 5:44 ` Marc Zyngier
2010-03-25 9:01 ` Joonyoung Shim
2010-03-25 9:32 ` Marc Zyngier
2010-03-25 10:05 ` Joonyoung Shim
2010-03-25 10:32 ` Marc Zyngier
2010-03-25 11:48 ` Joonyoung Shim
2010-03-25 8:26 ` Linus Walleij
2010-03-26 2:08 ` jassi brar
2010-03-31 1:07 ` Ben Dooks
2010-03-31 1:40 ` jassi brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63386a3d1003250820x3cf81000i9d27e95c755b9ca8@mail.gmail.com \
--to=linus.ml.walleij@gmail.com \
--cc=ben-linux@fluff.org \
--cc=dan.j.williams@intel.com \
--cc=jassisinghbrar@gmail.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).