From: Hans de Goede <hdegoede@redhat.com>
To: Jarrett Schultz <jaschultzms@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Gross <markgross@kernel.org>,
Maximilian Luz <luzmaximilian@gmail.com>
Cc: linux-arm-msm@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Felipe Balbi <balbi@kernel.org>,
Jarrett Schultz <jaschultz@microsoft.com>
Subject: Re: [PATCH 2/5] platform: surface: Propagate ACPI Dependency
Date: Fri, 3 Dec 2021 10:59:12 +0100 [thread overview]
Message-ID: <639583df-a54a-eb9b-91ad-a60612a930b0@redhat.com> (raw)
In-Reply-To: <20211202191630.12450-3-jaschultz@microsoft.com>
Hi Jarett,
On 12/2/21 20:16, Jarrett Schultz wrote:
> Since the Surface XBL Driver does not depend on ACPI, the
> platform/surface directory as a whole no longer depends on ACPI. With
> respect to this, the ACPI dependency is moved into each config that depends
> on ACPI individually.
>
> Signed-off-by: Jarrett Schultz <jaschultz@microsoft.com>
I think I will already merge this patch into the pdx86 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/
While we are waiting for the rest of the series to get hashed out.
But as already pointed out by Trilok Soni your From: and Signed-off-by
email addresses don't match.
I can fix up the From to match the Signed-off-by while I apply this,
but before I do that I wanted to check with you that setting both
to "Jarrett Schultz <jaschultz@microsoft.com>" is the right thing to do ?
Regards,
Hans
>
> ---
>
> Changes in v3:
> - Further propagated ACPI dependecy to SURFACE_AGGREGATOR
>
> ---
>
> Changes in v2:
> - Created to propagate ACPI dependency
> ---
> drivers/platform/surface/Kconfig | 7 ++++++-
> drivers/platform/surface/aggregator/Kconfig | 1 +
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/surface/Kconfig b/drivers/platform/surface/Kconfig
> index 3105f651614f..5f0578e25f71 100644
> --- a/drivers/platform/surface/Kconfig
> +++ b/drivers/platform/surface/Kconfig
> @@ -5,7 +5,6 @@
>
> menuconfig SURFACE_PLATFORMS
> bool "Microsoft Surface Platform-Specific Device Drivers"
> - depends on ACPI
> default y
> help
> Say Y here to get to see options for platform-specific device drivers
> @@ -30,12 +29,14 @@ config SURFACE3_WMI
>
> config SURFACE_3_BUTTON
> tristate "Power/home/volume buttons driver for Microsoft Surface 3 tablet"
> + depends on ACPI
> depends on KEYBOARD_GPIO && I2C
> help
> This driver handles the power/home/volume buttons on the Microsoft Surface 3 tablet.
>
> config SURFACE_3_POWER_OPREGION
> tristate "Surface 3 battery platform operation region support"
> + depends on ACPI
> depends on I2C
> help
> This driver provides support for ACPI operation
> @@ -126,6 +127,7 @@ config SURFACE_DTX
>
> config SURFACE_GPE
> tristate "Surface GPE/Lid Support Driver"
> + depends on ACPI
> depends on DMI
> help
> This driver marks the GPEs related to the ACPI lid device found on
> @@ -135,6 +137,7 @@ config SURFACE_GPE
>
> config SURFACE_HOTPLUG
> tristate "Surface Hot-Plug Driver"
> + depends on ACPI
> depends on GPIOLIB
> help
> Driver for out-of-band hot-plug event signaling on Microsoft Surface
> @@ -154,6 +157,7 @@ config SURFACE_HOTPLUG
>
> config SURFACE_PLATFORM_PROFILE
> tristate "Surface Platform Profile Driver"
> + depends on ACPI
> depends on SURFACE_AGGREGATOR_REGISTRY
> select ACPI_PLATFORM_PROFILE
> help
> @@ -176,6 +180,7 @@ config SURFACE_PLATFORM_PROFILE
>
> config SURFACE_PRO3_BUTTON
> tristate "Power/home/volume buttons driver for Microsoft Surface Pro 3/4 tablet"
> + depends on ACPI
> depends on INPUT
> help
> This driver handles the power/home/volume buttons on the Microsoft Surface Pro 3/4 tablet.
> diff --git a/drivers/platform/surface/aggregator/Kconfig b/drivers/platform/surface/aggregator/Kconfig
> index fd6dc452f3e8..cab020324256 100644
> --- a/drivers/platform/surface/aggregator/Kconfig
> +++ b/drivers/platform/surface/aggregator/Kconfig
> @@ -4,6 +4,7 @@
> menuconfig SURFACE_AGGREGATOR
> tristate "Microsoft Surface System Aggregator Module Subsystem and Drivers"
> depends on SERIAL_DEV_BUS
> + depends on ACPI
> select CRC_CCITT
> help
> The Surface System Aggregator Module (Surface SAM or SSAM) is an
>
next prev parent reply other threads:[~2021-12-03 9:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 19:16 [PATCH v2 0/5] platform: surface: Introduce Surface XBL Driver Jarrett Schultz
2021-12-02 19:16 ` [PATCH 1/5] dt-bindings: platform: microsoft: Document surface xbl Jarrett Schultz
2021-12-02 20:04 ` Trilok Soni
2021-12-03 23:34 ` Rob Herring
2021-12-02 19:16 ` [PATCH 2/5] platform: surface: Propagate ACPI Dependency Jarrett Schultz
2021-12-03 9:59 ` Hans de Goede [this message]
2021-12-03 17:34 ` [EXTERNAL] " Jarrett Schultz
2021-12-06 21:40 ` Hans de Goede
2022-01-12 7:39 ` Geert Uytterhoeven
2022-01-14 6:20 ` Felipe Balbi
2022-01-14 8:29 ` Geert Uytterhoeven
2022-01-14 8:31 ` Hans de Goede
2022-01-14 8:37 ` Felipe Balbi
2022-01-14 17:11 ` [EXTERNAL] " Jarrett Schultz
2021-12-02 19:16 ` [PATCH 3/5] platform: surface: Add surface xbl Jarrett Schultz
2021-12-02 19:16 ` [PATCH 4/5] arm64: dts: qcom: sm8150: Add imem section Jarrett Schultz
2021-12-02 19:16 ` [PATCH 5/5] arm64: dts: qcom: surface-duo: Add surface xbl Jarrett Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639583df-a54a-eb9b-91ad-a60612a930b0@redhat.com \
--to=hdegoede@redhat.com \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jaschultz@microsoft.com \
--cc=jaschultzms@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).