From: Jarrett Schultz <jaschultz@microsoft.com>
To: Felipe Balbi <balbi@kernel.org>, Hans de Goede <hdegoede@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Jarrett Schultz <jaschultzms@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Gross <markgross@kernel.org>,
Maximilian Luz <luzmaximilian@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH 2/5] platform: surface: Propagate ACPI Dependency
Date: Fri, 14 Jan 2022 17:11:39 +0000 [thread overview]
Message-ID: <DM6PR21MB1323CED3DF2B9604E30FED25A5549@DM6PR21MB1323.namprd21.prod.outlook.com> (raw)
In-Reply-To: <874k664sqz.fsf@kernel.org>
Hi,
> Felipe Balbi <balbi@kernel.org> writes:
>
> Hi,
>
> Hans de Goede <hdegoede@redhat.com> writes:
> > Hi,
> >
> > On 1/14/22 09:29, Geert Uytterhoeven wrote:
> >> Hi Felipe,
> >>
> >> On Fri, Jan 14, 2022 at 7:21 AM Felipe Balbi <balbi@kernel.org> wrote:
> >>> Geert Uytterhoeven <geert@linux-m68k.org> writes:
> >>>> On Mon, Dec 6, 2021 at 4:03 PM Jarrett Schultz
> <jaschultzms@gmail.com> wrote:
> >>>>> Since the Surface XBL Driver does not depend on ACPI, the
> >>>>> platform/surface directory as a whole no longer depends on ACPI.
> >>>>> With respect to this, the ACPI dependency is moved into each
> >>>>> config that depends on ACPI individually.
> >>>>>
> >>>>> Signed-off-by: Jarrett Schultz <jaschultz@microsoft.com>
> >>>>
> >>>> Thanks for your patch, which is now commit 272479928172edf0
> ("platform:
> >>>> surface: Propagate ACPI Dependency").
> >>>>
> >>>>> --- a/drivers/platform/surface/Kconfig
> >>>>> +++ b/drivers/platform/surface/Kconfig
> >>>>> @@ -5,7 +5,6 @@
> >>>>>
> >>>>> menuconfig SURFACE_PLATFORMS
> >>>>> bool "Microsoft Surface Platform-Specific Device Drivers"
> >>>>> - depends on ACPI
> >>>>> default y
> >>>>> help
> >>>>> Say Y here to get to see options for platform-specific
> >>>>> device drivers
> >>>>
> >>>> Without any dependency, all users configuring a kernel are now
> >>>> asked about this. Is there any other platform dependency that can
> >>>> be used instead?
> >>>
> >>> there's probably no symbol that would be true for x86 and arm64
> >>> while being false for everything else. Any ideas?
> >>
> >> depends on ARM64 || X86 || COMPILE_TEST?
> >
> > That sounds reasonable to me, I would be happy to take a patch for that.
>
> fair enough, let's see what Jarrett replies
>
> --
> Balbi
Sounds good to me, I'll include this in the next patch version. Thank you for pointing this out.
-Jarrett
next prev parent reply other threads:[~2022-01-14 17:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 19:16 [PATCH v2 0/5] platform: surface: Introduce Surface XBL Driver Jarrett Schultz
2021-12-02 19:16 ` [PATCH 1/5] dt-bindings: platform: microsoft: Document surface xbl Jarrett Schultz
2021-12-02 20:04 ` Trilok Soni
2021-12-03 23:34 ` Rob Herring
2021-12-02 19:16 ` [PATCH 2/5] platform: surface: Propagate ACPI Dependency Jarrett Schultz
2021-12-03 9:59 ` Hans de Goede
2021-12-03 17:34 ` [EXTERNAL] " Jarrett Schultz
2021-12-06 21:40 ` Hans de Goede
2022-01-12 7:39 ` Geert Uytterhoeven
2022-01-14 6:20 ` Felipe Balbi
2022-01-14 8:29 ` Geert Uytterhoeven
2022-01-14 8:31 ` Hans de Goede
2022-01-14 8:37 ` Felipe Balbi
2022-01-14 17:11 ` Jarrett Schultz [this message]
2021-12-02 19:16 ` [PATCH 3/5] platform: surface: Add surface xbl Jarrett Schultz
2021-12-02 19:16 ` [PATCH 4/5] arm64: dts: qcom: sm8150: Add imem section Jarrett Schultz
2021-12-02 19:16 ` [PATCH 5/5] arm64: dts: qcom: surface-duo: Add surface xbl Jarrett Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR21MB1323CED3DF2B9604E30FED25A5549@DM6PR21MB1323.namprd21.prod.outlook.com \
--to=jaschultz@microsoft.com \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=hdegoede@redhat.com \
--cc=jaschultzms@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).