* "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64
@ 2019-09-03 2:10 Qian Cai
2019-09-03 6:40 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: Qian Cai @ 2019-09-03 2:10 UTC (permalink / raw)
To: Will Deacon
Cc: Robin Murphy, iommu, linux-kernel, Joerg Roedel, linux-arm-kernel
The linux-next commit “iommu/arm-smmu-v3: Rework enabling/disabling of ATS for PCI masters” [1] causes a compilation error when PCI_ATS=n on arm64.
[1] https://lore.kernel.org/linux-iommu/20190820154549.17018-3-will@kernel.org/
drivers/iommu/arm-smmu-v3.c:2325:35: error: no member named 'ats_cap' in 'struct pci_dev'
return !pdev->untrusted && pdev->ats_cap;
~~~~ ^
For example,
Symbol: PCI_ATS [=n]
│ Type : bool
│ Defined at drivers/pci/Kconfig:118
│ Depends on: PCI [=y]
│ Selected by [n]:
│ - PCI_IOV [=n] && PCI [=y]
│ - PCI_PRI [=n] && PCI [=y]│
│ - PCI_PASID [=n] && PCI [=y] │
│ - AMD_IOMMU [=n] && IOMMU_SUPPORT [=y] && X86_64 && PCI [=y] && ACPI [=y]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64
2019-09-03 2:10 "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64 Qian Cai
@ 2019-09-03 6:40 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2019-09-03 6:40 UTC (permalink / raw)
To: Qian Cai
Cc: Robin Murphy, iommu, linux-kernel, Joerg Roedel, linux-arm-kernel
On Mon, Sep 02, 2019 at 10:10:30PM -0400, Qian Cai wrote:
> The linux-next commit “iommu/arm-smmu-v3: Rework enabling/disabling of ATS for PCI masters” [1] causes a compilation error when PCI_ATS=n on arm64.
>
> [1] https://lore.kernel.org/linux-iommu/20190820154549.17018-3-will@kernel.org/
>
> drivers/iommu/arm-smmu-v3.c:2325:35: error: no member named 'ats_cap' in 'struct pci_dev'
> return !pdev->untrusted && pdev->ats_cap;
> ~~~~ ^
>
> For example,
>
> Symbol: PCI_ATS [=n]
> │ Type : bool
> │ Defined at drivers/pci/Kconfig:118
> │ Depends on: PCI [=y]
> │ Selected by [n]:
> │ - PCI_IOV [=n] && PCI [=y]
> │ - PCI_PRI [=n] && PCI [=y]│
> │ - PCI_PASID [=n] && PCI [=y] │
> │ - AMD_IOMMU [=n] && IOMMU_SUPPORT [=y] && X86_64 && PCI [=y] && ACPI [=y]
https://lkml.kernel.org/r/20190903063028.6ryuk5dmaohi2fqa@willie-the-truck
Will
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-03 6:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-03 2:10 "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64 Qian Cai
2019-09-03 6:40 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).