From: Tor Vic <torvic9@mailbox.org>
To: Perry Yuan <perry.yuan@amd.com>,
rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
viresh.kumar@linaro.org, Ray.Huang@amd.com,
gautham.shenoy@amd.com, Borislav.Petkov@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] AMD Pstate Fixes And Enhancements
Date: Wed, 31 Jan 2024 12:36:53 +0100 [thread overview]
Message-ID: <63c2b3d7-083a-4daa-ba40-629b3223a92d@mailbox.org> (raw)
In-Reply-To: <cover.1706690577.git.perry.yuan@amd.com>
On 1/31/24 09:50, Perry Yuan wrote:
> The patch series adds some fixes and enhancements to the AMD pstate driver.
> It enables CPPC v2 for certain processors in the family 17H, as requested
> by TR40 processor users who expect improved performance and lower system
> temperature.
>
> Additionally, it fixes the initialization of nominal_freq for each cpudata
> and changes latency and delay values to be read from platform firmware firstly
> for more accurate timing.
>
> A new quirk is also added for legacy processors that lack CPPC capabilities,
> which caused the pstate driver to fail loading.
>
> I would greatly appreciate any feedbacks.
>
Hi Perry,
Which tree or patchset is this based on?
It doesn't apply cleanly onto either 6.7 or 6.8.
First I had to revert [1], then apply [2] before applying this patchset
and finally reapply [1].
I did not apply the "prefcore" patchset which I keep in a separate branch.
Is this correct or did I mess up something with my branches?
---
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.8-rc2&id=febab20caebac959fdc3d7520bc52de8b1184455
[2]
https://lore.kernel.org/linux-pm/cover.1706255676.git.perry.yuan@amd.com/
Cheers,
Tor Vic
> Thank you!
>
>
> Perry Yuan (6):
> ACPI: CPPC: enable AMD CPPC V2 support for family 17h processors
> cpufreq:amd-pstate: fix the nominal freq value set
> cpufreq:amd-pstate: initialize nominal_freq of each cpudata
> cpufreq:amd-pstate: get pstate transition delay and latency value from
> ACPI tables
> cppc_acpi: print error message if CPPC is unsupported
> cpufreq:amd-pstate: add quirk for the pstate CPPC capabilities missing
>
> arch/x86/kernel/acpi/cppc.c | 2 +-
> drivers/acpi/cppc_acpi.c | 6 +-
> drivers/cpufreq/amd-pstate.c | 112 ++++++++++++++++++++++++++++-------
> include/linux/amd-pstate.h | 6 ++
> 4 files changed, 102 insertions(+), 24 deletions(-)
>
next prev parent reply other threads:[~2024-01-31 11:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 8:50 [PATCH 0/6] AMD Pstate Fixes And Enhancements Perry Yuan
2024-01-31 8:50 ` [PATCH 1/6] ACPI: CPPC: enable AMD CPPC V2 support for family 17h processors Perry Yuan
2024-01-31 21:45 ` Mario Limonciello
2024-01-31 8:50 ` [PATCH 2/6] cpufreq:amd-pstate: fix the nominal freq value set Perry Yuan
2024-01-31 21:46 ` Mario Limonciello
2024-01-31 8:50 ` [PATCH 3/6] cpufreq:amd-pstate: initialize nominal_freq of each cpudata Perry Yuan
2024-01-31 21:47 ` Mario Limonciello
2024-01-31 8:50 ` [PATCH 4/6] cpufreq:amd-pstate: get pstate transition delay and latency value from ACPI tables Perry Yuan
2024-01-31 21:49 ` Mario Limonciello
2024-01-31 8:50 ` [PATCH 5/6] cppc_acpi: print error message if CPPC is unsupported Perry Yuan
2024-01-31 21:51 ` Mario Limonciello
2024-01-31 8:50 ` [PATCH 6/6] cpufreq:amd-pstate: add quirk for the pstate CPPC capabilities missing Perry Yuan
2024-01-31 21:59 ` Mario Limonciello
2024-02-02 9:05 ` Yuan, Perry
2024-01-31 11:36 ` Tor Vic [this message]
2024-02-02 9:12 ` [PATCH 0/6] AMD Pstate Fixes And Enhancements Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63c2b3d7-083a-4daa-ba40-629b3223a92d@mailbox.org \
--to=torvic9@mailbox.org \
--cc=Alexander.Deucher@amd.com \
--cc=Borislav.Petkov@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=perry.yuan@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).