From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: akpm@linux-foundation.org,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] linux/container_of.h: switch to static_assert
Date: Fri, 15 Oct 2021 13:46:01 +0200 [thread overview]
Message-ID: <63cb6259-ea8e-46a8-63fc-d942c2225fcc@rasmusvillemoes.dk> (raw)
In-Reply-To: <YWl+hQTa4Pd1A7zg@smile.fi.intel.com>
On 15/10/2021 15.13, Andy Shevchenko wrote:
> Btw, shouldn't we also remove build_bug.h in the container_of.h with this?
> (Or if this goes first, do we still need bug.h?)
>
We absolutely need build_bug.h, as that is where static_assert is defined.
container_of.h doesn't include bug.h AFAICT, nor should it need to.
(We should still find a quiet place for __same_type and have
container_of include that header, but that's unrelated to this patch.)
Rasmus
next prev parent reply other threads:[~2021-10-15 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 9:05 [PATCH] linux/container_of.h: switch to static_assert Rasmus Villemoes
2021-10-15 13:08 ` Miguel Ojeda
2021-10-15 13:11 ` Andy Shevchenko
2021-10-15 13:13 ` Andy Shevchenko
2021-10-15 11:46 ` Rasmus Villemoes [this message]
2021-10-15 17:33 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63cb6259-ea8e-46a8-63fc-d942c2225fcc@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).