linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] linux/container_of.h: switch to static_assert
Date: Fri, 15 Oct 2021 15:08:05 +0200	[thread overview]
Message-ID: <CANiq72mG2dX++A9S9+ycS-67rbkhFgF7B9wgEEpOoBKYpgPAkg@mail.gmail.com> (raw)
In-Reply-To: <20211015090530.2774079-1-linux@rasmusvillemoes.dk>

On Fri, Oct 15, 2021 at 11:05 AM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> _Static_assert() is evaluated already in the compiler's frontend, and
> gives a somehat more to-the-point error, compared to the BUILD_BUG_ON
> macro, which only fires after the optimizer has had a chance to
> eliminate calls to functions marked with
> __attribute__((error)). In theory, this might make builds a tiny bit
> faster.

Thanks for this! Very much in favor!

Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

Perhaps Andrew may want to add a link to the related discussion
thread: https://lore.kernel.org/lkml/20211014132331.GA4811@kernel.org/T/

Cheers,
Miguel

  reply	other threads:[~2021-10-15 13:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15  9:05 [PATCH] linux/container_of.h: switch to static_assert Rasmus Villemoes
2021-10-15 13:08 ` Miguel Ojeda [this message]
2021-10-15 13:11 ` Andy Shevchenko
2021-10-15 13:13   ` Andy Shevchenko
2021-10-15 11:46     ` Rasmus Villemoes
2021-10-15 17:33 ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANiq72mG2dX++A9S9+ycS-67rbkhFgF7B9wgEEpOoBKYpgPAkg@mail.gmail.com \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).