From: Joe Perches <joe@perches.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Dmitry Safonov <dima@arista.com>,
Michal Hocko <mhocko@suse.com>,
Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [PATCH] printk: Add loglevel for "do not print to consoles".
Date: Wed, 06 May 2020 18:02:36 -0700 [thread overview]
Message-ID: <63f58a1c334d8d44ddf1788091be9b2232054b03.camel@perches.com> (raw)
In-Reply-To: <0d513c80-8c8e-17b6-5b9c-73c7bca77252@i-love.sakura.ne.jp>
On Thu, 2020-05-07 at 09:50 +0900, Tetsuo Handa wrote:
> On 2020/05/07 0:26, Joe Perches wrote:
> > On Wed, 2020-05-06 at 18:45 +0900, Tetsuo Handa wrote:
> > > On 2020/04/28 20:33, Tetsuo Handa wrote:
> > > > On 2020/04/27 15:21, Sergey Senozhatsky wrote:
> > > > > > KERN_NO_CONSOLES is for type of messages where "saved for later analysis" is
> > > > > > important but "printed for immediate notification" is not important.
> > > > > > In other words, KERN_NO_CONSOLES is NOT for dying messages where "printed for
> > > > > > immediate notification" is important.
> > > > >
> > > > > per-console loglevel is a user configurable parameter.
> > > > > KERN_NO_CONSOLES is a hard-coded policy.
> > > >
> > > > But given that whether to use KERN_NO_CONSOLES is configurable via e.g. sysctl,
> > > > KERN_NO_CONSOLES will become a user configurable parameter. What's still wrong?
> > > >
> > >
> > > Any problems remaining?
> >
> > printk_get_level / printk_skip_level and the various
> > uses of %pV using printk_get_level
> >
>
> Excuse me, but what do you mean?
>
> I wish printk() accepts "loglevel" argument detached from "fmt" argument (e.g.
I think that's a bad idea as it would expand
_every_ use of printk with another argument
and overall code size would increase for very
little value.
And do look at the code and uses of printk_get_level.
next prev parent reply other threads:[~2020-05-07 1:02 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 2:42 [PATCH] printk: Add loglevel for "do not print to consoles" Tetsuo Handa
2020-04-24 13:28 ` Steven Rostedt
2020-04-24 14:00 ` Tetsuo Handa
2020-04-24 14:31 ` Steven Rostedt
2020-04-24 15:28 ` Tetsuo Handa
2020-04-24 15:42 ` Steven Rostedt
2020-04-24 15:52 ` Dmitry Safonov
2020-04-24 16:10 ` Tetsuo Handa
2020-04-24 16:21 ` Steven Rostedt
2020-04-24 16:34 ` Tetsuo Handa
2020-04-25 0:46 ` Sergey Senozhatsky
2020-04-25 1:07 ` Tetsuo Handa
2020-04-27 6:21 ` Sergey Senozhatsky
2020-04-28 11:33 ` Tetsuo Handa
2020-04-28 12:18 ` Michal Hocko
2020-04-28 13:11 ` Tetsuo Handa
2020-04-28 15:45 ` Michal Hocko
2020-04-28 16:23 ` Tetsuo Handa
2020-04-29 14:21 ` Michal Hocko
2020-04-29 16:35 ` Tetsuo Handa
2020-05-13 6:26 ` Sergey Senozhatsky
2020-05-13 7:58 ` Tetsuo Handa
2020-05-13 10:04 ` Petr Mladek
2020-05-13 10:49 ` Michal Hocko
2020-05-13 11:24 ` Tetsuo Handa
2020-05-13 12:19 ` Petr Mladek
2020-05-13 12:59 ` Tetsuo Handa
2020-05-14 8:00 ` Petr Mladek
2020-05-14 11:23 ` Tetsuo Handa
2020-05-14 16:26 ` Petr Mladek
2020-05-14 23:24 ` Tetsuo Handa
2020-05-13 11:03 ` Tetsuo Handa
2020-05-13 12:34 ` Petr Mladek
2020-05-13 13:46 ` Steven Rostedt
2020-05-13 14:03 ` Tetsuo Handa
2020-05-13 13:55 ` Steven Rostedt
2020-05-13 15:20 ` Tetsuo Handa
2020-05-06 9:45 ` Tetsuo Handa
2020-05-06 15:26 ` Joe Perches
2020-05-07 0:50 ` Tetsuo Handa
2020-05-07 1:02 ` Joe Perches [this message]
2020-05-07 5:13 ` Tetsuo Handa
2020-05-07 5:30 ` Joe Perches
2020-05-07 5:39 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f58a1c334d8d44ddf1788091be9b2232054b03.camel@perches.com \
--to=joe@perches.com \
--cc=dima@arista.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).